You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ta...@apache.org on 2010/08/31 23:48:26 UTC
svn commit: r991346 - in
/activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp:
Connection.cs MessageConsumer.cs MessageProducer.cs Session.cs
SessionExecutor.cs
Author: tabish
Date: Tue Aug 31 21:48:26 2010
New Revision: 991346
URL: http://svn.apache.org/viewvc?rev=991346&view=rev
Log:
Tag fields that really need to be readonly as such.
Modified:
activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/Connection.cs
activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/MessageConsumer.cs
activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/MessageProducer.cs
activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/Session.cs
activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/SessionExecutor.cs
Modified: activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/Connection.cs
URL: http://svn.apache.org/viewvc/activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/Connection.cs?rev=991346&r1=991345&r2=991346&view=diff
==============================================================================
--- activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/Connection.cs (original)
+++ activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/Connection.cs Tue Aug 31 21:48:26 2010
@@ -62,9 +62,9 @@ namespace Apache.NMS.Stomp
private readonly Atomic<bool> started = new Atomic<bool>(false);
private ConnectionMetaData metaData = null;
private bool disposed = false;
- private IdGenerator clientIdGenerator;
+ private readonly IdGenerator clientIdGenerator;
private CountDownLatch transportInterruptionProcessingComplete;
- private MessageTransformation messageTransformation;
+ private readonly MessageTransformation messageTransformation;
public Connection(Uri connectionUri, ITransport transport, IdGenerator clientIdGenerator)
{
Modified: activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/MessageConsumer.cs
URL: http://svn.apache.org/viewvc/activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/MessageConsumer.cs?rev=991346&r1=991345&r2=991346&view=diff
==============================================================================
--- activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/MessageConsumer.cs (original)
+++ activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/MessageConsumer.cs Tue Aug 31 21:48:26 2010
@@ -44,8 +44,8 @@ namespace Apache.NMS.Stomp
private MessageAck pendingAck = null;
- private Atomic<bool> started = new Atomic<bool>();
- private Atomic<bool> deliveringAcks = new Atomic<bool>();
+ private readonly Atomic<bool> started = new Atomic<bool>();
+ private readonly Atomic<bool> deliveringAcks = new Atomic<bool>();
protected bool disposed = false;
private int deliveredCounter = 0;
Modified: activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/MessageProducer.cs
URL: http://svn.apache.org/viewvc/activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/MessageProducer.cs?rev=991346&r1=991345&r2=991346&view=diff
==============================================================================
--- activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/MessageProducer.cs (original)
+++ activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/MessageProducer.cs Tue Aug 31 21:48:26 2010
@@ -30,7 +30,7 @@ namespace Apache.NMS.Stomp
{
private Session session;
private bool closed = false;
- private object closedLock = new object();
+ private readonly object closedLock = new object();
private readonly ProducerInfo info;
private int producerSequenceId = 0;
@@ -42,7 +42,7 @@ namespace Apache.NMS.Stomp
private bool disableMessageTimestamp = false;
protected bool disposed = false;
- private MessageTransformation messageTransformation;
+ private readonly MessageTransformation messageTransformation;
public MessageProducer(Session session, ProducerInfo info)
{
Modified: activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/Session.cs
URL: http://svn.apache.org/viewvc/activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/Session.cs?rev=991346&r1=991345&r2=991346&view=diff
==============================================================================
--- activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/Session.cs (original)
+++ activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/Session.cs Tue Aug 31 21:48:26 2010
@@ -38,8 +38,8 @@ namespace Apache.NMS.Stomp
private readonly IDictionary consumers = Hashtable.Synchronized(new Hashtable());
private readonly IDictionary producers = Hashtable.Synchronized(new Hashtable());
- private SessionExecutor executor;
- private TransactionContext transactionContext;
+ private readonly SessionExecutor executor;
+ private readonly TransactionContext transactionContext;
private Connection connection;
private bool dispatchAsync;
Modified: activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/SessionExecutor.cs
URL: http://svn.apache.org/viewvc/activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/SessionExecutor.cs?rev=991346&r1=991345&r2=991346&view=diff
==============================================================================
--- activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/SessionExecutor.cs (original)
+++ activemq/activemq-dotnet/Apache.NMS.Stomp/trunk/src/main/csharp/SessionExecutor.cs Tue Aug 31 21:48:26 2010
@@ -25,11 +25,11 @@ namespace Apache.NMS.Stomp
{
public class SessionExecutor : Threads.Task
{
- private MessageDispatchChannel messageQueue = new MessageDispatchChannel();
+ private readonly MessageDispatchChannel messageQueue = new MessageDispatchChannel();
private TaskRunner taskRunner = null;
- private Session session = null;
- private IDictionary consumers = null;
+ private readonly Session session = null;
+ private readonly IDictionary consumers = null;
public SessionExecutor(Session session, IDictionary consumers)
{