[GitHub] [pulsar] Renkai commented on a change in pull request #9616: Evict usage of ManagedLedgerImpl in ManagedLedgerFactoryImpl

[GitBox <gi...@apache.org>]

Renkai commented on a change in pull request #9616:
URL: https://github.com/apache/pulsar/pull/9616#discussion_r578506072



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/ManagedLedgerClientFactory.java
##########
@@ -102,7 +102,15 @@ public void initialize(ServiceConfiguration conf, ZooKeeper zkClient,
         };
 
         this.managedLedgerFactory =
-                new ManagedLedgerFactoryImpl(bkFactory, zkClient, managedLedgerFactoryConfig, statsLogger);
+                createManagedLedgerFactory(zkClient, managedLedgerFactoryConfig, statsLogger, bkFactory);
+    }
+
+    protected ManagedLedgerFactoryImpl
+    createManagedLedgerFactory(ZooKeeper zkClient,

Review comment:
       My IDE deal with the indent for me, I'm not sure what's the meaning of your 'fix indent' here. But I think the reason why the indent looks a little weird is that `BookkeeperFactoryForCustomEnsemblePlacementPolicy` is too long, the IDE has to format like this to make a line less than 120 chars.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org