You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "Kontinuation (via GitHub)" <gi...@apache.org> on 2026/02/05 08:42:27 UTC

[PR] [GH-2611] Merge linestring splitting results to avoid extra segments [sedona]

Kontinuation opened a new pull request, #2612:
URL: https://github.com/apache/sedona/pull/2612

   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   ## Is this PR related to a ticket?
   
   - Yes, and the PR name follows the format `[GH-2611] my subject`. Closes #2611 
   
   ## What changes were proposed in this PR?
   
   This is a problem of JTS and GEOS. The follow figure illustrated this problem:
   
   <img width="1087" height="520" alt="Screenshot 2026-02-04 at 9 34 03 PM" src="https://github.com/user-attachments/assets/3595104b-3161-4a09-94e3-e5b24b359a2e" />
   
   
   The circle is split by a vertical knife, the result should be a multi linestring containing 2 linestrings. However, the line splitting algorithm starts from an arbitrary point (S in the figure), traverses forward (counter-clockwise in this example) and generate a split when hitting the knife. There will be 3 pieces generated.
   
   The fix is to merge splits on non-cutting nodes, they were referred as non-stop nodes. S (the starting point of traversal) is a non-stop node. We can merge piece A and piece C into one piece, resulting in 2 linestrings.
   
   ## How was this patch tested?
   
   Passing newly added tests
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [GH-2611] Merge linestring splitting results to avoid extra segments [sedona]

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #2612:
URL: https://github.com/apache/sedona/pull/2612


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org