You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/01/28 20:03:05 UTC
[GitHub] [geode] albertogpz opened a new pull request #7327: GEODE-10000: Avoid gfsh stop gateway sender error when stopped a seco…
albertogpz opened a new pull request #7327:
URL: https://github.com/apache/geode/pull/7327
…nd time
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mhansonp commented on pull request #7327: GEODE-10000: Avoid gfsh stop gateway sender error when stopped a seco…
Posted by GitBox <gi...@apache.org>.
mhansonp commented on pull request #7327:
URL: https://github.com/apache/geode/pull/7327#issuecomment-1027157870
I don't usually request comments, but it would have been handy to have some here or in the bug to explain what you decided to do in light of the problem with your change. It looks like you decided to back it out and add a test that would catch the problem you created (though backed out).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] albertogpz commented on pull request #7327: GEODE-10000: Avoid gfsh stop gateway sender error when stopped a seco…
Posted by GitBox <gi...@apache.org>.
albertogpz commented on pull request #7327:
URL: https://github.com/apache/geode/pull/7327#issuecomment-1027160076
> I don't usually request comments, but it would have been handy to have some here or in the bug to explain what you decided to do in light of the problem with your change. It looks like you decided to back it out and add a test that would catch the problem you created (though backed out).
Sorry for not adding comments to the fix. I assumed it would be easy to understand by looking at the change in code and at the test case but I agree it should have been better to add comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] albertogpz merged pull request #7327: GEODE-10000: Avoid gfsh stop gateway sender error when stopped a seco…
Posted by GitBox <gi...@apache.org>.
albertogpz merged pull request #7327:
URL: https://github.com/apache/geode/pull/7327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org