You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "janhoy (via GitHub)" <gi...@apache.org> on 2025/01/22 19:14:26 UTC
[PR] SOLR-17342 Avoid loading from remote CDN [solr-site]
janhoy opened a new pull request, #136:
URL: https://github.com/apache/solr-site/pull/136
This PR stores some fonts and CSS locally in the static site instead of relying on CDN.
For the "Slick" carousel I cannot see that it is in use on our site now, so I have commented it out instead of downloading and adding to the repo. If you know that we'll need a carousel/slider we can re-enable it once we need it. Otherwise, the code can simply be removed.
I used the tool [Google Font Downloader](https://github.com/Bloggify/google-font-downloader) for downloading the two google fonts. FontAwesome was downloaded and added manually. It is not the latest version...
Tested the PR locally with `./build.sh -l`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17342 Avoid loading from remote CDN [solr-site]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #136:
URL: https://github.com/apache/solr-site/pull/136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17342 Avoid loading from remote CDN [solr-site]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #136:
URL: https://github.com/apache/solr-site/pull/136#issuecomment-2608368672
I added licensing headers for CSS and LICENSE.txt files for the fonts to be more explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17342 Avoid loading from remote CDN [solr-site]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #136:
URL: https://github.com/apache/solr-site/pull/136#issuecomment-2608096529
> Didn't know about `#}` as a comment pattern. Thanks for this chore.
I did not either, so I changed it to `<!--` :-) My IDEA did it for me, since it believed that this file was a Jinja2 template, probably since it is inside a "templates" folder. It would be a valid Jinja block comment. But not HTML.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17342 Avoid loading from remote CDN [solr-site]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #136:
URL: https://github.com/apache/solr-site/pull/136#issuecomment-2608272766
Interestingly, the staging site already reports errors due to CSP.
<img width="753" alt="Skjermbilde 2025-01-22 kl 21 59 30" src="https://github.com/user-attachments/assets/fdfcc17e-4de2-4e34-bc1c-e4c46106b06e" />
So after merge we'll be able to verify that these are now gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org