You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2013/11/05 17:06:04 UTC
Review Request 15241: Renamed two modules with same name to avoid confusion
while reporting test results
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15241/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
It was told that reporting results for a given test run with same module names is confusing.
Renamed them with few prefixes to avoid confusion.
Note: There are still files with name as below for cpu limits related testing and similarly available for memory as well. Need to check the difference between these two contents.
That will be different check again.
"test_cpu_project_limits.py"
"test_cpu_limits.py"
Diffs
-----
test/integration/component/cpu_limits/test_cpu_project_limits.py PRE-CREATION
test/integration/component/cpu_limits/test_project_limits.py 63d1a98
test/integration/component/memory_limits/test_mem_project_limits.py PRE-CREATION
test/integration/component/memory_limits/test_project_limits.py 1c0ed92
Diff: https://reviews.apache.org/r/15241/diff/
Testing
-------
Thanks,
Santhosh Edukulla
Re: Review Request 15241: Renamed two modules with same name to avoid
confusion while reporting test results
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On Nov. 8, 2013, 4:30 a.m., SrikanteswaraRao Talluri wrote:
> > Ship It!
>
> SrikanteswaraRao Talluri wrote:
> These two files are already covered as part of https://reviews.apache.org/r/14872/
ok.
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15241/#review28495
-----------------------------------------------------------
On Nov. 6, 2013, 2:37 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15241/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 2:37 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> It was told that reporting results for a given test run with same module names is confusing.
> Renamed them with few prefixes to avoid confusion.
>
> Note: There are still files with name as below for cpu limits related testing and similarly available for memory as well. Need to check the difference between these two contents.
> That will be different check again.
> "test_cpu_project_limits.py"
> "test_cpu_limits.py"
>
>
> Diffs
> -----
>
> test/integration/component/cpu_limits/test_cpu_project_limits.py PRE-CREATION
> test/integration/component/cpu_limits/test_project_limits.py 63d1a98
> test/integration/component/memory_limits/test_mem_project_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py 1c0ed92
>
> Diff: https://reviews.apache.org/r/15241/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 15241: Renamed two modules with same name to avoid
confusion while reporting test results
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
> On Nov. 8, 2013, 4:30 a.m., SrikanteswaraRao Talluri wrote:
> > Ship It!
These two files are already covered as part of https://reviews.apache.org/r/14872/
- SrikanteswaraRao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15241/#review28495
-----------------------------------------------------------
On Nov. 6, 2013, 2:37 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15241/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 2:37 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> It was told that reporting results for a given test run with same module names is confusing.
> Renamed them with few prefixes to avoid confusion.
>
> Note: There are still files with name as below for cpu limits related testing and similarly available for memory as well. Need to check the difference between these two contents.
> That will be different check again.
> "test_cpu_project_limits.py"
> "test_cpu_limits.py"
>
>
> Diffs
> -----
>
> test/integration/component/cpu_limits/test_cpu_project_limits.py PRE-CREATION
> test/integration/component/cpu_limits/test_project_limits.py 63d1a98
> test/integration/component/memory_limits/test_mem_project_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py 1c0ed92
>
> Diff: https://reviews.apache.org/r/15241/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 15241: Renamed two modules with same name to avoid
confusion while reporting test results
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15241/#review28495
-----------------------------------------------------------
Ship it!
Ship It!
- SrikanteswaraRao Talluri
On Nov. 6, 2013, 2:37 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15241/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 2:37 p.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> It was told that reporting results for a given test run with same module names is confusing.
> Renamed them with few prefixes to avoid confusion.
>
> Note: There are still files with name as below for cpu limits related testing and similarly available for memory as well. Need to check the difference between these two contents.
> That will be different check again.
> "test_cpu_project_limits.py"
> "test_cpu_limits.py"
>
>
> Diffs
> -----
>
> test/integration/component/cpu_limits/test_cpu_project_limits.py PRE-CREATION
> test/integration/component/cpu_limits/test_project_limits.py 63d1a98
> test/integration/component/memory_limits/test_mem_project_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py 1c0ed92
>
> Diff: https://reviews.apache.org/r/15241/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 15241: Renamed two modules with same name to avoid
confusion while reporting test results
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15241/
-----------------------------------------------------------
(Updated Nov. 6, 2013, 2:37 p.m.)
Review request for cloudstack and Girish Shilamkar.
Repository: cloudstack-git
Description
-------
It was told that reporting results for a given test run with same module names is confusing.
Renamed them with few prefixes to avoid confusion.
Note: There are still files with name as below for cpu limits related testing and similarly available for memory as well. Need to check the difference between these two contents.
That will be different check again.
"test_cpu_project_limits.py"
"test_cpu_limits.py"
Diffs
-----
test/integration/component/cpu_limits/test_cpu_project_limits.py PRE-CREATION
test/integration/component/cpu_limits/test_project_limits.py 63d1a98
test/integration/component/memory_limits/test_mem_project_limits.py PRE-CREATION
test/integration/component/memory_limits/test_project_limits.py 1c0ed92
Diff: https://reviews.apache.org/r/15241/diff/
Testing
-------
Thanks,
Santhosh Edukulla