[GitHub] [airflow] ziliangpeng commented on a change in pull request #15195: Fix dag sort in dag stats

[GitBox <gi...@apache.org>]

ziliangpeng commented on a change in pull request #15195:
URL: https://github.com/apache/airflow/pull/15195#discussion_r641903896



##########
File path: airflow/utils/dag_processing.py
##########
@@ -834,7 +834,7 @@ def _log_file_processing_stats(self, known_file_paths):
             rows.append((file_path, processor_pid, runtime, num_dags, num_errors, last_runtime, last_run))
 
         # Sort by longest last runtime. (Can't sort None values in python3)

Review comment:
       The comment and the code was not consistent, as you can see from the code above
   ```
   rows.append((file_path, processor_pid, runtime, num_dags, num_errors, last_runtime, last_run))
   ```
   index (5) is last_runtime. I'm just making the code and comment consistent.
   
   It was probably that when more fields were added into the row, and sort field was not updated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org