You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "amorynan (via GitHub)" <gi...@apache.org> on 2024/09/14 02:20:08 UTC
[PR] [fix](array-funcs)fix array func with decimal type [doris]
amorynan opened a new pull request, #40839:
URL: https://github.com/apache/doris/pull/40839
## Proposed changes
[fix](array-funcs)
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2370135466
<details>
<summary>TPC-DS: <b>Total hot run time: 190951 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8ad3584ddf86d5905c9c3c4b69d24638f597ebef, data reload: false
query1 940 388 396 388
query2 6197 2045 2053 2045
query3 8685 196 196 196
query4 33149 23549 23481 23481
query5 4137 480 461 461
query6 282 183 156 156
query7 4194 299 293 293
query8 274 216 222 216
query9 9376 2671 2648 2648
query10 492 274 256 256
query11 18011 15259 15161 15161
query12 159 99 96 96
query13 1530 440 401 401
query14 9831 6484 7420 6484
query15 285 174 181 174
query16 8138 502 446 446
query17 1747 608 589 589
query18 2161 329 332 329
query19 372 150 153 150
query20 119 124 115 115
query21 223 107 109 107
query22 4743 4515 4496 4496
query23 34987 34667 34676 34667
query24 11057 2915 2922 2915
query25 601 402 416 402
query26 732 158 163 158
query27 2014 283 286 283
query28 6550 2456 2423 2423
query29 751 442 422 422
query30 247 160 156 156
query31 1031 771 800 771
query32 103 54 59 54
query33 673 298 296 296
query34 896 506 474 474
query35 862 730 731 730
query36 1078 937 933 933
query37 148 93 86 86
query38 4085 3883 3901 3883
query39 1479 1439 1433 1433
query40 205 98 106 98
query41 50 50 49 49
query42 119 99 94 94
query43 512 486 492 486
query44 1174 832 809 809
query45 195 165 170 165
query46 1170 754 796 754
query47 1922 1809 1876 1809
query48 474 355 364 355
query49 874 413 402 402
query50 844 397 404 397
query51 7168 6993 6912 6912
query52 102 89 91 89
query53 284 176 175 175
query54 1101 445 449 445
query55 77 76 72 72
query56 288 252 250 250
query57 1235 1092 1098 1092
query58 234 225 218 218
query59 3178 3011 2939 2939
query60 289 263 262 262
query61 102 98 102 98
query62 809 636 625 625
query63 221 183 185 183
query64 3756 648 606 606
query65 3254 3164 3174 3164
query66 783 327 306 306
query67 15941 15508 15427 15427
query68 4458 580 569 569
query69 581 292 308 292
query70 1186 1065 1107 1065
query71 401 271 269 269
query72 7539 3961 3972 3961
query73 772 335 329 329
query74 10304 9032 8986 8986
query75 4140 2622 2673 2622
query76 3490 916 885 885
query77 667 303 311 303
query78 9968 9252 9196 9196
query79 2383 542 557 542
query80 856 453 442 442
query81 571 244 239 239
query82 620 141 144 141
query83 356 133 131 131
query84 284 78 84 78
query85 1355 294 275 275
query86 423 290 298 290
query87 4419 4313 4346 4313
query88 3505 2338 2330 2330
query89 394 285 295 285
query90 2044 193 196 193
query91 206 141 142 141
query92 63 48 55 48
query93 2200 551 552 551
query94 1002 295 306 295
query95 361 268 264 264
query96 612 274 286 274
query97 3248 3119 3194 3119
query98 224 214 195 195
query99 1519 1273 1291 1273
Total cold run time: 298851 ms
Total hot run time: 190951 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array agg func with decimal type [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2415595189
2.0 do not merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2360556740
<details>
<summary>TPC-DS: <b>Total hot run time: 193850 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1bfa306fa571b46a05e1566f34f89ae9eb92b53b, data reload: false
query1 1260 888 870 870
query2 6292 2016 2002 2002
query3 10785 4013 3914 3914
query4 62834 27307 23480 23480
query5 5171 446 459 446
query6 415 172 162 162
query7 5510 297 286 286
query8 300 219 217 217
query9 9091 2641 2635 2635
query10 482 300 268 268
query11 17979 15206 15670 15206
query12 158 103 103 103
query13 1506 424 407 407
query14 10901 7610 6708 6708
query15 214 178 170 170
query16 7097 514 469 469
query17 1173 606 583 583
query18 1886 313 310 310
query19 235 152 149 149
query20 123 112 112 112
query21 206 106 109 106
query22 4740 4345 4633 4345
query23 35048 33688 33747 33688
query24 5991 2911 2867 2867
query25 504 428 391 391
query26 639 154 156 154
query27 1760 288 283 283
query28 4252 2440 2413 2413
query29 666 412 422 412
query30 233 161 160 160
query31 966 786 796 786
query32 74 52 56 52
query33 406 289 286 286
query34 914 485 470 470
query35 839 723 716 716
query36 1077 941 938 938
query37 151 83 88 83
query38 3924 3801 3886 3801
query39 1509 1449 1406 1406
query40 204 95 96 95
query41 50 49 47 47
query42 117 95 93 93
query43 516 490 486 486
query44 1137 809 788 788
query45 192 170 163 163
query46 1128 754 747 747
query47 1986 1841 1843 1841
query48 464 357 362 357
query49 733 408 403 403
query50 832 411 396 396
query51 7105 6936 6809 6809
query52 99 85 83 83
query53 245 172 173 172
query54 557 442 438 438
query55 75 72 76 72
query56 256 248 250 248
query57 1224 1085 1115 1085
query58 219 226 237 226
query59 3266 3196 2993 2993
query60 287 262 259 259
query61 103 101 101 101
query62 763 661 654 654
query63 223 188 187 187
query64 1717 623 609 609
query65 3274 3171 3184 3171
query66 684 320 303 303
query67 15914 15587 15841 15587
query68 4480 556 558 556
query69 453 293 290 290
query70 1175 1052 1092 1052
query71 365 266 266 266
query72 6368 3989 4019 3989
query73 755 318 322 318
query74 9860 8894 8954 8894
query75 3372 2684 2682 2682
query76 1694 883 862 862
query77 462 290 297 290
query78 9967 9179 9156 9156
query79 1135 539 543 539
query80 889 429 425 425
query81 516 239 239 239
query82 1387 138 138 138
query83 246 136 136 136
query84 292 81 71 71
query85 887 284 276 276
query86 323 283 291 283
query87 4407 4372 4277 4277
query88 3261 2316 2315 2315
query89 395 281 284 281
query90 1958 190 190 190
query91 172 141 141 141
query92 56 48 47 47
query93 1546 520 524 520
query94 737 289 285 285
query95 345 252 244 244
query96 629 278 273 273
query97 3266 3082 3108 3082
query98 206 224 194 194
query99 1910 1303 1272 1272
Total cold run time: 314195 ms
Total hot run time: 193850 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2370123640
<details>
<summary>TPC-H: <b>Total hot run time: 41651 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8ad3584ddf86d5905c9c3c4b69d24638f597ebef, data reload: false
------ Round 1 ----------------------------------
q1 17600 7398 7310 7310
q2 2007 291 281 281
q3 12022 1057 1181 1057
q4 10571 761 802 761
q5 7744 3136 3093 3093
q6 243 149 144 144
q7 1014 613 609 609
q8 9454 2034 2031 2031
q9 6804 6411 6410 6410
q10 7003 2259 2290 2259
q11 443 258 251 251
q12 409 221 208 208
q13 17770 2992 2962 2962
q14 258 211 228 211
q15 574 522 526 522
q16 671 608 614 608
q17 977 813 821 813
q18 7425 6976 6705 6705
q19 1392 1010 982 982
q20 596 293 285 285
q21 3910 3137 3304 3137
q22 1130 1027 1012 1012
Total cold run time: 110017 ms
Total hot run time: 41651 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7291 7198 7295 7198
q2 322 249 236 236
q3 3068 2978 2892 2892
q4 2070 1827 1823 1823
q5 5618 5591 5665 5591
q6 237 143 140 140
q7 2206 1804 1801 1801
q8 3295 3469 3452 3452
q9 8773 8774 8784 8774
q10 3413 3534 3495 3495
q11 579 479 476 476
q12 810 600 608 600
q13 9678 3156 3156 3156
q14 308 267 262 262
q15 604 528 518 518
q16 710 684 658 658
q17 1815 1586 1611 1586
q18 8237 7736 7752 7736
q19 1706 1629 1561 1561
q20 2127 1853 1879 1853
q21 5538 5216 5499 5216
q22 1138 1109 1069 1069
Total cold run time: 69543 ms
Total hot run time: 60093 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2370118470
TeamCity be ut coverage result:
Function Coverage: 37.26% (9604/25774)
Line Coverage: 28.68% (79498/277200)
Region Coverage: 28.12% (41119/146201)
Branch Coverage: 24.77% (20960/84632)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8ad3584ddf86d5905c9c3c4b69d24638f597ebef_8ad3584ddf86d5905c9c3c4b69d24638f597ebef/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2370141530
<details>
<summary>ClickBench: <b>Total hot run time: 32.54 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8ad3584ddf86d5905c9c3c4b69d24638f597ebef, data reload: false
query1 0.05 0.04 0.05
query2 0.07 0.03 0.03
query3 0.23 0.06 0.06
query4 1.64 0.10 0.10
query5 0.51 0.50 0.51
query6 1.13 0.73 0.73
query7 0.02 0.02 0.02
query8 0.03 0.03 0.03
query9 0.55 0.51 0.48
query10 0.54 0.55 0.54
query11 0.14 0.10 0.11
query12 0.13 0.11 0.12
query13 0.61 0.61 0.59
query14 2.91 2.97 2.95
query15 0.88 0.81 0.84
query16 0.40 0.40 0.39
query17 1.04 1.01 1.02
query18 0.19 0.20 0.19
query19 1.92 1.84 2.04
query20 0.01 0.01 0.01
query21 15.35 0.60 0.59
query22 2.67 2.01 2.06
query23 17.41 0.87 0.72
query24 2.78 0.84 1.35
query25 0.12 0.09 0.07
query26 0.50 0.14 0.13
query27 0.04 0.04 0.04
query28 10.69 1.09 1.06
query29 12.58 3.26 3.20
query30 0.25 0.05 0.06
query31 2.89 0.38 0.37
query32 3.26 0.46 0.47
query33 2.98 2.99 3.05
query34 16.71 4.48 4.34
query35 4.50 4.50 4.39
query36 0.70 0.47 0.48
query37 0.08 0.06 0.06
query38 0.04 0.03 0.03
query39 0.03 0.02 0.02
query40 0.15 0.11 0.13
query41 0.08 0.02 0.03
query42 0.04 0.02 0.02
query43 0.03 0.02 0.03
Total cold run time: 106.88 s
Total hot run time: 32.54 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2360569233
<details>
<summary>ClickBench: <b>Total hot run time: 32.47 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1bfa306fa571b46a05e1566f34f89ae9eb92b53b, data reload: false
query1 0.04 0.04 0.04
query2 0.06 0.02 0.02
query3 0.23 0.06 0.06
query4 1.65 0.10 0.10
query5 0.50 0.48 0.51
query6 1.14 0.72 0.73
query7 0.02 0.01 0.02
query8 0.05 0.03 0.04
query9 0.56 0.49 0.50
query10 0.54 0.53 0.56
query11 0.14 0.10 0.10
query12 0.13 0.11 0.10
query13 0.60 0.59 0.59
query14 3.01 2.98 3.05
query15 0.89 0.82 0.81
query16 0.39 0.39 0.38
query17 1.05 1.04 1.05
query18 0.19 0.18 0.19
query19 1.96 1.86 2.03
query20 0.01 0.01 0.01
query21 15.35 0.60 0.58
query22 2.84 3.12 1.92
query23 17.42 0.77 0.71
query24 2.65 1.01 0.70
query25 0.20 0.12 0.15
query26 0.42 0.15 0.13
query27 0.03 0.04 0.04
query28 11.26 1.09 1.06
query29 12.57 3.30 3.23
query30 0.24 0.06 0.05
query31 2.88 0.37 0.37
query32 3.29 0.48 0.45
query33 2.97 3.03 3.02
query34 17.05 4.38 4.38
query35 4.40 4.42 4.41
query36 0.66 0.47 0.48
query37 0.09 0.06 0.05
query38 0.05 0.03 0.03
query39 0.03 0.02 0.02
query40 0.16 0.13 0.13
query41 0.07 0.02 0.02
query42 0.03 0.02 0.02
query43 0.03 0.03 0.03
Total cold run time: 107.85 s
Total hot run time: 32.47 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2350791811
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array agg func with decimal type [doris]
Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang merged PR #40839:
URL: https://github.com/apache/doris/pull/40839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2370587387
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2370587460
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2370059890
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang commented on code in PR #40839:
URL: https://github.com/apache/doris/pull/40839#discussion_r1770273397
##########
be/src/vec/functions/array/function_array_aggregation.cpp:
##########
@@ -146,6 +146,18 @@ struct ArrayAggregateImpl {
using Function = AggregateFunction<AggregateFunctionImpl<operation>>;
const DataTypeArray* data_type_array =
static_cast<const DataTypeArray*>(remove_nullable(arguments[0]).get());
+ if constexpr (operation == AggregateOperation::AVERAGE ||
Review Comment:
I think you shoud use witelist to check instead of blacklist, since if someone add a new agg operation it passed by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2350789292
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2360530277
<details>
<summary>TPC-H: <b>Total hot run time: 41881 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1bfa306fa571b46a05e1566f34f89ae9eb92b53b, data reload: false
------ Round 1 ----------------------------------
q1 17600 7418 7331 7331
q2 2057 164 155 155
q3 10819 1129 1201 1129
q4 10265 764 805 764
q5 7821 3148 3116 3116
q6 236 152 142 142
q7 1018 595 605 595
q8 9421 2069 2101 2069
q9 6913 6457 6483 6457
q10 7014 2284 2295 2284
q11 436 253 255 253
q12 408 212 227 212
q13 17789 2957 2973 2957
q14 233 211 222 211
q15 572 512 523 512
q16 664 628 604 604
q17 989 844 827 827
q18 7419 6801 6794 6794
q19 1401 989 1063 989
q20 583 301 288 288
q21 3984 3245 3191 3191
q22 1140 1016 1001 1001
Total cold run time: 108782 ms
Total hot run time: 41881 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7286 7212 7260 7212
q2 321 227 226 226
q3 3067 3005 2953 2953
q4 2018 1852 1801 1801
q5 5626 5597 5668 5597
q6 238 145 142 142
q7 2220 1822 1813 1813
q8 3347 3473 3435 3435
q9 8805 8917 8802 8802
q10 3472 3475 3480 3475
q11 606 492 480 480
q12 826 633 639 633
q13 9572 3154 3193 3154
q14 292 290 278 278
q15 575 526 523 523
q16 717 668 704 668
q17 1838 1589 1611 1589
q18 8312 7672 7747 7672
q19 1720 1514 1582 1514
q20 2118 1898 1920 1898
q21 5363 5499 5409 5409
q22 1114 1033 1019 1019
Total cold run time: 69453 ms
Total hot run time: 60293 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2360407149
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](array-funcs)fix array func with decimal type [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40839:
URL: https://github.com/apache/doris/pull/40839#issuecomment-2360604250
TeamCity be ut coverage result:
Function Coverage: 37.32% (9591/25698)
Line Coverage: 28.72% (79282/276091)
Region Coverage: 28.18% (41042/145667)
Branch Coverage: 24.80% (20910/84314)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1bfa306fa571b46a05e1566f34f89ae9eb92b53b_1bfa306fa571b46a05e1566f34f89ae9eb92b53b/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org