[jira] [Comment Edited] (FLUME-2889) Fixes to DateTime computations

["Tristan Stevens (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185805#comment-15185805 ] 

Tristan Stevens edited comment on FLUME-2889 at 3/8/16 9:12 PM:
----------------------------------------------------------------

I've been running through this again - the logic is completely screwed up, for most of the year you can get undesirable behaviour. Shall I raise it as a separate JIRA or shall we fix it here and now? I've got some new tests and a patch. I didn't realise this hadn't been committed yet.


was (Author: tmgstev):
I've been running through this again - the logic is completely screwed up, for most of the year you can get undesirable behaviour. Shall I raise it as a separate JIRA or shall we fix it here and now? I've got some new tests and a patch.

> Fixes to  DateTime computations
> -------------------------------
>
>                 Key: FLUME-2889
>                 URL: https://issues.apache.org/jira/browse/FLUME-2889
>             Project: Flume
>          Issue Type: Bug
>    Affects Versions: v1.6.0
>            Reporter: Roshan Naik
>            Assignee: Roshan Naik
>             Fix For: v1.7.0
>
>         Attachments: FLUME-2889-2.patch, FLUME-2889.3.patch, FLUME-2889.patch
>
>
> date.withYear(year+1)  can lead to incorrect date calculations .. for example if  the date is Feb 29th.   need to use date.plusYears(1) instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)