You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/15 05:20:40 UTC

[kudu-CR] webserver: support HTTP OPTIONS requests 

Hello Alexey Serbin, Andrew Wong,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/14439

to review the following change.


Change subject: webserver: support HTTP OPTIONS requests
......................................................................

webserver: support HTTP OPTIONS requests

This is a port of IMPALA-8982 to Kudu, including:
- Updating squeasel to a newer revision that handles OPTIONS rather than
  responding with an HTTP 500 error code.
- Modifying the webserver to let squeasel handle OPTIONS, bypassing SPNEGO
  authentication.

Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
---
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/util/curl_util.cc
M src/kudu/util/curl_util.h
M thirdparty/vars.sh
5 files changed, 54 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/14439/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14439
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>

[kudu-CR] webserver: support HTTP OPTIONS requests

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Alexey Serbin, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14439

to look at the new patch set (#2).

Change subject: webserver: support HTTP OPTIONS requests
......................................................................

webserver: support HTTP OPTIONS requests

This is a port of IMPALA-8982 to Kudu, including:
- Updating squeasel to a newer revision that handles OPTIONS rather than
  responding with an HTTP 500 error code.
- Modifying the webserver to let squeasel handle OPTIONS, bypassing SPNEGO
  authentication.

Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
---
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/util/curl_util.cc
M src/kudu/util/curl_util.h
M thirdparty/vars.sh
5 files changed, 55 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/14439/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14439
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>

[kudu-CR] webserver: support HTTP OPTIONS requests

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14439 )

Change subject: webserver: support HTTP OPTIONS requests
......................................................................

webserver: support HTTP OPTIONS requests

This is a port of IMPALA-8982 to Kudu, including:
- Updating squeasel to a newer revision that handles OPTIONS rather than
  responding with an HTTP 500 error code.
- Modifying the webserver to let squeasel handle OPTIONS, bypassing SPNEGO
  authentication.

Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Reviewed-on: http://gerrit.cloudera.org:8080/14439
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
---
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/util/curl_util.cc
M src/kudu/util/curl_util.h
M thirdparty/vars.sh
5 files changed, 55 insertions(+), 8 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Adar Dembo: Verified
  Thomas Tauber-Marshall: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.cloudera.org:8080/14439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14439
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>

[kudu-CR] webserver: support HTTP OPTIONS requests

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14439 )

Change subject: webserver: support HTTP OPTIONS requests
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14439
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Oct 2019 18:07:17 +0000
Gerrit-HasComments: No

[kudu-CR] webserver: support HTTP OPTIONS requests

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14439 )

Change subject: webserver: support HTTP OPTIONS requests
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14439/1/src/kudu/server/webserver-test.cc
File src/kudu/server/webserver-test.cc:

http://gerrit.cloudera.org:8080/#/c/14439/1/src/kudu/server/webserver-test.cc@464
PS1, Line 464:   curl_.set_custom_method("OPTIONS");
             :   curl_.set_return_headers(true);
             :   ASSERT_OK(curl_.FetchURL(url_, &buf_));
             :   ASSERT_STR_CONTAINS(buf_.ToString(),
             :                       "Allow: GET, POST, HEAD, OPTIONS, PROPFIND, MKCOL");
> Maybe, extract this as a method of WebserverTest and use in WebServerTest a
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/14439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14439
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2019 21:04:42 +0000
Gerrit-HasComments: Yes

[kudu-CR] webserver: support HTTP OPTIONS requests

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14439 )

Change subject: webserver: support HTTP OPTIONS requests
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14439
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Oct 2019 00:52:17 +0000
Gerrit-HasComments: No

[kudu-CR] webserver: support HTTP OPTIONS requests

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14439 )

Change subject: webserver: support HTTP OPTIONS requests
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14439
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Oct 2019 03:49:32 +0000
Gerrit-HasComments: No

[kudu-CR] webserver: support HTTP OPTIONS requests

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14439 )

Change subject: webserver: support HTTP OPTIONS requests
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14439/1/src/kudu/server/webserver-test.cc
File src/kudu/server/webserver-test.cc:

http://gerrit.cloudera.org:8080/#/c/14439/1/src/kudu/server/webserver-test.cc@464
PS1, Line 464:   curl_.set_custom_method("OPTIONS");
             :   curl_.set_return_headers(true);
             :   ASSERT_OK(curl_.FetchURL(url_, &buf_));
             :   ASSERT_STR_CONTAINS(buf_.ToString(),
             :                       "Allow: GET, POST, HEAD, OPTIONS, PROPFIND, MKCOL");
Maybe, extract this as a method of WebserverTest and use in WebServerTest and SpnegoWebserverTest ?



-- 
To view, visit http://gerrit.cloudera.org:8080/14439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14439
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Oct 2019 05:34:31 +0000
Gerrit-HasComments: Yes

[kudu-CR] webserver: support HTTP OPTIONS requests

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/14439 )

Change subject: webserver: support HTTP OPTIONS requests
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/14439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14439
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>

[kudu-CR] webserver: support HTTP OPTIONS requests

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14439 )

Change subject: webserver: support HTTP OPTIONS requests
......................................................................


Patch Set 3: Verified+1

Overriding Jenkins, unrelated test failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/14439
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc2328d41ebb30c9ab1b25cb28fcc7e56cc8a25b
Gerrit-Change-Number: 14439
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Oct 2019 05:02:22 +0000
Gerrit-HasComments: No