You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Benedikt Ritter <be...@gmail.com> on 2013/05/13 15:49:34 UTC
Re: svn commit: r1481744 - /commons/proper/dbutils/branches/2_0/src/main/java/org/apache/commons/dbutils2/BeanProcessor.java
Hi Emmanuel,
do you have format lines on save activated? It is harder to see the actual
changes if they are mixed up with code formatting.
Benedikt
2013/5/13 <eb...@apache.org>
> Author: ebourg
> Date: Mon May 13 09:17:44 2013
> New Revision: 1481744
>
> URL: http://svn.apache.org/r1481744
> Log:
> Removed an unnecessary null asignment
>
> Modified:
>
> commons/proper/dbutils/branches/2_0/src/main/java/org/apache/commons/dbutils2/BeanProcessor.java
>
> Modified:
> commons/proper/dbutils/branches/2_0/src/main/java/org/apache/commons/dbutils2/BeanProcessor.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/dbutils/branches/2_0/src/main/java/org/apache/commons/dbutils2/BeanProcessor.java?rev=1481744&r1=1481743&r2=1481744&view=diff
>
> ==============================================================================
> ---
> commons/proper/dbutils/branches/2_0/src/main/java/org/apache/commons/dbutils2/BeanProcessor.java
> (original)
> +++
> commons/proper/dbutils/branches/2_0/src/main/java/org/apache/commons/dbutils2/BeanProcessor.java
> Mon May 13 09:17:44 2013
> @@ -355,12 +355,10 @@ public class BeanProcessor {
> return c.newInstance();
>
> } catch (InstantiationException e) {
> - throw new SQLException(
> - "Cannot create " + c.getName() + ": " + e.getMessage());
> + throw new SQLException("Cannot create " + c.getName() + ": "
> + e.getMessage());
>
> } catch (IllegalAccessException e) {
> - throw new SQLException(
> - "Cannot create " + c.getName() + ": " + e.getMessage());
> + throw new SQLException("Cannot create " + c.getName() + ": "
> + e.getMessage());
> }
> }
>
> @@ -371,16 +369,14 @@ public class BeanProcessor {
> * @return A PropertyDescriptor[] describing the Class.
> * @throws SQLException if introspection failed.
> */
> - private PropertyDescriptor[] propertyDescriptors(Class<?> c)
> - throws SQLException {
> + private PropertyDescriptor[] propertyDescriptors(Class<?> c) throws
> SQLException {
> // Introspector caches BeanInfo classes for better performance
> - BeanInfo beanInfo = null;
> + BeanInfo beanInfo;
> try {
> beanInfo = Introspector.getBeanInfo(c);
>
> } catch (IntrospectionException e) {
> - throw new SQLException(
> - "Bean introspection failed: " + e.getMessage());
> + throw new SQLException("Bean introspection failed: " +
> e.getMessage());
> }
>
> return beanInfo.getPropertyDescriptors();
>
>
>
Re: svn commit: r1481744 - /commons/proper/dbutils/branches/2_0/src/main/java/org/apache/commons/dbutils2/BeanProcessor.java
Posted by sebb <se...@gmail.com>.
On 13 May 2013 15:11, Emmanuel Bourg <eb...@apache.org> wrote:
> Le 13/05/2013 15:49, Benedikt Ritter a écrit :
>> Hi Emmanuel,
>>
>> do you have format lines on save activated? It is harder to see the actual
>> changes if they are mixed up with code formatting.
>
> Hi Benedikt,
>
> My IDE is not to blame, I did reformat a few lines in the process.
In that case, please ensure that the svn log message agrees with the
commit so it is obvious that the change was intended.
Better yet, make the formatting changes in a separate commit.
> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1481744 - /commons/proper/dbutils/branches/2_0/src/main/java/org/apache/commons/dbutils2/BeanProcessor.java
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 13/05/2013 15:49, Benedikt Ritter a écrit :
> Hi Emmanuel,
>
> do you have format lines on save activated? It is harder to see the actual
> changes if they are mixed up with code formatting.
Hi Benedikt,
My IDE is not to blame, I did reformat a few lines in the process.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org