You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/05 06:34:22 UTC
[GitHub] [incubator-nuttx] hotislandn opened a new pull request #2809: arch:risc-v:bl602: enable FPU for this target.
hotislandn opened a new pull request #2809:
URL: https://github.com/apache/incubator-nuttx/pull/2809
## Summary
This patch enables the FPU support for arch:risc-v:bl602 SoC.
## Impact
RV32IM targets.
## Testing
The FPU tests within ostest passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hotislandn commented on pull request #2809: arch:risc-v:bl602: enable FPU for this target.
Posted by GitBox <gi...@apache.org>.
hotislandn commented on pull request #2809:
URL: https://github.com/apache/incubator-nuttx/pull/2809#issuecomment-774051826
> tools/refresh.sh --silent bl602evb:fpu
Thanks for your advice, xiaoxiang781216. And here comes the updated version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2809: arch:risc-v:bl602: enable FPU for this target.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2809:
URL: https://github.com/apache/incubator-nuttx/pull/2809#issuecomment-774001208
@hotislandn please run to fix the CI error:
./tools/refresh.sh --silent bl602evb:fpu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hotislandn commented on pull request #2809: arch:risc-v:bl602: enable FPU for this target.
Posted by GitBox <gi...@apache.org>.
hotislandn commented on pull request #2809:
URL: https://github.com/apache/incubator-nuttx/pull/2809#issuecomment-774974834
> > Yes, I think it's better to part of rv32/rv64 to avoid the duplication in each chip. We can refine it with new PR.
>
> Sounds good, I can put one together for all the arch this week.
Thanks and have a nice day!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2809: arch:risc-v:bl602: enable FPU for this target.
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2809:
URL: https://github.com/apache/incubator-nuttx/pull/2809#issuecomment-774918296
There was a small style issue that I fixed, but tested and looks good.
@xiaoxiang781216 did want to get your thought on this. Seems like we should just move this section to be common per arch as a general cleanup?
https://github.com/apache/incubator-nuttx/pull/2809/files#diff-4901235976e131b4b1ba0507040dc1d33d669366a5973196d4cab6c43626078bR73-R95
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2809: arch:risc-v:bl602: enable FPU for this target.
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2809:
URL: https://github.com/apache/incubator-nuttx/pull/2809#issuecomment-774969536
> Yes, I think it's better to part of rv32/rv64 to avoid the duplication in each chip. We can refine it with new PR.
Sounds good, I can put one together for all the arch this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2809: arch:risc-v:bl602: enable FPU for this target.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2809:
URL: https://github.com/apache/incubator-nuttx/pull/2809#issuecomment-774925412
Yes, I think it's better to part of rv32/rv64 to avoid the duplication in each chip. We can refine it with new PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2809: arch:risc-v:bl602: enable FPU for this target.
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2809:
URL: https://github.com/apache/incubator-nuttx/pull/2809#issuecomment-774099154
@xiaoxiang781216 I would like to give this a look this weekend before merging so I can test if that's alright.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2809: arch:risc-v:bl602: enable FPU for this target.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2809:
URL: https://github.com/apache/incubator-nuttx/pull/2809#issuecomment-774318799
> @xiaoxiang781216 I would like to give this a look this weekend before merging so I can test if that's alright.
Sure, let's wait your test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #2809: arch:risc-v:bl602: enable FPU for this target.
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #2809:
URL: https://github.com/apache/incubator-nuttx/pull/2809
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org