[GitHub] [spark] maropu commented on a change in pull request #29199: [SPARK-32403][SQL] ScriptTransformExec extract common method from process row to avoid repeated judgement

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #29199:
URL: https://github.com/apache/spark/pull/29199#discussion_r459250245



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala
##########
@@ -1063,6 +1063,9 @@ private[hive] trait HiveInspectors {
       case DateType => dateTypeInfo
       case TimestampType => timestampTypeInfo
       case NullType => voidTypeInfo
+      case dt =>
+        throw new AnalysisException(
+          s"${dt.getClass.getSimpleName.replace("$", "")} cannot be converted to Hive TypeInfo")

Review comment:
       I think this is a testing issue (2.): https://github.com/apache/spark/pull/29085#issuecomment-662794540




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org