You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/28 09:30:19 UTC

[GitHub] [kafka] cadonna commented on a change in pull request #9515: KAFKA-10561: read offsets directly from checkpoint for uninitialized tasks

cadonna commented on a change in pull request #9515:
URL: https://github.com/apache/kafka/pull/9515#discussion_r513290935



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##########
@@ -671,7 +672,7 @@ void handleLostAll() {
         // just have an empty changelogOffsets map.
         for (final TaskId id : union(HashSet::new, lockedTaskDirectories, tasks.keySet())) {
             final Task task = tasks.get(id);
-            if (task != null) {
+            if (task != null && task.state() != State.CREATED) {

Review comment:
       Are there also other task states, we need to consider here except `CREATED`? What about `CLOSED` or `SUSPENDED`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org