[kudu-CR] [subprocess] KUDU-2791 p2: add basic protobuf msg

["Attila Bukor (Code Review)" <ge...@cloudera.org>]

Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14426 )

Change subject: [subprocess] KUDU-2791 p2: add basic protobuf msg
......................................................................


Patch Set 2:

(1 comment)

> Patch Set 1:
> 
> (1 comment)
> 
> Not really sure why this is its own patch. Seems like it should at least include a test or something.

+1

http://gerrit.cloudera.org:8080/#/c/14426/1/src/kudu/subprocess/subprocess.proto
File src/kudu/subprocess/subprocess.proto:

http://gerrit.cloudera.org:8080/#/c/14426/1/src/kudu/subprocess/subprocess.proto@34
PS1, Line 34:   // The request.
> The oneof approach works for the control shell, but I wonder if we can do b
I think "any" is a proto3 feature.



-- 
To view, visit http://gerrit.cloudera.org:8080/14426
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If02ab0f9bc1bc73f9c1a46d96bdef6725b8f6954
Gerrit-Change-Number: 14426
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 Nov 2019 13:36:54 +0000
Gerrit-HasComments: Yes