You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/14 19:31:58 UTC
[jira] [Commented] (ZOOKEEPER-2470) ServerConfig#parse(String[])
ignores tickTime
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15749251#comment-15749251 ]
ASF GitHub Bot commented on ZOOKEEPER-2470:
-------------------------------------------
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/125
ZOOKEEPER-2470: ServerConfig#parse(String[]) ignores tickTime
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER-2470
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/125.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #125
----
commit 6d4545704b1f13788a5785e6ab190714c3b6d333
Author: Edward Ribeiro <ed...@gmail.com>
Date: 2016-12-14T19:23:07Z
ZOOKEEPER-2470: ServerConfig#parse(String[]) ignores tickTime
----
> ServerConfig#parse(String[]) ignores tickTime
> ----------------------------------------------
>
> Key: ZOOKEEPER-2470
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2470
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.7, 3.5.1
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Priority: Trivial
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2470.patch
>
>
> Based on bug report from ykgarfield:
> ServerConfig#parse(String[]) method has the following code:
> public void parse(String[] args) {
> ...
> if (args.length == 3) {
> tickTime = Integer.parseInt(args[2]);
> }
> if (args.length == 4) {
> maxClientCnxns = Integer.parseInt(args[3]);
> }
> }
> ```
> So if args.length == 4 tickTime isn't parsed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)