You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/19 14:15:40 UTC
[GitHub] [maven-surefire] Thihup opened a new pull request #307: Change default debug options to not use legacy options
Thihup opened a new pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307
Using the -Xdebug -Xnoagent -Djava.compiler=NONE causes the OpenJ9 JVM
to run the tests in interpreted mode, thus running them VERY slowly.
In Hotspot JVM these options are ignored.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Thihup edited a comment on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Thihup edited a comment on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660651391
I haven't tested it in Java 1.7 yet.
However, as far as I remember, these options were introduced in Java 1.5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660650833
Have you checked this change on Java 1.7 projects too?
We can always alter this feature upon Java version if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-718245320
ok, i have created the Jira ticket [SUREFIRE-1858](https://issues.apache.org/jira/browse/SUREFIRE-1858).
So i will rename the commit to `[SUREFIRE-1858] Change default debug options to not use legacy options` and push it and close the ticket as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] rmannibucau commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660710293
@Thihup yep but 0.0.0.0:5005 is unsafe and not a good default anyway so guess it is better (if moving to current config as this issue is about) to fix that too properly. Worse case it is still configurable as before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660652711
We have make sure it is as you say, otherwise the Jenkins build would fail on old Java.
Here the GitHub workflow uses only Java 14 and 3 OS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660665835
Yes, please check it out additionally with jacoco.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Thihup edited a comment on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Thihup edited a comment on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-661083926
@rmannibucau @Tibor17 I've changed to localhost:5005, however, some tests have failed and I couldn't understand why.
Can you have a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Thihup commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Thihup commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-661083926
@rmannibucau I've changed to localhost:5005, however, some tests have failed and I couldn't understand why.
Can you have a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660673408
@Thihup thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Thihup commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Thihup commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-663234279
Is there something else I should do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-699683253
@Thihup
yes, we need to have updated documentation. Can you pls update it in `debugging.apt.vm`?
Pls check the other apt.vm files if there is important information for this task.
Produce only one commit altogether. And then rebase to the latest remote master.
Thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Thihup commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Thihup commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660673180
@rmannibucau Sure. I didn't change to localhost:5005 because it changes the current behavior in JDK <= 8. I don't know if someone connects remotely during debug. If it OK to change I can change right away.
@Tibor17 I've tested and it looks fine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660658510
@Thihup
Do you think this change would not be in a conflict with JaCoCo AGENT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Thihup commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Thihup commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660663266
@Tibor17 I don't think so. Unfortunately, I don't have an extensive collection of projects with JaCoCo to test, but where I tested it worked fine.
The JaCoCo injects itself as a Java Agent and should not be affected by this change. The main option that can cause some fear is the _Xnoagent_.
However, in both JVM, the _-Xnoagent_ does nothing, so I don't know where it could break:
Hotspot: https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/arguments.cpp#L2878
OpenJ9: https://github.com/eclipse/openj9/blob/master/runtime/vm/jvminit.c#L162
Do you have something in mind that we should try?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660650833
Have checked this change on Java 1.7 projects too?
We can always alter this feature upon Java version if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-661116224
The GH workflows are really crappy. After the MSC has taken it, this CI is unreliable.
The jobs are duplicated, the uploads are skipped on Win and MacOS and I do not see the logs if any build fails.
I was working on it whole weekend and could not fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-718255364
@Thihup Thx for contributing!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Thihup commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Thihup commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-718198694
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 merged pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Tibor17 merged pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-661116224
The GH workflows are really crappy. After the MSC has taken it, this CI is unreliable.
The jobs are duplicated, the uploads are skipped on Win and MacOS and I do not see the logs if any build fails.
I was working on it whole weekend and could not make it working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-718242043
What did you change 2 hours ago?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Thihup commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Thihup commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-718244378
I've just rebased to the latest remote
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660652711
We have to make sure it is as you say, otherwise the Jenkins build would fail on old Java.
Here the GitHub workflow uses only Java 14 and 3 OS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] rmannibucau commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660666626
Side note: for java 11, localhost:5005 is a saner default which works on java 8 (think 6 but didnt test), would be great to handle it too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Thihup commented on pull request #307: Change default debug options to not use legacy options
Posted by GitBox <gi...@apache.org>.
Thihup commented on pull request #307:
URL: https://github.com/apache/maven-surefire/pull/307#issuecomment-660651391
I haven't tested it in Java 1.7.
However, as far as I remember, these options were introduced in Java 1.5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org