You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ke...@apache.org on 2022/11/15 02:57:13 UTC

[skywalking-infra-e2e] 01/01: Disable batch mode by default, add it to GHA and enable by default

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a commit to branch gha
in repository https://gitbox.apache.org/repos/asf/skywalking-infra-e2e.git

commit fc62393dbe69a610a3a74a38de266fb0c81a000d
Author: kezhenxu94 <ke...@apache.org>
AuthorDate: Tue Nov 15 10:57:02 2022 +0800

    Disable batch mode by default, add it to GHA and enable by default
---
 action.yaml      | 5 +++++
 commands/root.go | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/action.yaml b/action.yaml
index 9d32c0b..9437c5a 100644
--- a/action.yaml
+++ b/action.yaml
@@ -24,6 +24,10 @@ inputs:
   log-dir:
     description: The container logs directory
     required: false
+  batch-mode:
+    description: Whether to run in batch mode, all interactive operations are disabled
+    required: false
+    default: 'true'
 runs:
   using: "composite"
   steps:
@@ -98,5 +102,6 @@ runs:
       run: |
         e2e run \
           -c "${{ inputs.e2e-file }}" \
+          --batch-mode "${{ inputs.batch-mode }}" \
           -w "${{ steps.e2e-dir-generator.outputs.work }}" \
           -l "${{ steps.e2e-dir-generator.outputs.log-case }}"
diff --git a/commands/root.go b/commands/root.go
index 4e3b463..020f131 100644
--- a/commands/root.go
+++ b/commands/root.go
@@ -93,8 +93,8 @@ func Execute() error {
 	Root.PersistentFlags().StringVarP(&util.WorkDir, "work-dir", "w", "~/.skywalking-infra-e2e", "the working directory for skywalking-infra-e2e")
 	Root.PersistentFlags().StringVarP(&util.LogDir, "log-dir", "l", "~/.skywalking-infra-e2e/logs", "the container logs directory for environment")
 	Root.PersistentFlags().StringVarP(&util.CfgFile, "config", "c", constant.E2EDefaultFile, "the config file")
-	Root.PersistentFlags().BoolVarP(&util.BatchMode, "batch-mode", "B", true,
-		"whether to output in batch mode, if false, the output will be printed in real time. This option is not valid in concurrency mode.")
+	Root.PersistentFlags().BoolVarP(&util.BatchMode, "batch-mode", "B", false,
+		`whether to run in batch mode, if true, all interactive operations are disabled, including real-time progress bar. This option is always enabled in concurrency mode and in our GitHub Actions.`)
 
 	return Root.Execute()
 }