You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/14 10:59:21 UTC
[GitHub] [spark] dilipbiswal opened a new pull request #28825: [SPARk-31950][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
dilipbiswal opened a new pull request #28825:
URL: https://github.com/apache/spark/pull/28825
### What changes were proposed in this pull request?
Better error message when SPARK_HOME or spark,testl.home is not set.
### Why are the changes needed?
Currently the error message is not easily consumable as it prints the real error after printing the current environment which is rather long.
`
time.name" -> "Java(TM) SE Runtime Environment", "sun.boot.library.path" -> "/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib", "java.vm.version" -> "25.221-b11", "gopherProxySet" -> "false", "java.vm.vendor" -> "Oracle Corporation", "java.vendor.url" -> "http://java.oracle.com/", "path.separator" -> ":", "java.vm.name" -> "Java HotSpot(TM) 64-Bit Server VM", "file.encoding.pkg" -> "sun.io", "user.country" -> "US", "sun.java.launcher" -> "SUN_STANDARD", "sun.os.patch.level" -> "unknown", "java.vm.specification.name" -> "Java Virtual Machine Specification", "user.dir" -> "/Users/dilipbiswal/mygit/apache/spark/sql/catalyst", "java.runtime.version" -> "1.8.0_221-b11", "java.awt.graphicsenv" -> "sun.awt.CGraphicsEnvironment", "java.endorsed.dirs" -> "/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/endorsed", "os.arch" -> "x86_64", "java.io.tmpdir" -> "/var/folders/jv/tmdyc8n933s1fqlxhxps3nz00000gn/T/", "line.separator" -> "
", "java.vm.specification.vendor" -> "Oracle Corporation", "os.name" -> "Mac OS X", "sun.jnu.encoding" -> "UTF-8", "java.library.path" -> "/Users/dilipbiswal/Library/Java/Extensions:/Library/Java/Extensions:/Network/Library/Java/Extensions:/System/Library/Java/Extensions:/usr/lib/java:.", "java.specification.name" -> "Java Platform API Specification", "java.class.version" -> "52.0", "sun.management.compiler" -> "HotSpot 64-Bit Tiered Compilers", "os.version" -> "10.14.5", "http.nonProxyHosts" -> "local|*.local|169.254/16|*.169.254/16", "user.home" -> "/Users/dilipbiswal", "user.timezone" -> "America/Los_Angeles", "java.awt.printerjob" -> "sun.lwawt.macosx.CPrinterJob", "file.encoding" -> "UTF-8", "java.specification.version" -> "1.8", "user.name" -> "dilipbiswal", "java.class.path" -> "/Users/dilipbiswal/Library/Application Support/IdeaIC2019.2/Scala/lib/runners.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/charsets.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/deploy.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/cldrdata.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/dnsns.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/jaccess.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/jfxrt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/localedata.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/nashorn.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/sunec.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/sunjce_provider.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/sunpkcs11.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/zipfs.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/javaws.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/jce.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/jfr.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/jfxswt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/jsse.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/management-agent.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/plugin.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/resources.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/rt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/lib/ant-javafx.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/lib/dt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/lib/javafx-mx.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/lib/jconsole.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/lib/packager.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/lib/sa-jdi.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/lib/tools.jar:/Users/dilipbiswal/mygit/apache/spark/sql/catalyst/target/scala-2.12/test-classes:/Users/dilipbiswal/mygit/apache/spark/sql/catalyst/target/scala-2.12/classes:/Users/dilipbiswal/.m2/repository/org/scala-lang/scala-reflect/2.12.10/scala-reflect-2.12.10.jar:/Users/dilipbiswal/.m2/repository/org/scala-lang/scala-library/2.12.10/scala-library-2.12.10.jar:/Users/dilipbiswal/.m2/repository/org/scala-lang/modules/scala-parser-combinators_2.12/1.1.2/scala-parser-combinators_2.12-1.1.2.jar:/Users/dilipbiswal/mygit/apache/spark/core/target/scala-2.12/classes:/Users/dilipbiswal/.m2/repository/com/thoughtworks/paranamer/paranamer/2.8/paranamer-2.8.jar:/Users/dilipbiswal/.m2/repository/org/apache/avro/avro/1.8.2/avro-1.8.2.jar:/Users/dilipbiswal/.m2/repository/org/codehaus/jackson/jackson-core-asl/1.9.13/jackson-core-asl-1.9.13.jar:/Users/dilipbiswal/.m2/repository/org/codehaus/jackson/jackson-mapper-asl/1.9.13/jackson-mapper-asl-1.9.13.jar:/Users/dilipbiswal/.m2/repository/org/apache/commons/commons-compress/1.8.1/commons-compress-1.8.1.jar:/Users/dilipbiswal/.m2/repository/org/tukaani/xz/1.5/xz-1.5.jar:/Users/dilipbiswal/.m2/repository/org/apache/avro/avro-mapred/1.8.2/avro-mapred-1.8.2-hadoop2.jar:/Users/dilipbiswal/.m2/repository/org/apache/avro/avro-ipc/1.8.2/avro-ipc-1.8.2.jar:/Users/dilipbiswal/.m2/repository/com/twitter/chill_2.12/0.9.5/chill_2.12-0.9.5.jar:/Users/dilipbiswal/.m2/repository/com/esotericsoftware/kryo-shaded/4.0.2/kryo-shaded-4.0.2.jar:/Users/dilipbiswal/.m2/repository/com/esotericsoftware/minlog/1.3.0/minlog-1.3.0.jar:/Users/dilipbiswal/.m2/repository/com/twitter/chill-java/0.9.5/chill-java-0.9.5.jar:/Users/dilipbiswal/.m2/repository/org/apache/xbean/xbean-asm7-shaded/4.15/xbean-asm7-shaded-4.15.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-client/3.2.0/hadoop-client-3.2.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-common/3.2.0/hadoop-common-3.2.0.jar:/Users/dilipbiswal/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar:/Users/dilipbiswal/.m2/repository/org/apache/httpcomponents/httpclient/4.5.6/httpclient-4.5.6.jar:/Users/dilipbiswal/.m2/repository/org/apache/httpcomponents/httpcore/4.4.12/httpcore-4.4.12.jar:/Users/dilipbiswal/.m2/repository/commons-io/commons-io/2.5/commons-io-2.5.jar:/Users/dilipbiswal/.m2/repository/commons-collections/commons-collections/3.2.2/commons-collections-3.2.2.jar:/Users/dilipbiswal/.m2/repository/javax/servlet/jsp/jsp-api/2.1/jsp-api-2.1.jar:/Users/dilipbiswal/.m2/repository/commons-beanutils/commons-beanutils/1.9.4/commons-beanutils-1.9.4.jar:/Users/dilipbiswal/.m2/repository/org/apache/commons/commons-configuration2/2.1.1/commons-configuration2-2.1.1.jar:/Users/dilipbiswal/.m2/repository/com/google/re2j/re2j/1.1/re2j-1.1.jar:/Users/dilipbiswal/.m2/repository/com/google/protobuf/protobuf-java/2.5.0/protobuf-java-2.5.0.jar:/Users/dilipbiswal/.m2/repository/com/google/code/gson/gson/2.2.4/gson-2.2.4.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-auth/3.2.0/hadoop-auth-3.2.0.jar:/Users/dilipbiswal/.m2/repository/com/nimbusds/nimbus-jose-jwt/4.41.1/nimbus-jose-jwt-4.41.1.jar:/Users/dilipbiswal/.m2/repository/com/github/stephenc/jcip/jcip-annotations/1.0-1/jcip-annotations-1.0-1.jar:/Users/dilipbiswal/.m2/repository/net/minidev/json-smart/2.3/json-smart-2.3.jar:/Users/dilipbiswal/.m2/repository/net/minidev/accessors-smart/1.2/accessors-smart-1.2.jar:/Users/dilipbiswal/.m2/repository/org/apache/curator/curator-client/2.13.0/curator-client-2.13.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/htrace/htrace-core4/4.1.0-incubating/htrace-core4-4.1.0-incubating.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-simplekdc/1.0.1/kerb-simplekdc-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-client/1.0.1/kerb-client-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerby-config/1.0.1/kerby-config-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-core/1.0.1/kerb-core-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerby-pkix/1.0.1/kerby-pkix-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerby-asn1/1.0.1/kerby-asn1-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerby-util/1.0.1/kerby-util-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-common/1.0.1/kerb-common-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-crypto/1.0.1/kerb-crypto-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-util/1.0.1/kerb-util-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/token-provider/1.0.1/token-provider-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-admin/1.0.1/kerb-admin-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-server/1.0.1/kerb-server-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-identity/1.0.1/kerb-identity-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerby-xdr/1.0.1/kerby-xdr-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/codehaus/woodstox/stax2-api/3.1.4/stax2-api-3.1.4.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/woodstox/woodstox-core/5.0.3/woodstox-core-5.0.3.jar:/Users/dilipbiswal/.m2/repository/dnsjava/dnsjava/2.1.7/dnsjava-2.1.7.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-hdfs-client/3.2.0/hadoop-hdfs-client-3.2.0.jar:/Users/dilipbiswal/.m2/repository/com/squareup/okhttp/okhttp/2.7.5/okhttp-2.7.5.jar:/Users/dilipbiswal/.m2/repository/com/squareup/okio/okio/1.6.0/okio-1.6.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-yarn-api/3.2.0/hadoop-yarn-api-3.2.0.jar:/Users/dilipbiswal/.m2/repository/javax/xml/bind/jaxb-api/2.2.11/jaxb-api-2.2.11.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-yarn-client/3.2.0/hadoop-yarn-client-3.2.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-core/3.2.0/hadoop-mapreduce-client-core-3.2.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-yarn-common/3.2.0/hadoop-yarn-common-3.2.0.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/module/jackson-module-jaxb-annotations/2.10.0/jackson-module-jaxb-annotations-2.10.0.jar:/Users/dilipbiswal/.m2/repository/jakarta/xml/bind/jakarta.xml.bind-api/2.3.2/jakarta.xml.bind-api-2.3.2.jar:/Users/dilipbiswal/.m2/repository/jakarta/activation/jakarta.activation-api/1.2.1/jakarta.activation-api-1.2.1.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/jaxrs/jackson-jaxrs-json-provider/2.9.5/jackson-jaxrs-json-provider-2.9.5.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/jaxrs/jackson-jaxrs-base/2.9.5/jackson-jaxrs-base-2.9.5.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-jobclient/3.2.0/hadoop-mapreduce-client-jobclient-3.2.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-common/3.2.0/hadoop-mapreduce-client-common-3.2.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-annotations/3.2.0/hadoop-annotations-3.2.0.jar:/Users/dilipbiswal/mygit/apache/spark/launcher/target/scala-2.12/classes:/Users/dilipbiswal/mygit/apache/spark/common/kvstore/target/scala-2.12/classes:/Users/dilipbiswal/.m2/repository/org/fusesource/leveldbjni/leveldbjni-all/1.8/leveldbjni-all-1.8.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.10.0/jackson-annotations-2.10.0.jar:/Users/dilipbiswal/mygit/apache/spark/common/network-common/target/scala-2.12/classes:/Users/dilipbiswal/.m2/repository/com/google/guava/guava/14.0.1/guava-14.0.1.jar:/Users/dilipbiswal/mygit/apache/spark/common/network-shuffle/target/scala-2.12/classes:/Users/dilipbiswal/.m2/repository/javax/activation/activation/1.1.1/activation-1.1.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/curator/curator-recipes/2.13.0/curator-recipes-2.13.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/curator/curator-framework/2.13.0/curator-framework-2.13.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/zookeeper/zookeeper/3.4.14/zookeeper-3.4.14.jar:/Users/dilipbiswal/.m2/repository/org/apache/yetus/audience-annotations/0.5.0/audience-annotations-0.5.0.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-plus/9.4.28.v20200408/jetty-plus-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-webapp/9.4.28.v20200408/jetty-webapp-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-xml/9.4.28.v20200408/jetty-xml-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-jndi/9.4.28.v20200408/jetty-jndi-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-security/9.4.28.v20200408/jetty-security-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-util/9.4.28.v20200408/jetty-util-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-server/9.4.28.v20200408/jetty-server-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-io/9.4.28.v20200408/jetty-io-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-http/9.4.28.v20200408/jetty-http-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-continuation/9.4.28.v20200408/jetty-continuation-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-servlet/9.4.28.v20200408/jetty-servlet-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-proxy/9.4.28.v20200408/jetty-proxy-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-client/9.4.28.v20200408/jetty-client-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-servlets/9.4.28.v20200408/jetty-servlets-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/javax/servlet/javax.servlet-api/3.1.0/javax.servlet-api-3.1.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/commons/commons-lang3/3.9/commons-lang3-3.9.jar:/Users/dilipbiswal/.m2/repository/org/apache/commons/commons-math3/3.4.1/commons-math3-3.4.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/commons/commons-text/1.6/commons-text-1.6.jar:/Users/dilipbiswal/.m2/repository/com/google/code/findbugs/jsr305/3.0.0/jsr305-3.0.0.jar:/Users/dilipbiswal/.m2/repository/org/slf4j/slf4j-api/1.7.30/slf4j-api-1.7.30.jar:/Users/dilipbiswal/.m2/repository/org/slf4j/jul-to-slf4j/1.7.30/jul-to-slf4j-1.7.30.jar:/Users/dilipbiswal/.m2/repository/org/slf4j/jcl-over-slf4j/1.7.30/jcl-over-slf4j-1.7.30.jar:/Users/dilipbiswal/.m2/repository/log4j/log4j/1.2.17/log4j-1.2.17.jar:/Users/dilipbiswal/.m2/repository/org/slf4j/slf4j-log4j12/1.7.30/slf4j-log4j12-1.7.30.jar:/Users/dilipbiswal/.m2/repository/com/ning/compress-lzf/1.0.3/compress-lzf-1.0.3.jar:/Users/dilipbiswal/.m2/repository/org/xerial/snappy/snappy-java/1.1.7.5/snappy-java-1.1.7.5.jar:/Users/dilipbiswal/.m2/repository/org/lz4/lz4-java/1.7.1/lz4-java-1.7.1.jar:/Users/dilipbiswal/.m2/repository/com/github/luben/zstd-jni/1.4.5-2/zstd-jni-1.4.5-2.jar:/Users/dilipbiswal/.m2/repository/org/roaringbitmap/RoaringBitmap/0.7.45/RoaringBitmap-0.7.45.jar:/Users/dilipbiswal/.m2/repository/org/roaringbitmap/shims/0.7.45/shims-0.7.45.jar:/Users/dilipbiswal/.m2/repository/commons-net/commons-net/3.1/commons-net-3.1.jar:/Users/dilipbiswal/.m2/repository/org/scala-lang/modules/scala-xml_2.12/1.2.0/scala-xml_2.12-1.2.0.jar:/Users/dilipbiswal/.m2/repository/org/json4s/json4s-jackson_2.12/3.6.6/json4s-jackson_2.12-3.6.6.jar:/Users/dilipbiswal/.m2/repository/org/json4s/json4s-core_2.12/3.6.6/json4s-core_2.12-3.6.6.jar:/Users/dilipbiswal/.m2/repository/org/json4s/json4s-ast_2.12/3.6.6/json4s-ast_2.12-3.6.6.jar:/Users/dilipbiswal/.m2/repository/org/json4s/json4s-scalap_2.12/3.6.6/json4s-scalap_2.12-3.6.6.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/jersey/core/jersey-client/2.30/jersey-client-2.30.jar:/Users/dilipbiswal/.m2/repository/jakarta/ws/rs/jakarta.ws.rs-api/2.1.6/jakarta.ws.rs-api-2.1.6.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/hk2/external/jakarta.inject/2.6.1/jakarta.inject-2.6.1.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/jersey/core/jersey-common/2.30/jersey-common-2.30.jar:/Users/dilipbiswal/.m2/repository/jakarta/annotation/jakarta.annotation-api/1.3.5/jakarta.annotation-api-1.3.5.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/hk2/osgi-resource-locator/1.0.3/osgi-resource-locator-1.0.3.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/jersey/core/jersey-server/2.30/jersey-server-2.30.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/jersey/media/jersey-media-jaxb/2.30/jersey-media-jaxb-2.30.jar:/Users/dilipbiswal/.m2/repository/jakarta/validation/jakarta.validation-api/2.0.2/jakarta.validation-api-2.0.2.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/jersey/containers/jersey-container-servlet/2.30/jersey-container-servlet-2.30.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/jersey/containers/jersey-container-servlet-core/2.30/jersey-container-servlet-core-2.30.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/jersey/inject/jersey-hk2/2.30/jersey-hk2-2.30.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/hk2/hk2-locator/2.6.1/hk2-locator-2.6.1.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/hk2/external/aopalliance-repackaged/2.6.1/aopalliance-repackaged-2.6.1.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/hk2/hk2-api/2.6.1/hk2-api-2.6.1.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/hk2/hk2-utils/2.6.1/hk2-utils-2.6.1.jar:/Users/dilipbiswal/.m2/repository/org/javassist/javassist/3.25.0-GA/javassist-3.25.0-GA.jar:/Users/dilipbiswal/.m2/repository/io/netty/netty-all/4.1.47.Final/netty-all-4.1.47.Final.jar:/Users/dilipbiswal/.m2/repository/com/clearspring/analytics/stream/2.9.6/stream-2.9.6.jar:/Users/dilipbiswal/.m2/repository/io/dropwizard/metrics/metrics-core/4.1.1/metrics-core-4.1.1.jar:/Users/dilipbiswal/.m2/repository/io/dropwizard/metrics/metrics-jvm/4.1.1/metrics-jvm-4.1.1.jar:/Users/dilipbiswal/.m2/repository/io/dropwizard/metrics/metrics-json/4.1.1/metrics-json-4.1.1.jar:/Users/dilipbiswal/.m2/repository/io/dropwizard/metrics/metrics-graphite/4.1.1/metrics-graphite-4.1.1.jar:/Users/dilipbiswal/.m2/repository/io/dropwizard/metrics/metrics-jmx/4.1.1/metrics-jmx-4.1.1.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.10.0/jackson-databind-2.10.0.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/module/jackson-module-scala_2.12/2.10.0/jackson-module-scala_2.12-2.10.0.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/module/jackson-module-paranamer/2.10.0/jackson-module-paranamer-2.10.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/ivy/ivy/2.4.0/ivy-2.4.0.jar:/Users/dilipbiswal/.m2/repository/oro/oro/2.0.8/oro-2.0.8.jar:/Users/dilipbiswal/.m2/repository/net/razorvine/pyrolite/4.30/pyrolite-4.30.jar:/Users/dilipbiswal/.m2/repository/net/sf/py4j/py4j/0.10.9/py4j-0.10.9.jar:/Users/dilipbiswal/.m2/repository/org/apache/commons/commons-crypto/1.0.0/commons-crypto-1.0.0.jar:/Users/dilipbiswal/mygit/apache/spark/core/target/scala-2.12/test-classes:/Users/dilipbiswal/mygit/apache/spark/common/tags/target/scala-2.12/classes:/Users/dilipbiswal/mygit/apache/spark/common/tags/target/scala-2.12/test-classes:/Users/dilipbiswal/.m2/repository/org/mockito/mockito-core/3.1.0/mockito-core-3.1.0.jar:/Users/dilipbiswal/.m2/repository/net/bytebuddy/byte-buddy/1.9.10/byte-buddy-1.9.10.jar:/Users/dilipbiswal/.m2/repository/net/bytebuddy/byte-buddy-agent/1.9.10/byte-buddy-agent-1.9.10.jar:/Users/dilipbiswal/.m2/repository/org/objenesis/objenesis/2.6/objenesis-2.6.jar:/Users/dilipbiswal/mygit/apache/spark/common/unsafe/target/scala-2.12/classes:/Users/dilipbiswal/mygit/apache/spark/common/sketch/target/scala-2.12/classes:/Users/dilipbiswal/.m2/repository/org/scalacheck/scalacheck_2.12/1.14.2/scalacheck_2.12-1.14.2.jar:/Users/dilipbiswal/.m2/repository/org/scala-sbt/test-interface/1.0/test-interface-1.0.jar:/Users/dilipbiswal/.m2/repository/org/codehaus/janino/janino/3.1.2/janino-3.1.2.jar:/Users/dilipbiswal/.m2/repository/org/codehaus/janino/commons-compiler/3.1.2/commons-compiler-3.1.2.jar:/Users/dilipbiswal/.m2/repository/org/antlr/antlr4-runtime/4.7.1/antlr4-runtime-4.7.1.jar:/Users/dilipbiswal/.m2/repository/commons-codec/commons-codec/1.10/commons-codec-1.10.jar:/Users/dilipbiswal/.m2/repository/com/univocity/univocity-parsers/2.8.3/univocity-parsers-2.8.3.jar:/Users/dilipbiswal/.m2/repository/org/apache/arrow/arrow-vector/0.15.1/arrow-vector-0.15.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/arrow/arrow-format/0.15.1/arrow-format-0.15.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/arrow/arrow-memory/0.15.1/arrow-memory-0.15.1.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/core/jackson-core/2.10.0/jackson-core-2.10.0.jar:/Users/dilipbiswal/.m2/repository/com/google/flatbuffers/flatbuffers-java/1.9.0/flatbuffers-java-1.9.0.jar:/Users/dilipbiswal/.m2/repository/org/spark-project/spark/unused/1.0.0/unused-1.0.0.jar:/Users/dilipbiswal/.m2/repository/org/scalatest/scalatest_2.12/3.0.8/scalatest_2.12-3.0.8.jar:/Users/dilipbiswal/.m2/repository/org/scalactic/scalactic_2.12/3.0.8/scalactic_2.12-3.0.8.jar:/Users/dilipbiswal/.m2/repository/junit/junit/4.12/junit-4.12.jar:/Users/dilipbiswal/.m2/repository/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar:/Users/dilipbiswal/.m2/repository/com/novocode/junit-interface/0.11/junit-interface-0.11.jar:/Applications/IntelliJ IDEA CE.app/Contents/lib/idea_rt.jar", "java.vm.specification.version" -> "1.8", "sun.arch.data.model" -> "64", "java.home" -> "/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre", "sun.java.command" -> "org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestRunner -s org.apache.spark.sql.catalyst.parser.TableIdentifierParserSuite -C org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestReporter -showProgressMessages true", "java.specification.vendor" -> "Oracle Corporation", "user.language" -> "en", "awt.toolkit" -> "sun.lwawt.macosx.LWCToolkit", "java.vm.info" -> "mixed mode", "java.version" -> "1.8.0_221", "java.ext.dirs" -> "/Users/dilipbiswal/Library/Java/Extensions:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext:/Library/Java/Extensions:/Network/Library/Java/Extensions:/System/Library/Java/Extensions:/usr/lib/java", "sun.boot.class.path" -> "/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/resources.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/rt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/sunrsasign.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/jsse.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/jce.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/charsets.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/jfr.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/classes", "java.vendor" -> "Oracle Corporation", "file.separator" -> "/", "java.vendor.url.bug" -> "http://bugreport.sun.com/bugreport/", "sun.cpu.endian" -> "little", "sun.io.unicode.encoding" -> "UnicodeBig", "socksNonProxyHosts" -> "local|*.local|169.254/16|*.169.254/16", "ftp.nonProxyHosts" -> "local|*.local|169.254/16|*.169.254/16", "sun.cpu.isalist" -> "") did not contain key "spark.test.home", and Map("SHELL" -> "/bin/bash", "LOGNAME" -> "dilipbiswal", "PATH" -> "/usr/bin:/usr/local/Cellar/pyenv/1.2.13_1/libexec:/Users/dilipbiswal/gems/bin:/Users/dilipbiswal/.rbenv/shims:/Users/dilipbiswal/.pyenv/shims:/Users/dilipbiswal/.rbenv/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/dilipbiswal/bin:/Users/dilipbiswal/Library/Python/2.7/bin", "VERSIONER_PYTHON_VERSION" -> "2.7", "XPC_SERVICE_NAME" -> "com.jetbrains.intellij.ce.2624", "RBENV_SHELL" -> "bash", "HOME" -> "/Users/dilipbiswal", "JAVA_MAIN_CLASS_87487" -> "org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestRunner", "Apple_PubSub_Socket_Render" -> "/private/tmp/com.apple.launchd.wTYpBrujQD/Render", "USER" -> "dilipbiswal", "__CF_USER_TEXT_ENCODING" -> "0x1F5:0x0:0x0", "XPC_FLAGS" -> "0x0", "TMPDIR" -> "/var/folders/jv/tmdyc8n933s1fqlxhxps3nz00000gn/T/", "GEM_HOME" -> "/Users/dilipbiswal/gems", "PYENV_DIR" -> "/Applications/IntelliJ IDEA CE.app/Contents/bin", "PYENV_HOOK_PATH" -> "/Users/dilipbiswal/.pyenv/pyenv.d:/usr/local/Cellar/pyenv/1.2.13_1/pyenv.d:/usr/local/etc/pyenv.d:/etc/pyenv.d:/usr/lib/pyenv/hooks", "PWD" -> "/Users/dilipbiswal/mygit/apache/spark/sql/catalyst", "VERSIONER_PYTHON_PREFER_32_BIT" -> "no", "LC_CTYPE" -> "en_US.UTF-8", "PYENV_VERSION" -> "system", "PYENV_SHELL" -> "bash", "PYENV_ROOT" -> "/Users/dilipbiswal/.pyenv", "SSH_AUTH_SOCK" -> "/private/tmp/com.apple.launchd.sUq1TT83Ep/Listeners") did not contain key "SPARK_HOME" spark.test.home or SPARK_HOME is not set.
org.scalatest.exceptions.TestFailedException: Map("java.runtime.name" -> "Java(TM) SE Runtime Environment", "sun.boot.library.path" -> "/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib", "java.vm.version" -> "25.221-b11", "gopherProxySet" -> "false", "java.vm.vendor" -> "Oracle Corporation", "java.vendor.url" -> "http://java.oracle.com/", "path.separator" -> ":", "java.vm.name" -> "Java HotSpot(TM) 64-Bit Server VM", "file.encoding.pkg" -> "sun.io", "user.country" -> "US", "sun.java.launcher" -> "SUN_STANDARD", "sun.os.patch.level" -> "unknown", "java.vm.specification.name" -> "Java Virtual Machine Specification", "user.dir" -> "/Users/dilipbiswal/mygit/apache/spark/sql/catalyst", "java.runtime.version" -> "1.8.0_221-b11", "java.awt.graphicsenv" -> "sun.awt.CGraphicsEnvironment", "java.endorsed.dirs" -> "/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/endorsed", "os.arch" -> "x86_64", "java.io.tmpdir" -> "/var/folders/jv/tmdyc8n933s1fqlxhxps3nz00000gn/T/", "line.separator" -> "
", "java.vm.specification.vendor" -> "Oracle Corporation", "os.name" -> "Mac OS X", "sun.jnu.encoding" -> "UTF-8", "java.library.path" -> "/Users/dilipbiswal/Library/Java/Extensions:/Library/Java/Extensions:/Network/Library/Java/Extensions:/System/Library/Java/Extensions:/usr/lib/java:.", "java.specification.name" -> "Java Platform API Specification", "java.class.version" -> "52.0", "sun.management.compiler" -> "HotSpot 64-Bit Tiered Compilers", "os.version" -> "10.14.5", "http.nonProxyHosts" -> "local|*.local|169.254/16|*.169.254/16", "user.home" -> "/Users/dilipbiswal", "user.timezone" -> "America/Los_Angeles", "java.awt.printerjob" -> "sun.lwawt.macosx.CPrinterJob", "file.encoding" -> "UTF-8", "java.specification.version" -> "1.8", "user.name" -> "dilipbiswal", "java.class.path" -> "/Users/dilipbiswal/Library/Application Support/IdeaIC2019.2/Scala/lib/runners.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/charsets.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/deploy.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/cldrdata.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/dnsns.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/jaccess.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/jfxrt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/localedata.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/nashorn.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/sunec.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/sunjce_provider.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/sunpkcs11.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext/zipfs.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/javaws.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/jce.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/jfr.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/jfxswt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/jsse.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/management-agent.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/plugin.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/resources.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/rt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/lib/ant-javafx.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/lib/dt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/lib/javafx-mx.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/lib/jconsole.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/lib/packager.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/lib/sa-jdi.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/lib/tools.jar:/Users/dilipbiswal/mygit/apache/spark/sql/catalyst/target/scala-2.12/test-classes:/Users/dilipbiswal/mygit/apache/spark/sql/catalyst/target/scala-2.12/classes:/Users/dilipbiswal/.m2/repository/org/scala-lang/scala-reflect/2.12.10/scala-reflect-2.12.10.jar:/Users/dilipbiswal/.m2/repository/org/scala-lang/scala-library/2.12.10/scala-library-2.12.10.jar:/Users/dilipbiswal/.m2/repository/org/scala-lang/modules/scala-parser-combinators_2.12/1.1.2/scala-parser-combinators_2.12-1.1.2.jar:/Users/dilipbiswal/mygit/apache/spark/core/target/scala-2.12/classes:/Users/dilipbiswal/.m2/repository/com/thoughtworks/paranamer/paranamer/2.8/paranamer-2.8.jar:/Users/dilipbiswal/.m2/repository/org/apache/avro/avro/1.8.2/avro-1.8.2.jar:/Users/dilipbiswal/.m2/repository/org/codehaus/jackson/jackson-core-asl/1.9.13/jackson-core-asl-1.9.13.jar:/Users/dilipbiswal/.m2/repository/org/codehaus/jackson/jackson-mapper-asl/1.9.13/jackson-mapper-asl-1.9.13.jar:/Users/dilipbiswal/.m2/repository/org/apache/commons/commons-compress/1.8.1/commons-compress-1.8.1.jar:/Users/dilipbiswal/.m2/repository/org/tukaani/xz/1.5/xz-1.5.jar:/Users/dilipbiswal/.m2/repository/org/apache/avro/avro-mapred/1.8.2/avro-mapred-1.8.2-hadoop2.jar:/Users/dilipbiswal/.m2/repository/org/apache/avro/avro-ipc/1.8.2/avro-ipc-1.8.2.jar:/Users/dilipbiswal/.m2/repository/com/twitter/chill_2.12/0.9.5/chill_2.12-0.9.5.jar:/Users/dilipbiswal/.m2/repository/com/esotericsoftware/kryo-shaded/4.0.2/kryo-shaded-4.0.2.jar:/Users/dilipbiswal/.m2/repository/com/esotericsoftware/minlog/1.3.0/minlog-1.3.0.jar:/Users/dilipbiswal/.m2/repository/com/twitter/chill-java/0.9.5/chill-java-0.9.5.jar:/Users/dilipbiswal/.m2/repository/org/apache/xbean/xbean-asm7-shaded/4.15/xbean-asm7-shaded-4.15.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-client/3.2.0/hadoop-client-3.2.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-common/3.2.0/hadoop-common-3.2.0.jar:/Users/dilipbiswal/.m2/repository/commons-cli/commons-cli/1.2/commons-cli-1.2.jar:/Users/dilipbiswal/.m2/repository/org/apache/httpcomponents/httpclient/4.5.6/httpclient-4.5.6.jar:/Users/dilipbiswal/.m2/repository/org/apache/httpcomponents/httpcore/4.4.12/httpcore-4.4.12.jar:/Users/dilipbiswal/.m2/repository/commons-io/commons-io/2.5/commons-io-2.5.jar:/Users/dilipbiswal/.m2/repository/commons-collections/commons-collections/3.2.2/commons-collections-3.2.2.jar:/Users/dilipbiswal/.m2/repository/javax/servlet/jsp/jsp-api/2.1/jsp-api-2.1.jar:/Users/dilipbiswal/.m2/repository/commons-beanutils/commons-beanutils/1.9.4/commons-beanutils-1.9.4.jar:/Users/dilipbiswal/.m2/repository/org/apache/commons/commons-configuration2/2.1.1/commons-configuration2-2.1.1.jar:/Users/dilipbiswal/.m2/repository/com/google/re2j/re2j/1.1/re2j-1.1.jar:/Users/dilipbiswal/.m2/repository/com/google/protobuf/protobuf-java/2.5.0/protobuf-java-2.5.0.jar:/Users/dilipbiswal/.m2/repository/com/google/code/gson/gson/2.2.4/gson-2.2.4.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-auth/3.2.0/hadoop-auth-3.2.0.jar:/Users/dilipbiswal/.m2/repository/com/nimbusds/nimbus-jose-jwt/4.41.1/nimbus-jose-jwt-4.41.1.jar:/Users/dilipbiswal/.m2/repository/com/github/stephenc/jcip/jcip-annotations/1.0-1/jcip-annotations-1.0-1.jar:/Users/dilipbiswal/.m2/repository/net/minidev/json-smart/2.3/json-smart-2.3.jar:/Users/dilipbiswal/.m2/repository/net/minidev/accessors-smart/1.2/accessors-smart-1.2.jar:/Users/dilipbiswal/.m2/repository/org/apache/curator/curator-client/2.13.0/curator-client-2.13.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/htrace/htrace-core4/4.1.0-incubating/htrace-core4-4.1.0-incubating.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-simplekdc/1.0.1/kerb-simplekdc-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-client/1.0.1/kerb-client-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerby-config/1.0.1/kerby-config-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-core/1.0.1/kerb-core-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerby-pkix/1.0.1/kerby-pkix-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerby-asn1/1.0.1/kerby-asn1-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerby-util/1.0.1/kerby-util-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-common/1.0.1/kerb-common-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-crypto/1.0.1/kerb-crypto-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-util/1.0.1/kerb-util-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/token-provider/1.0.1/token-provider-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-admin/1.0.1/kerb-admin-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-server/1.0.1/kerb-server-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerb-identity/1.0.1/kerb-identity-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/kerby/kerby-xdr/1.0.1/kerby-xdr-1.0.1.jar:/Users/dilipbiswal/.m2/repository/org/codehaus/woodstox/stax2-api/3.1.4/stax2-api-3.1.4.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/woodstox/woodstox-core/5.0.3/woodstox-core-5.0.3.jar:/Users/dilipbiswal/.m2/repository/dnsjava/dnsjava/2.1.7/dnsjava-2.1.7.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-hdfs-client/3.2.0/hadoop-hdfs-client-3.2.0.jar:/Users/dilipbiswal/.m2/repository/com/squareup/okhttp/okhttp/2.7.5/okhttp-2.7.5.jar:/Users/dilipbiswal/.m2/repository/com/squareup/okio/okio/1.6.0/okio-1.6.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-yarn-api/3.2.0/hadoop-yarn-api-3.2.0.jar:/Users/dilipbiswal/.m2/repository/javax/xml/bind/jaxb-api/2.2.11/jaxb-api-2.2.11.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-yarn-client/3.2.0/hadoop-yarn-client-3.2.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-core/3.2.0/hadoop-mapreduce-client-core-3.2.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-yarn-common/3.2.0/hadoop-yarn-common-3.2.0.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/module/jackson-module-jaxb-annotations/2.10.0/jackson-module-jaxb-annotations-2.10.0.jar:/Users/dilipbiswal/.m2/repository/jakarta/xml/bind/jakarta.xml.bind-api/2.3.2/jakarta.xml.bind-api-2.3.2.jar:/Users/dilipbiswal/.m2/repository/jakarta/activation/jakarta.activation-api/1.2.1/jakarta.activation-api-1.2.1.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/jaxrs/jackson-jaxrs-json-provider/2.9.5/jackson-jaxrs-json-provider-2.9.5.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/jaxrs/jackson-jaxrs-base/2.9.5/jackson-jaxrs-base-2.9.5.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-jobclient/3.2.0/hadoop-mapreduce-client-jobclient-3.2.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-mapreduce-client-common/3.2.0/hadoop-mapreduce-client-common-3.2.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/hadoop/hadoop-annotations/3.2.0/hadoop-annotations-3.2.0.jar:/Users/dilipbiswal/mygit/apache/spark/launcher/target/scala-2.12/classes:/Users/dilipbiswal/mygit/apache/spark/common/kvstore/target/scala-2.12/classes:/Users/dilipbiswal/.m2/repository/org/fusesource/leveldbjni/leveldbjni-all/1.8/leveldbjni-all-1.8.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/core/jackson-annotations/2.10.0/jackson-annotations-2.10.0.jar:/Users/dilipbiswal/mygit/apache/spark/common/network-common/target/scala-2.12/classes:/Users/dilipbiswal/.m2/repository/com/google/guava/guava/14.0.1/guava-14.0.1.jar:/Users/dilipbiswal/mygit/apache/spark/common/network-shuffle/target/scala-2.12/classes:/Users/dilipbiswal/.m2/repository/javax/activation/activation/1.1.1/activation-1.1.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/curator/curator-recipes/2.13.0/curator-recipes-2.13.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/curator/curator-framework/2.13.0/curator-framework-2.13.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/zookeeper/zookeeper/3.4.14/zookeeper-3.4.14.jar:/Users/dilipbiswal/.m2/repository/org/apache/yetus/audience-annotations/0.5.0/audience-annotations-0.5.0.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-plus/9.4.28.v20200408/jetty-plus-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-webapp/9.4.28.v20200408/jetty-webapp-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-xml/9.4.28.v20200408/jetty-xml-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-jndi/9.4.28.v20200408/jetty-jndi-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-security/9.4.28.v20200408/jetty-security-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-util/9.4.28.v20200408/jetty-util-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-server/9.4.28.v20200408/jetty-server-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-io/9.4.28.v20200408/jetty-io-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-http/9.4.28.v20200408/jetty-http-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-continuation/9.4.28.v20200408/jetty-continuation-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-servlet/9.4.28.v20200408/jetty-servlet-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-proxy/9.4.28.v20200408/jetty-proxy-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-client/9.4.28.v20200408/jetty-client-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/org/eclipse/jetty/jetty-servlets/9.4.28.v20200408/jetty-servlets-9.4.28.v20200408.jar:/Users/dilipbiswal/.m2/repository/javax/servlet/javax.servlet-api/3.1.0/javax.servlet-api-3.1.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/commons/commons-lang3/3.9/commons-lang3-3.9.jar:/Users/dilipbiswal/.m2/repository/org/apache/commons/commons-math3/3.4.1/commons-math3-3.4.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/commons/commons-text/1.6/commons-text-1.6.jar:/Users/dilipbiswal/.m2/repository/com/google/code/findbugs/jsr305/3.0.0/jsr305-3.0.0.jar:/Users/dilipbiswal/.m2/repository/org/slf4j/slf4j-api/1.7.30/slf4j-api-1.7.30.jar:/Users/dilipbiswal/.m2/repository/org/slf4j/jul-to-slf4j/1.7.30/jul-to-slf4j-1.7.30.jar:/Users/dilipbiswal/.m2/repository/org/slf4j/jcl-over-slf4j/1.7.30/jcl-over-slf4j-1.7.30.jar:/Users/dilipbiswal/.m2/repository/log4j/log4j/1.2.17/log4j-1.2.17.jar:/Users/dilipbiswal/.m2/repository/org/slf4j/slf4j-log4j12/1.7.30/slf4j-log4j12-1.7.30.jar:/Users/dilipbiswal/.m2/repository/com/ning/compress-lzf/1.0.3/compress-lzf-1.0.3.jar:/Users/dilipbiswal/.m2/repository/org/xerial/snappy/snappy-java/1.1.7.5/snappy-java-1.1.7.5.jar:/Users/dilipbiswal/.m2/repository/org/lz4/lz4-java/1.7.1/lz4-java-1.7.1.jar:/Users/dilipbiswal/.m2/repository/com/github/luben/zstd-jni/1.4.5-2/zstd-jni-1.4.5-2.jar:/Users/dilipbiswal/.m2/repository/org/roaringbitmap/RoaringBitmap/0.7.45/RoaringBitmap-0.7.45.jar:/Users/dilipbiswal/.m2/repository/org/roaringbitmap/shims/0.7.45/shims-0.7.45.jar:/Users/dilipbiswal/.m2/repository/commons-net/commons-net/3.1/commons-net-3.1.jar:/Users/dilipbiswal/.m2/repository/org/scala-lang/modules/scala-xml_2.12/1.2.0/scala-xml_2.12-1.2.0.jar:/Users/dilipbiswal/.m2/repository/org/json4s/json4s-jackson_2.12/3.6.6/json4s-jackson_2.12-3.6.6.jar:/Users/dilipbiswal/.m2/repository/org/json4s/json4s-core_2.12/3.6.6/json4s-core_2.12-3.6.6.jar:/Users/dilipbiswal/.m2/repository/org/json4s/json4s-ast_2.12/3.6.6/json4s-ast_2.12-3.6.6.jar:/Users/dilipbiswal/.m2/repository/org/json4s/json4s-scalap_2.12/3.6.6/json4s-scalap_2.12-3.6.6.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/jersey/core/jersey-client/2.30/jersey-client-2.30.jar:/Users/dilipbiswal/.m2/repository/jakarta/ws/rs/jakarta.ws.rs-api/2.1.6/jakarta.ws.rs-api-2.1.6.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/hk2/external/jakarta.inject/2.6.1/jakarta.inject-2.6.1.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/jersey/core/jersey-common/2.30/jersey-common-2.30.jar:/Users/dilipbiswal/.m2/repository/jakarta/annotation/jakarta.annotation-api/1.3.5/jakarta.annotation-api-1.3.5.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/hk2/osgi-resource-locator/1.0.3/osgi-resource-locator-1.0.3.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/jersey/core/jersey-server/2.30/jersey-server-2.30.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/jersey/media/jersey-media-jaxb/2.30/jersey-media-jaxb-2.30.jar:/Users/dilipbiswal/.m2/repository/jakarta/validation/jakarta.validation-api/2.0.2/jakarta.validation-api-2.0.2.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/jersey/containers/jersey-container-servlet/2.30/jersey-container-servlet-2.30.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/jersey/containers/jersey-container-servlet-core/2.30/jersey-container-servlet-core-2.30.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/jersey/inject/jersey-hk2/2.30/jersey-hk2-2.30.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/hk2/hk2-locator/2.6.1/hk2-locator-2.6.1.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/hk2/external/aopalliance-repackaged/2.6.1/aopalliance-repackaged-2.6.1.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/hk2/hk2-api/2.6.1/hk2-api-2.6.1.jar:/Users/dilipbiswal/.m2/repository/org/glassfish/hk2/hk2-utils/2.6.1/hk2-utils-2.6.1.jar:/Users/dilipbiswal/.m2/repository/org/javassist/javassist/3.25.0-GA/javassist-3.25.0-GA.jar:/Users/dilipbiswal/.m2/repository/io/netty/netty-all/4.1.47.Final/netty-all-4.1.47.Final.jar:/Users/dilipbiswal/.m2/repository/com/clearspring/analytics/stream/2.9.6/stream-2.9.6.jar:/Users/dilipbiswal/.m2/repository/io/dropwizard/metrics/metrics-core/4.1.1/metrics-core-4.1.1.jar:/Users/dilipbiswal/.m2/repository/io/dropwizard/metrics/metrics-jvm/4.1.1/metrics-jvm-4.1.1.jar:/Users/dilipbiswal/.m2/repository/io/dropwizard/metrics/metrics-json/4.1.1/metrics-json-4.1.1.jar:/Users/dilipbiswal/.m2/repository/io/dropwizard/metrics/metrics-graphite/4.1.1/metrics-graphite-4.1.1.jar:/Users/dilipbiswal/.m2/repository/io/dropwizard/metrics/metrics-jmx/4.1.1/metrics-jmx-4.1.1.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/core/jackson-databind/2.10.0/jackson-databind-2.10.0.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/module/jackson-module-scala_2.12/2.10.0/jackson-module-scala_2.12-2.10.0.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/module/jackson-module-paranamer/2.10.0/jackson-module-paranamer-2.10.0.jar:/Users/dilipbiswal/.m2/repository/org/apache/ivy/ivy/2.4.0/ivy-2.4.0.jar:/Users/dilipbiswal/.m2/repository/oro/oro/2.0.8/oro-2.0.8.jar:/Users/dilipbiswal/.m2/repository/net/razorvine/pyrolite/4.30/pyrolite-4.30.jar:/Users/dilipbiswal/.m2/repository/net/sf/py4j/py4j/0.10.9/py4j-0.10.9.jar:/Users/dilipbiswal/.m2/repository/org/apache/commons/commons-crypto/1.0.0/commons-crypto-1.0.0.jar:/Users/dilipbiswal/mygit/apache/spark/core/target/scala-2.12/test-classes:/Users/dilipbiswal/mygit/apache/spark/common/tags/target/scala-2.12/classes:/Users/dilipbiswal/mygit/apache/spark/common/tags/target/scala-2.12/test-classes:/Users/dilipbiswal/.m2/repository/org/mockito/mockito-core/3.1.0/mockito-core-3.1.0.jar:/Users/dilipbiswal/.m2/repository/net/bytebuddy/byte-buddy/1.9.10/byte-buddy-1.9.10.jar:/Users/dilipbiswal/.m2/repository/net/bytebuddy/byte-buddy-agent/1.9.10/byte-buddy-agent-1.9.10.jar:/Users/dilipbiswal/.m2/repository/org/objenesis/objenesis/2.6/objenesis-2.6.jar:/Users/dilipbiswal/mygit/apache/spark/common/unsafe/target/scala-2.12/classes:/Users/dilipbiswal/mygit/apache/spark/common/sketch/target/scala-2.12/classes:/Users/dilipbiswal/.m2/repository/org/scalacheck/scalacheck_2.12/1.14.2/scalacheck_2.12-1.14.2.jar:/Users/dilipbiswal/.m2/repository/org/scala-sbt/test-interface/1.0/test-interface-1.0.jar:/Users/dilipbiswal/.m2/repository/org/codehaus/janino/janino/3.1.2/janino-3.1.2.jar:/Users/dilipbiswal/.m2/repository/org/codehaus/janino/commons-compiler/3.1.2/commons-compiler-3.1.2.jar:/Users/dilipbiswal/.m2/repository/org/antlr/antlr4-runtime/4.7.1/antlr4-runtime-4.7.1.jar:/Users/dilipbiswal/.m2/repository/commons-codec/commons-codec/1.10/commons-codec-1.10.jar:/Users/dilipbiswal/.m2/repository/com/univocity/univocity-parsers/2.8.3/univocity-parsers-2.8.3.jar:/Users/dilipbiswal/.m2/repository/org/apache/arrow/arrow-vector/0.15.1/arrow-vector-0.15.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/arrow/arrow-format/0.15.1/arrow-format-0.15.1.jar:/Users/dilipbiswal/.m2/repository/org/apache/arrow/arrow-memory/0.15.1/arrow-memory-0.15.1.jar:/Users/dilipbiswal/.m2/repository/com/fasterxml/jackson/core/jackson-core/2.10.0/jackson-core-2.10.0.jar:/Users/dilipbiswal/.m2/repository/com/google/flatbuffers/flatbuffers-java/1.9.0/flatbuffers-java-1.9.0.jar:/Users/dilipbiswal/.m2/repository/org/spark-project/spark/unused/1.0.0/unused-1.0.0.jar:/Users/dilipbiswal/.m2/repository/org/scalatest/scalatest_2.12/3.0.8/scalatest_2.12-3.0.8.jar:/Users/dilipbiswal/.m2/repository/org/scalactic/scalactic_2.12/3.0.8/scalactic_2.12-3.0.8.jar:/Users/dilipbiswal/.m2/repository/junit/junit/4.12/junit-4.12.jar:/Users/dilipbiswal/.m2/repository/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar:/Users/dilipbiswal/.m2/repository/com/novocode/junit-interface/0.11/junit-interface-0.11.jar:/Applications/IntelliJ IDEA CE.app/Contents/lib/idea_rt.jar", "java.vm.specification.version" -> "1.8", "sun.arch.data.model" -> "64", "java.home" -> "/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre", "sun.java.command" -> "org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestRunner -s org.apache.spark.sql.catalyst.parser.TableIdentifierParserSuite -C org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestReporter -showProgressMessages true", "java.specification.vendor" -> "Oracle Corporation", "user.language" -> "en", "awt.toolkit" -> "sun.lwawt.macosx.LWCToolkit", "java.vm.info" -> "mixed mode", "java.version" -> "1.8.0_221", "java.ext.dirs" -> "/Users/dilipbiswal/Library/Java/Extensions:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/ext:/Library/Java/Extensions:/Network/Library/Java/Extensions:/System/Library/Java/Extensions:/usr/lib/java", "sun.boot.class.path" -> "/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/resources.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/rt.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/sunrsasign.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/jsse.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/jce.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/charsets.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/lib/jfr.jar:/Library/Java/JavaVirtualMachines/jdk1.8.0_221.jdk/Contents/Home/jre/classes", "java.vendor" -> "Oracle Corporation", "file.separator" -> "/", "java.vendor.url.bug" -> "http://bugreport.sun.com/bugreport/", "sun.cpu.endian" -> "little", "sun.io.unicode.encoding" -> "UnicodeBig", "socksNonProxyHosts" -> "local|*.local|169.254/16|*.169.254/16", "ftp.nonProxyHosts" -> "local|*.local|169.254/16|*.169.254/16", "sun.cpu.isalist" -> "") did not contain key "spark.test.home", and Map("SHELL" -> "/bin/bash", "LOGNAME" -> "dilipbiswal", "PATH" -> "/usr/bin:/usr/local/Cellar/pyenv/1.2.13_1/libexec:/Users/dilipbiswal/gems/bin:/Users/dilipbiswal/.rbenv/shims:/Users/dilipbiswal/.pyenv/shims:/Users/dilipbiswal/.rbenv/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/dilipbiswal/bin:/Users/dilipbiswal/Library/Python/2.7/bin", "VERSIONER_PYTHON_VERSION" -> "2.7", "XPC_SERVICE_NAME" -> "com.jetbrains.intellij.ce.2624", "RBENV_SHELL" -> "bash", "HOME" -> "/Users/dilipbiswal", "JAVA_MAIN_CLASS_87487" -> "org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestRunner", "Apple_PubSub_Socket_Render" -> "/private/tmp/com.apple.launchd.wTYpBrujQD/Render", "USER" -> "dilipbiswal", "__CF_USER_TEXT_ENCODING" -> "0x1F5:0x0:0x0", "XPC_FLAGS" -> "0x0", "TMPDIR" -> "/var/folders/jv/tmdyc8n933s1fqlxhxps3nz00000gn/T/", "GEM_HOME" -> "/Users/dilipbiswal/gems", "PYENV_DIR" -> "/Applications/IntelliJ IDEA CE.app/Contents/bin", "PYENV_HOOK_PATH" -> "/Users/dilipbiswal/.pyenv/pyenv.d:/usr/local/Cellar/pyenv/1.2.13_1/pyenv.d:/usr/local/etc/pyenv.d:/etc/pyenv.d:/usr/lib/pyenv/hooks", "PWD" -> "/Users/dilipbiswal/mygit/apache/spark/sql/catalyst", "VERSIONER_PYTHON_PREFER_32_BIT" -> "no", "LC_CTYPE" -> "en_US.UTF-8", "PYENV_VERSION" -> "system", "PYENV_SHELL" -> "bash", "PYENV_ROOT" -> "/Users/dilipbiswal/.pyenv", "SSH_AUTH_SOCK" -> "/private/tmp/com.apple.launchd.sUq1TT83Ep/Listeners") did not contain key "SPARK_HOME" spark.test.home or SPARK_HOME is not set.
at org.scalatest.Assertions.newAssertionFailedExceptio
`
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Ran the tests in intellej manually to see the new error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-646004224
**[Test build #124210 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124210/testReport)** for PR 28825 at commit [`b02c82a`](https://github.com/apache/spark/commit/b02c82a2148e1c0f41f3e4c2a9d223728f18a464).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645828638
**[Test build #124204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124204/testReport)** for PR 28825 at commit [`c3bb548`](https://github.com/apache/spark/commit/c3bb54846f2b31977924f436ef60e1ddfffe1392).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645976532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645829218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645774200
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645828638
**[Test build #124204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124204/testReport)** for PR 28825 at commit [`c3bb548`](https://github.com/apache/spark/commit/c3bb54846f2b31977924f436ef60e1ddfffe1392).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645773587
**[Test build #124187 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124187/testReport)** for PR 28825 at commit [`0ff8bf0`](https://github.com/apache/spark/commit/0ff8bf0d1b25665e40c9518de4211b9912f8b61f).
* This patch passes all tests.
* This patch **does not merge cleanly**.
* This patch adds the following public classes _(experimental)_:
* `class TableIdentifierParserSuite extends SparkFunSuite with SQLHelper `
* `class SQLQueryTestSuite extends QueryTest with SharedSparkSession with SQLHelper `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643809567
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-646005597
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645742891
**[Test build #124193 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124193/testReport)** for PR 28825 at commit [`c3bb548`](https://github.com/apache/spark/commit/c3bb54846f2b31977924f436ef60e1ddfffe1392).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645820056
**[Test build #124190 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124190/testReport)** for PR 28825 at commit [`d70a2af`](https://github.com/apache/spark/commit/d70a2aff630ab90797bf90d235d56437b25b2ea1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class TableIdentifierParserSuite extends SparkFunSuite with SQLHelper `
* `class SQLQueryTestSuite extends QueryTest with SharedSparkSession with SQLHelper `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dilipbiswal commented on a change in pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
dilipbiswal commented on a change in pull request #28825:
URL: https://github.com/apache/spark/pull/28825#discussion_r439901179
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -135,8 +134,9 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
// 1. Maven can't get correct resource directory when resources in other jars.
// 2. We test subclasses in the hive-thriftserver module.
val sparkHome = {
- assert(sys.props.contains("spark.test.home") ||
- sys.env.contains("SPARK_HOME"), "spark.test.home or SPARK_HOME is not set.")
+ if (!(sys.props.contains("spark.test.home") || sys.env.contains("SPARK_HOME"))) {
+ fail("spark.test.home or SPARK_HOME is not set.")
+ }
sys.props.getOrElse("spark.test.home", sys.env("SPARK_HOME"))
}
Review comment:
Thanks @maropu @HyukjinKwon for the suggestion. I will make the change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARk-31950][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643751051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643840558
**[Test build #124011 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124011/testReport)** for PR 28825 at commit [`248d478`](https://github.com/apache/spark/commit/248d478a29c81b8b6f5d74d448468b04c0f36d72).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643809409
**[Test build #124011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124011/testReport)** for PR 28825 at commit [`248d478`](https://github.com/apache/spark/commit/248d478a29c81b8b6f5d74d448468b04c0f36d72).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645743276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643840923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645823694
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124193/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645774200
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645726464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645821010
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645823236
**[Test build #124193 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124193/testReport)** for PR 28825 at commit [`c3bb548`](https://github.com/apache/spark/commit/c3bb54846f2b31977924f436ef60e1ddfffe1392).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class SQLQueryTestSuite extends QueryTest with SharedSparkSession with SQLHelper `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645732637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-646026919
Merged to master and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643750910
**[Test build #124005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124005/testReport)** for PR 28825 at commit [`ad3bfb2`](https://github.com/apache/spark/commit/ad3bfb25d4f8b69c9cda77318f0a8a766d865360).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28825:
URL: https://github.com/apache/spark/pull/28825#discussion_r439890770
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -135,8 +134,9 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
// 1. Maven can't get correct resource directory when resources in other jars.
// 2. We test subclasses in the hive-thriftserver module.
val sparkHome = {
- assert(sys.props.contains("spark.test.home") ||
- sys.env.contains("SPARK_HOME"), "spark.test.home or SPARK_HOME is not set.")
+ if (!(sys.props.contains("spark.test.home") || sys.env.contains("SPARK_HOME"))) {
+ fail("spark.test.home or SPARK_HOME is not set.")
+ }
sys.props.getOrElse("spark.test.home", sys.env("SPARK_HOME"))
}
Review comment:
Ah, looks nice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645743276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645829218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dilipbiswal commented on pull request #28825: [SPARk-31950][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
dilipbiswal commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643750881
cc @maropu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645732637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28825:
URL: https://github.com/apache/spark/pull/28825#discussion_r441932726
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala
##########
@@ -26,7 +24,7 @@ import org.apache.spark.sql.catalyst.plans.SQLHelper
import org.apache.spark.sql.catalyst.util.fileToString
import org.apache.spark.sql.internal.SQLConf
-class TableIdentifierParserSuite extends SparkFunSuite with SQLHelper {
+class TableIdentifierParserSuite extends SparkFunSuite with SQLHelper {
Review comment:
nit there's one more space here ..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643782599
**[Test build #124005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124005/testReport)** for PR 28825 at commit [`ad3bfb2`](https://github.com/apache/spark/commit/ad3bfb25d4f8b69c9cda77318f0a8a766d865360).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28825: [SPARk-31950][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643750910
**[Test build #124005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124005/testReport)** for PR 28825 at commit [`ad3bfb2`](https://github.com/apache/spark/commit/ad3bfb25d4f8b69c9cda77318f0a8a766d865360).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dilipbiswal commented on pull request #28825: [SPARK-32020][SQL][TESTS] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
dilipbiswal commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-646361232
@dongjoon-hyun Sure.. Sorry.. i forgot this time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645976532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28825:
URL: https://github.com/apache/spark/pull/28825#discussion_r442023373
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/SQLHelper.scala
##########
@@ -83,4 +85,11 @@ trait SQLHelper {
}
}
}
+
+ lazy val sparkHome: String = {
Review comment:
protected?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28825:
URL: https://github.com/apache/spark/pull/28825#discussion_r441933345
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/SQLHelper.scala
##########
@@ -83,4 +85,11 @@ trait SQLHelper {
}
}
}
+
+ def getSparkHome(): String = {
Review comment:
I think you could even make it a `lazy val` can call it `sparkHome` I guess but shouldn't be a big deal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643809567
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645861578
LGTM. Pending Jenkins. Thanks, @dilipbiswal !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645732367
**[Test build #124190 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124190/testReport)** for PR 28825 at commit [`d70a2af`](https://github.com/apache/spark/commit/d70a2aff630ab90797bf90d235d56437b25b2ea1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645726046
**[Test build #124187 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124187/testReport)** for PR 28825 at commit [`0ff8bf0`](https://github.com/apache/spark/commit/0ff8bf0d1b25665e40c9518de4211b9912f8b61f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28825: [SPARK-32020][SQL][TESTS] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-646367195
It's okay~ I'm asking you a favor since you are active. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645855067
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #28825:
URL: https://github.com/apache/spark/pull/28825
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645732367
**[Test build #124190 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124190/testReport)** for PR 28825 at commit [`d70a2af`](https://github.com/apache/spark/commit/d70a2aff630ab90797bf90d235d56437b25b2ea1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643855656
Probably, I think its better to assign this refactoring to a new JIRA id.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dilipbiswal commented on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
dilipbiswal commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645827736
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645821010
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dilipbiswal commented on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
dilipbiswal commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-646058985
Thanks a lot @HyukjinKwon @maropu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #28825: [SPARK-32020][SQL][TESTS] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-646356225
Hi, @dilipbiswal . If you add `[TESTS]` tag for the test-only PR, it would be very helpful for the other people. Thank you in advance!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643782881
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28825:
URL: https://github.com/apache/spark/pull/28825#discussion_r441932959
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/SQLHelper.scala
##########
@@ -21,6 +21,8 @@ import java.time.ZoneId
import scala.util.control.NonFatal
+import org.scalatest.Assertions._
Review comment:
We could probably explicitly import what we need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643837389
For log readability, could you truncate the error messages in the PR description? Also, please add output messages after this PR applied?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643840923
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28825:
URL: https://github.com/apache/spark/pull/28825#discussion_r439878832
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -135,8 +134,9 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
// 1. Maven can't get correct resource directory when resources in other jars.
// 2. We test subclasses in the hive-thriftserver module.
val sparkHome = {
- assert(sys.props.contains("spark.test.home") ||
- sys.env.contains("SPARK_HOME"), "spark.test.home or SPARK_HOME is not set.")
+ if (!(sys.props.contains("spark.test.home") || sys.env.contains("SPARK_HOME"))) {
+ fail("spark.test.home or SPARK_HOME is not set.")
+ }
sys.props.getOrElse("spark.test.home", sys.env("SPARK_HOME"))
}
Review comment:
For reuse, could you move the logic to get `sparkHome` into `TestUtils`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645726464
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645974205
**[Test build #124204 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124204/testReport)** for PR 28825 at commit [`c3bb548`](https://github.com/apache/spark/commit/c3bb54846f2b31977924f436ef60e1ddfffe1392).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class SQLQueryTestSuite extends QueryTest with SharedSparkSession with SQLHelper `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645742891
**[Test build #124193 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124193/testReport)** for PR 28825 at commit [`c3bb548`](https://github.com/apache/spark/commit/c3bb54846f2b31977924f436ef60e1ddfffe1392).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645858145
**[Test build #124210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124210/testReport)** for PR 28825 at commit [`b02c82a`](https://github.com/apache/spark/commit/b02c82a2148e1c0f41f3e4c2a9d223728f18a464).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643782881
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-646005597
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARk-31950][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643751051
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645823689
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-643809409
**[Test build #124011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124011/testReport)** for PR 28825 at commit [`248d478`](https://github.com/apache/spark/commit/248d478a29c81b8b6f5d74d448468b04c0f36d72).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dilipbiswal commented on a change in pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
dilipbiswal commented on a change in pull request #28825:
URL: https://github.com/apache/spark/pull/28825#discussion_r442043743
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/SQLHelper.scala
##########
@@ -83,4 +85,11 @@ trait SQLHelper {
}
}
}
+
+ lazy val sparkHome: String = {
Review comment:
Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645855067
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645823689
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28825: [SPARK-32020][SQL][MINOR] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645726046
**[Test build #124187 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124187/testReport)** for PR 28825 at commit [`0ff8bf0`](https://github.com/apache/spark/commit/0ff8bf0d1b25665e40c9518de4211b9912f8b61f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #28825: [SPARk-31950][SQL][FOLLOW-UP][MINOR] Better error message on SPARK_HOME or…
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28825:
URL: https://github.com/apache/spark/pull/28825#discussion_r439889900
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -135,8 +134,9 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
// 1. Maven can't get correct resource directory when resources in other jars.
// 2. We test subclasses in the hive-thriftserver module.
val sparkHome = {
- assert(sys.props.contains("spark.test.home") ||
- sys.env.contains("SPARK_HOME"), "spark.test.home or SPARK_HOME is not set.")
+ if (!(sys.props.contains("spark.test.home") || sys.env.contains("SPARK_HOME"))) {
+ fail("spark.test.home or SPARK_HOME is not set.")
+ }
sys.props.getOrElse("spark.test.home", sys.env("SPARK_HOME"))
}
Review comment:
Yeah, let's do that. There look two more occurrences.
```
sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala: assert(sys.props.contains("spark.test.home") ||
sql/core/src/test/scala/org/apache/spark/sql/IntegratedUDFTestUtils.scala: assert(sys.props.contains("spark.test.home") ||
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28825: [SPARK-32020][SQL] Better error message when SPARK_HOME or spark.test.home is not set.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28825:
URL: https://github.com/apache/spark/pull/28825#issuecomment-645858145
**[Test build #124210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124210/testReport)** for PR 28825 at commit [`b02c82a`](https://github.com/apache/spark/commit/b02c82a2148e1c0f41f3e4c2a9d223728f18a464).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org