[GitHub] [tvm] wrongtest commented on pull request #9699: [TIR] Affine utility support freevars, iter lowerbound and diagnostics

[GitBox <gi...@apache.org>]

wrongtest commented on pull request #9699:
URL: https://github.com/apache/tvm/pull/9699#issuecomment-996433872


   Many thanks to your comments!
   
   > 1. Free vars
   >    I think currently the `DetectIterMap` already supports free var, as long as you don't include the var in the domain map
   
   Yes, I found that is the case. It should be my mistake on reason of failed cases.
   
   > 2\. Iters with lower bound constraints can be substituted with a zero-starting iter plus offset
   
   Previous trials for me seems it require `TryFuseIters` be aware of those introduced offsets during rewrites of actual iter expr. So a mark of non-zero start is not a good idea? (for simplicity and correctness). I will try update to follow the suggestion. 
   
   
   > the case shown in your description is not the same as the case you added in the testcase
   
   I will change the testcase to match  #9527,
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org