You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/01 03:31:33 UTC
[GitHub] [shardingsphere] Swastyy opened a new pull request #12868: Creating `single-feature-example` for `shardingsphere-jdbc-example`.
Swastyy opened a new pull request #12868:
URL: https://github.com/apache/shardingsphere/pull/12868
Fixes #12563
Changes proposed in this pull request:
-
-
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #12868: Creating `single-feature-example` for `shardingsphere-jdbc-example`.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #12868:
URL: https://github.com/apache/shardingsphere/pull/12868#issuecomment-931891886
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12868?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#12868](https://codecov.io/gh/apache/shardingsphere/pull/12868?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8bfa523) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7a0f6cba4e08b459a22199f4878a98fb21392684?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a0f6cb) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/12868/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/12868?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #12868 +/- ##
============================================
- Coverage 63.23% 63.21% -0.02%
Complexity 1354 1354
============================================
Files 2475 2475
Lines 37286 37295 +9
Branches 6421 6421
============================================
+ Hits 23576 23577 +1
- Misses 11843 11852 +9
+ Partials 1867 1866 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/12868?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../optimize/planner/QueryOptimizePlannerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/12868/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL3BsYW5uZXIvUXVlcnlPcHRpbWl6ZVBsYW5uZXJGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ommunication/jdbc/connection/ConnectionStatus.java](https://codecov.io/gh/apache/shardingsphere/pull/12868/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvY29ubmVjdGlvbi9Db25uZWN0aW9uU3RhdHVzLmphdmE=) | `100.00% <0.00%> (+9.09%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12868?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/12868?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7a0f6cb...8bfa523](https://codecov.io/gh/apache/shardingsphere/pull/12868?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang edited a comment on pull request #12868: Creating `single-feature-example` for `shardingsphere-jdbc-example`.
Posted by GitBox <gi...@apache.org>.
RaigorJiang edited a comment on pull request #12868:
URL: https://github.com/apache/shardingsphere/pull/12868#issuecomment-931970362
> @RaigorJiang I am sure of why the module `future-shadow-example` is not there.
It‘s OK, in yesterday's PR #12866 `shadow-example` and `future-shadow-example` have been merged to `shadow-example`.
Thank you again for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #12868: Creating `single-feature-example` for `shardingsphere-jdbc-example`.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #12868:
URL: https://github.com/apache/shardingsphere/pull/12868#issuecomment-931970362
> @RaigorJiang I am sure of why the module `future-shadow-example` is not there.
It‘s OK, in yesterday's PR https://github.com/apache/shardingsphere/pull/12867, `shadow-example` and `future-shadow-example` have been merged to `shadow-example`.
Thank you again for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #12868: Creating `single-feature-example` for `shardingsphere-jdbc-example`.
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged pull request #12868:
URL: https://github.com/apache/shardingsphere/pull/12868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Swastyy commented on pull request #12868: Creating `single-feature-example` for `shardingsphere-jdbc-example`.
Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #12868:
URL: https://github.com/apache/shardingsphere/pull/12868#issuecomment-931868340
@RaigorJiang I am sure of why the module `future-shadow-example` is not there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org