You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2019/09/19 22:07:30 UTC

[commons-bcel] branch master updated (5e1b24a -> 2abf359)

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git.


    from 5e1b24a  Fix checkstyle violations WRT array declarations.
     new eb0d2b2  Add a default Maven goal.
     new 2abf359  Fix generics compiler warnings and format tweaks.

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 pom.xml                                                 |  1 +
 .../org/apache/bcel/LocalVariableTypeTableTestCase.java | 17 +++++++++--------
 2 files changed, 10 insertions(+), 8 deletions(-)


[commons-bcel] 02/02: Fix generics compiler warnings and format tweaks.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git

commit 2abf359f5f7f897f070144d6f4f26deaa5ee1597
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Sep 19 18:07:25 2019 -0400

    Fix generics compiler warnings and format tweaks.
---
 .../org/apache/bcel/LocalVariableTypeTableTestCase.java | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/test/java/org/apache/bcel/LocalVariableTypeTableTestCase.java b/src/test/java/org/apache/bcel/LocalVariableTypeTableTestCase.java
index c55d79b..b9569c1 100644
--- a/src/test/java/org/apache/bcel/LocalVariableTypeTableTestCase.java
+++ b/src/test/java/org/apache/bcel/LocalVariableTypeTableTestCase.java
@@ -17,6 +17,10 @@
  */
 package org.apache.bcel;
 
+import java.lang.reflect.InvocationTargetException;
+import java.util.LinkedList;
+import java.util.List;
+
 import org.apache.bcel.classfile.JavaClass;
 import org.apache.bcel.classfile.Method;
 import org.apache.bcel.generic.ACONST_NULL;
@@ -31,13 +35,10 @@ import org.apache.bcel.generic.MethodGen;
 import org.apache.bcel.generic.Type;
 import org.junit.Test;
 
-import java.io.IOException;
-import java.lang.reflect.InvocationTargetException;
-import java.util.LinkedList;
-import java.util.List;
-
 public class LocalVariableTypeTableTestCase extends AbstractTestCase {
+    
     public class TestClassLoader extends ClassLoader {
+        
         public TestClassLoader(final ClassLoader parent) {
             super(parent);
         }
@@ -48,10 +49,10 @@ public class LocalVariableTypeTableTestCase extends AbstractTestCase {
     }
 
     @Test
-    public void testWithGenericArguement() throws ClassNotFoundException, NoSuchMethodException, InvocationTargetException, IllegalAccessException, IOException {
+    public void testWithGenericArguement() throws ClassNotFoundException, NoSuchMethodException, InvocationTargetException, IllegalAccessException {
         final String targetClass = PACKAGE_BASE_NAME + ".data.SimpleClassHasMethodIncludeGenericArgument";
         final TestClassLoader loader = new TestClassLoader(getClass().getClassLoader());
-        final Class cls = loader.findClass(targetClass, getBytesFromClass(targetClass));
+        final Class<?> cls = loader.findClass(targetClass, getBytesFromClass(targetClass));
 
         java.lang.reflect.Method method = cls.getDeclaredMethod("a", String.class, List.class);
         method.invoke(null, "a1", new LinkedList<String>());
@@ -63,7 +64,7 @@ public class LocalVariableTypeTableTestCase extends AbstractTestCase {
         method.invoke(null, new LinkedList<String>(), "d2");
     }
 
-    private byte[] getBytesFromClass(final String className) throws ClassNotFoundException, IOException {
+    private byte[] getBytesFromClass(final String className) throws ClassNotFoundException {
         final JavaClass clazz = getTestClass(className);
         final ConstantPoolGen cp = new ConstantPoolGen(clazz.getConstantPool());
 


[commons-bcel] 01/02: Add a default Maven goal.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git

commit eb0d2b2a72779b116c10021cd37097cac77e493d
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Sep 19 18:05:08 2019 -0400

    Add a default Maven goal.
---
 pom.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pom.xml b/pom.xml
index 5040876..c4810b9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -213,6 +213,7 @@
   </scm>
 
   <build>
+    <defaultGoal>clean verify apache-rat:check japicmp:cmp checkstyle:check javadoc:javadoc</defaultGoal>
     <plugins>
       <plugin>
         <groupId>org.apache.rat</groupId>