You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/11/10 00:30:00 UTC
Review Request 40109: Reconfiguring Kafka service via ambari-web
generates an error in stack advisor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40109/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-13803
https://issues.apache.org/jira/browse/AMBARI-13803
Repository: ambari
Description
-------
core-site was being referred from kafka recommendation function to determine kerberos security is enabled or not. While reconfiguring kafka, ambari-web does not send core-site and so stack advisor code breaks.
With the fix, kafka-broker site is checked and it's property is used to determine kerberos security status
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 820487d
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py c5620d7
Diff: https://reviews.apache.org/r/40109/diff/
Testing
-------
Tested the patch to fix issue on a cluster
Verified that there is no regression in python unit tests with the patch:
Test result before and after the patch applied:
----------------------------------------------------------------------
Ran 238 tests in 6.856s
OK
----------------------------------------------------------------------
Failed tests:
FAIL: test_pre_upgrade_restart_23 (test_namenode.TestNamenode)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/ambari/ambari-server/../ambari-common/src/test/python/mock/mock.py", line 1199, in patched
return func(*args, **keywargs)
File "/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/ambari/ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py", line 1323, in test_pre_upgrade_restart_23
self.assertEquals(1, mocks_dict['call'].call_count)
AssertionError: 1 != 0
----------------------------------------------------------------------
Total run:831
Total errors:0
Total failures:1
ERROR
Thanks,
Jaimin Jetly
Re: Review Request 40109: Reconfiguring Kafka service via ambari-web
generates an error in stack advisor
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40109/#review105767
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Nov. 9, 2015, 11:29 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40109/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2015, 11:29 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-13803
> https://issues.apache.org/jira/browse/AMBARI-13803
>
>
> Repository: ambari
>
>
> Description
> -------
>
> core-site was being referred from kafka recommendation function to determine kerberos security is enabled or not. While reconfiguring kafka, ambari-web does not send core-site and so stack advisor code breaks.
>
> With the fix, kafka-broker site is checked and it's property is used to determine kerberos security status
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 820487d
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py c5620d7
>
> Diff: https://reviews.apache.org/r/40109/diff/
>
>
> Testing
> -------
>
> Tested the patch to fix issue on a cluster
> Verified that there is no regression in python unit tests with the patch:
> Test result before and after the patch applied:
> ----------------------------------------------------------------------
> Ran 238 tests in 6.856s
>
> OK
> ----------------------------------------------------------------------
> Failed tests:
> FAIL: test_pre_upgrade_restart_23 (test_namenode.TestNamenode)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/ambari/ambari-server/../ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/Users/Jaimin/vagrant/ambari-vagrant/centos6.4/ambari/ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py", line 1323, in test_pre_upgrade_restart_23
> self.assertEquals(1, mocks_dict['call'].call_count)
> AssertionError: 1 != 0
>
> ----------------------------------------------------------------------
> Total run:831
> Total errors:0
> Total failures:1
> ERROR
>
>
> Thanks,
>
> Jaimin Jetly
>
>