You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by "amaliujia (via GitHub)" <gi...@apache.org> on 2023/05/31 17:01:48 UTC

[GitHub] [spark] amaliujia commented on a diff in pull request #41403: [SPARK-43895][CONNECT][GO] Prepare the go package path

amaliujia commented on code in PR #41403:
URL: https://github.com/apache/spark/pull/41403#discussion_r1212033227


##########
connector/connect/common/src/main/protobuf/buf.yaml:
##########
@@ -18,6 +18,8 @@ version: v1
 breaking:
   use:
     - FILE
+  except:
+    - FILE_SAME_GO_PACKAGE

Review Comment:
   Can I ask why we are excepting this? Proto is shared for every client?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org