You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/02 13:12:10 UTC
[GitHub] [spark] maropu opened a new pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
maropu opened a new pull request #29933:
URL: https://github.com/apache/spark/pull/29933
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Support query auto cancelling when running too long on thriftserver.
This is the rework of #28991 and the credit should be the original author, @leoluan2009.
Closes #28991
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
For some cases, we use thriftserver as long-running applications.
Some times we want all the query need not to run more than given time.
In these cases, we can enable auto cancel for time-consumed query.Which can let us release resources for other queries to run.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702763514
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33957/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703222226
**[Test build #129388 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129388/testReport)** for PR 29933 at commit [`3c86e74`](https://github.com/apache/spark/commit/3c86e74fa2fcb8cb58cc51e2da8e020d713f274a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703970425
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703957781
**[Test build #129429 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129429/testReport)** for PR 29933 at commit [`b3e9f23`](https://github.com/apache/spark/commit/b3e9f23dad2e4ee6023a6769f2bbad3730f219d4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707131883
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34298/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707546593
**[Test build #129731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129731/testReport)** for PR 29933 at commit [`27fcb7f`](https://github.com/apache/spark/commit/27fcb7f9f25eb3fd2497809c064c0226a4ea238b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [WIP][SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702800038
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33961/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707089733
**[Test build #129690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129690/testReport)** for PR 29933 at commit [`8874e3d`](https://github.com/apache/spark/commit/8874e3da88ade259d803ab37578a382b0945b9a2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r503895348
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -893,6 +893,16 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val THRIFTSERVER_QUERY_TIMEOUT =
+ buildConf("spark.sql.thriftServer.queryTimeout")
+ .doc("Specifies timeout in seconds for Thrift Server. A query will be cancelled " +
+ "automatically after the specified time. If a timeout value is set for each statement " +
+ "(e.g., via `java.sql.Statement.setQueryTimeout`), the value takes precedence. " +
+ "If the value is zero or negative, no timeout happens.")
+ .version("3.1.0")
Review comment:
Yea, I think so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r503673867
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -893,6 +893,16 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val THRIFTSERVER_QUERY_TIMEOUT =
+ buildConf("spark.sql.thriftServer.queryTimeout")
+ .doc("Specifies a global timeout value for Thrift Server. A query will be cancelled " +
+ "automatically after the specified time. If a timeout value is set for each statement " +
+ "(e.g., via `java.sql.Statement.setQueryTimeout`), the value takes precedence. " +
+ "If the value is zero or negative, no timeout happens.")
Review comment:
okay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707123507
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708651323
**[Test build #129761 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129761/testReport)** for PR 29933 at commit [`49a27df`](https://github.com/apache/spark/commit/49a27df139d089905a2353cd444c4b8aa5063c3a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707145846
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707546593
**[Test build #129731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129731/testReport)** for PR 29933 at commit [`27fcb7f`](https://github.com/apache/spark/commit/27fcb7f9f25eb3fd2497809c064c0226a4ea238b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707700346
**[Test build #129731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129731/testReport)** for PR 29933 at commit [`27fcb7f`](https://github.com/apache/spark/commit/27fcb7f9f25eb3fd2497809c064c0226a4ea238b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r499192491
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -201,6 +202,12 @@ private[hive] class SparkExecuteStatementOperation(
parentSession.getUsername)
setHasResultSet(true) // avoid no resultset for async run
+ if (queryTimeout > 0) {
+ Executors.newSingleThreadScheduledExecutor.schedule(new Runnable {
+ override def run(): Unit = cancel(OperationState.TIMEDOUT)
Review comment:
okay
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702765872
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129350/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703118715
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33985/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707232491
**[Test build #129692 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129692/testReport)** for PR 29933 at commit [`fdf1874`](https://github.com/apache/spark/commit/fdf18742e1f4e6306bfc2eb256aa3a1202d5d2d4).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707100460
**[Test build #129693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129693/testReport)** for PR 29933 at commit [`676c442`](https://github.com/apache/spark/commit/676c442a4ab6e1bc7dc8ad0af34459d123d167c4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707171841
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34300/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703184213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r502162237
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -329,17 +339,21 @@ private[hive] class SparkExecuteStatementOperation(
}
}
- override def cancel(): Unit = {
+ private def cancel(stateAfterCancel: OperationState): Unit = {
synchronized {
if (!getStatus.getState.isTerminal) {
logInfo(s"Cancel query with $statementId")
- setState(OperationState.CANCELED)
+ setState(stateAfterCancel)
cleanup()
HiveThriftServer2.eventManager.onStatementCanceled(statementId)
Review comment:
Also support add a server side configuration about query TIMEOUT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707089733
**[Test build #129690 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129690/testReport)** for PR 29933 at commit [`8874e3d`](https://github.com/apache/spark/commit/8874e3da88ade259d803ab37578a382b0945b9a2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708892187
**[Test build #129775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129775/testReport)** for PR 29933 at commit [`5e3c440`](https://github.com/apache/spark/commit/5e3c44060567d2234dd79d222f77bc58983bb805).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bogdanghit commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
bogdanghit commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r503900908
##########
File path: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/OperationManager.java
##########
@@ -86,20 +86,15 @@ private void initOperationLogCapture(String loggingMode) {
}
public ExecuteStatementOperation newExecuteStatementOperation(HiveSession parentSession,
- String statement, Map<String, String> confOverlay, boolean runAsync)
- throws HiveSQLException {
- ExecuteStatementOperation executeStatementOperation = ExecuteStatementOperation
- .newExecuteStatementOperation(parentSession, statement, confOverlay, runAsync, 0);
+ String statement, Map<String, String> confOverlay, boolean runAsync, long queryTimeout)
+ throws HiveSQLException {
+ ExecuteStatementOperation executeStatementOperation =
+ ExecuteStatementOperation.newExecuteStatementOperation(parentSession, statement,
+ confOverlay, runAsync, queryTimeout);
addOperation(executeStatementOperation);
return executeStatementOperation;
}
- public ExecuteStatementOperation newExecuteStatementOperation(HiveSession parentSession,
- String statement, Map<String, String> confOverlay, boolean runAsync, long queryTimeout)
- throws HiveSQLException {
- return newExecuteStatementOperation(parentSession, statement, confOverlay, runAsync);
- }
-
Review comment:
Can we just fix this to pass `queryTimeout` and also keep the method without the extra parameter which passes through timeout 0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707134232
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34299/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-714194190
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707501088
**[Test build #129728 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129728/testReport)** for PR 29933 at commit [`27fcb7f`](https://github.com/apache/spark/commit/27fcb7f9f25eb3fd2497809c064c0226a4ea238b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703116377
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33985/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707463501
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712803203
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703969602
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34036/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707111897
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707099522
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34294/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r504358168
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -45,11 +45,18 @@ private[hive] class SparkExecuteStatementOperation(
parentSession: HiveSession,
statement: String,
confOverlay: JMap[String, String],
- runInBackground: Boolean = true)
+ runInBackground: Boolean = true,
+ queryTimeout: Long)
extends ExecuteStatementOperation(parentSession, statement, confOverlay, runInBackground)
with SparkOperation
with Logging {
+ private val queryTimeoutValue = if (queryTimeout <= 0) {
Review comment:
> @wangyum @AngersZhuuuu Is This behaviour the same with the current Hive one?
When `THRIFTSERVER_QUERY_TIMEOUT ` less then user defined, we respect `THRIFTSERVER_QUERY_TIMEOUT `
https://github.com/apache/hive/blob/940ee46d3a7a9300a47e5beae7c3ca6eb32fd759/service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java#L118-L122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703957781
**[Test build #129429 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129429/testReport)** for PR 29933 at commit [`b3e9f23`](https://github.com/apache/spark/commit/b3e9f23dad2e4ee6023a6769f2bbad3730f219d4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #29933:
URL: https://github.com/apache/spark/pull/29933
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702732844
**[Test build #129347 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129347/testReport)** for PR 29933 at commit [`335bdd0`](https://github.com/apache/spark/commit/335bdd0be3c664f0670e155e25f2eacb98f3441b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29933: [SPARK-26533][SQL][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703951976
Sure, thanks, @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708104164
cc @juliuszsompolski as well (from #28991)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-704211982
kindly ping @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703186615
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703976057
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34036/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r503913850
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -45,11 +45,18 @@ private[hive] class SparkExecuteStatementOperation(
parentSession: HiveSession,
statement: String,
confOverlay: JMap[String, String],
- runInBackground: Boolean = true)
+ runInBackground: Boolean = true,
+ queryTimeout: Long)
extends ExecuteStatementOperation(parentSession, statement, confOverlay, runInBackground)
with SparkOperation
with Logging {
+ private val queryTimeoutValue = if (queryTimeout <= 0) {
+ sqlContext.conf.getConf(SQLConf.THRIFTSERVER_QUERY_TIMEOUT)
+ } else {
+ queryTimeout
+ }
+
Review comment:
This code assumes the server-side config is a global timeout value. If a user sets a timeout value via `setQueryTimeout`, the server uses the user-specified value instead of global one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707408459
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34320/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707400020
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34320/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703218589
**[Test build #129388 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129388/testReport)** for PR 29933 at commit [`3c86e74`](https://github.com/apache/spark/commit/3c86e74fa2fcb8cb58cc51e2da8e020d713f274a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707258719
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707233019
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r503673867
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -893,6 +893,16 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val THRIFTSERVER_QUERY_TIMEOUT =
+ buildConf("spark.sql.thriftServer.queryTimeout")
+ .doc("Specifies a global timeout value for Thrift Server. A query will be cancelled " +
+ "automatically after the specified time. If a timeout value is set for each statement " +
+ "(e.g., via `java.sql.Statement.setQueryTimeout`), the value takes precedence. " +
+ "If the value is zero or negative, no timeout happens.")
Review comment:
Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708712478
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707171825
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707233031
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129692/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707145846
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707580642
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707111872
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34294/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703184213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707132759
**[Test build #129694 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129694/testReport)** for PR 29933 at commit [`5ec7531`](https://github.com/apache/spark/commit/5ec75318d7a34ccb90aff125d9ef1f84eabcda05).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bogdanghit commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
bogdanghit commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r503877831
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -893,6 +893,16 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val THRIFTSERVER_QUERY_TIMEOUT =
+ buildConf("spark.sql.thriftServer.queryTimeout")
+ .doc("Specifies timeout in seconds for Thrift Server. A query will be cancelled " +
+ "automatically after the specified time. If a timeout value is set for each statement " +
+ "(e.g., via `java.sql.Statement.setQueryTimeout`), the value takes precedence. " +
+ "If the value is zero or negative, no timeout happens.")
+ .version("3.1.0")
Review comment:
is this version correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707148705
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708712478
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [WIP][SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703110581
**[Test build #129377 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129377/testReport)** for PR 29933 at commit [`eddfee9`](https://github.com/apache/spark/commit/eddfee9ac178fcd859012f4044001e95d67f8046).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703224884
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33995/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707118838
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [WIP][SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702787650
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33961/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702736868
**[Test build #129347 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129347/testReport)** for PR 29933 at commit [`335bdd0`](https://github.com/apache/spark/commit/335bdd0be3c664f0670e155e25f2eacb98f3441b).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702732844
**[Test build #129347 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129347/testReport)** for PR 29933 at commit [`335bdd0`](https://github.com/apache/spark/commit/335bdd0be3c664f0670e155e25f2eacb98f3441b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703218529
cc: @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707140311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707408474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707198771
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-706855156
**[Test build #129663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129663/testReport)** for PR 29933 at commit [`942ce58`](https://github.com/apache/spark/commit/942ce58331e5c535f7e3f1885f4caf3a93eb176d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-706879549
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712803203
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703181504
**[Test build #129387 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129387/testReport)** for PR 29933 at commit [`42991eb`](https://github.com/apache/spark/commit/42991eba1233f7ccf2508a6832549b1cece61ebd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702765853
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707463501
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r499196218
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -201,6 +202,12 @@ private[hive] class SparkExecuteStatementOperation(
parentSession.getUsername)
setHasResultSet(true) // avoid no resultset for async run
+ if (queryTimeout > 0) {
+ Executors.newSingleThreadScheduledExecutor.schedule(new Runnable {
+ override def run(): Unit = cancel(OperationState.TIMEDOUT)
Review comment:
We only know from the log in `cancel` that the query is canceled, but don't know it is timeout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707118736
**[Test build #129693 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129693/testReport)** for PR 29933 at commit [`676c442`](https://github.com/apache/spark/commit/676c442a4ab6e1bc7dc8ad0af34459d123d167c4).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r499182790
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -201,6 +202,12 @@ private[hive] class SparkExecuteStatementOperation(
parentSession.getUsername)
setHasResultSet(true) // avoid no resultset for async run
+ if (queryTimeout > 0) {
+ Executors.newSingleThreadScheduledExecutor.schedule(new Runnable {
+ override def run(): Unit = cancel(OperationState.TIMEDOUT)
Review comment:
Adding a log?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703224888
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702765853
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707082601
**[Test build #129688 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129688/testReport)** for PR 29933 at commit [`6f174f6`](https://github.com/apache/spark/commit/6f174f61209cc0203280d3feb2f6f79892689fd1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702736898
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703181504
**[Test build #129387 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129387/testReport)** for PR 29933 at commit [`42991eb`](https://github.com/apache/spark/commit/42991eba1233f7ccf2508a6832549b1cece61ebd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r502147007
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -329,17 +339,21 @@ private[hive] class SparkExecuteStatementOperation(
}
}
- override def cancel(): Unit = {
+ private def cancel(stateAfterCancel: OperationState): Unit = {
synchronized {
if (!getStatus.getState.isTerminal) {
logInfo(s"Cancel query with $statementId")
- setState(OperationState.CANCELED)
+ setState(stateAfterCancel)
cleanup()
HiveThriftServer2.eventManager.onStatementCanceled(statementId)
Review comment:
cc @juliuszsompolski @wangyum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [WIP][SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702800026
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702752336
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33957/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r503676101
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -893,6 +893,16 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val THRIFTSERVER_QUERY_TIMEOUT =
+ buildConf("spark.sql.thriftServer.queryTimeout")
+ .doc("Specifies a global timeout value for Thrift Server. A query will be cancelled " +
+ "automatically after the specified time. If a timeout value is set for each statement " +
+ "(e.g., via `java.sql.Statement.setQueryTimeout`), the value takes precedence. " +
+ "If the value is zero or negative, no timeout happens.")
Review comment:
Updated, could you check this again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r499193324
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -201,6 +202,12 @@ private[hive] class SparkExecuteStatementOperation(
parentSession.getUsername)
setHasResultSet(true) // avoid no resultset for async run
+ if (queryTimeout > 0) {
+ Executors.newSingleThreadScheduledExecutor.schedule(new Runnable {
+ override def run(): Unit = cancel(OperationState.TIMEDOUT)
Review comment:
Did you mean the log (that I added in L206) before starting the thread? Looks `cancel` itself already has a log in https://github.com/apache/spark/pull/29933/files#diff-72dcd8f81a51c8a815159fdf0332acdcR343 though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708846578
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707096695
**[Test build #129692 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129692/testReport)** for PR 29933 at commit [`fdf1874`](https://github.com/apache/spark/commit/fdf18742e1f4e6306bfc2eb256aa3a1202d5d2d4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703971703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703118723
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r504358168
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -45,11 +45,18 @@ private[hive] class SparkExecuteStatementOperation(
parentSession: HiveSession,
statement: String,
confOverlay: JMap[String, String],
- runInBackground: Boolean = true)
+ runInBackground: Boolean = true,
+ queryTimeout: Long)
extends ExecuteStatementOperation(parentSession, statement, confOverlay, runInBackground)
with SparkOperation
with Logging {
+ private val queryTimeoutValue = if (queryTimeout <= 0) {
Review comment:
> @wangyum @AngersZhuuuu Is This behaviour the same with the current Hive one?
When `THRIFTSERVER_QUERY_TIMEOUT ` less then user defined, we respect `THRIFTSERVER_QUERY_TIMEOUT `
https://github.com/apache/hive/blob/940ee46d3a7a9300a47e5beae7c3ca6eb32fd759/service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java#L118-L122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712641531
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712646216
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707111667
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34296/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707148705
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708697935
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708846566
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34381/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r502146652
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -329,17 +339,21 @@ private[hive] class SparkExecuteStatementOperation(
}
}
- override def cancel(): Unit = {
+ private def cancel(stateAfterCancel: OperationState): Unit = {
synchronized {
if (!getStatus.getState.isTerminal) {
logInfo(s"Cancel query with $statementId")
- setState(OperationState.CANCELED)
+ setState(stateAfterCancel)
cleanup()
HiveThriftServer2.eventManager.onStatementCanceled(statementId)
Review comment:
One problem, if query timeout, we still call
```
HiveThriftServer2.eventManager.onStatementCanceled(statementId)
```
then for timeout query, in spark thrift server ui, we still show it's cancelled, we can't know this sql is timeout directly.
IMO, We need to separate these two states.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702736906
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129347/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707632464
Thanks, @wangyum @AngersZhuuuu ~
If no more comment, I'll merge this in a few days. cc: @dongjoon-hyun @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-714023438
kindly ping.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703970425
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-706815441
@maropu . Sorry for being late. Do you have a comment on @AngersZhuuuu 's question?
BTW, for this one, I believe @wangyum is a better reviewer than me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703971703
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707139898
**[Test build #129688 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129688/testReport)** for PR 29933 at commit [`6f174f6`](https://github.com/apache/spark/commit/6f174f61209cc0203280d3feb2f6f79892689fd1).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702764006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r499217627
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -201,6 +202,12 @@ private[hive] class SparkExecuteStatementOperation(
parentSession.getUsername)
setHasResultSet(true) // avoid no resultset for async run
+ if (queryTimeout > 0) {
+ Executors.newSingleThreadScheduledExecutor.schedule(new Runnable {
+ override def run(): Unit = cancel(OperationState.TIMEDOUT)
Review comment:
Updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707580613
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34337/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707258732
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129694/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-706874052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bogdanghit commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
bogdanghit commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r503904107
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -45,11 +45,18 @@ private[hive] class SparkExecuteStatementOperation(
parentSession: HiveSession,
statement: String,
confOverlay: JMap[String, String],
- runInBackground: Boolean = true)
+ runInBackground: Boolean = true,
+ queryTimeout: Long)
extends ExecuteStatementOperation(parentSession, statement, confOverlay, runInBackground)
with SparkOperation
with Logging {
+ private val queryTimeoutValue = if (queryTimeout <= 0) {
+ sqlContext.conf.getConf(SQLConf.THRIFTSERVER_QUERY_TIMEOUT)
+ } else {
+ queryTimeout
+ }
+
Review comment:
I don't understand this. If the passed queryTimeout value is <= 0 why would we enforce the server-side configuration? And what is the relationship with setting `java.sql.Statement.setQueryTimeout`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bogdanghit commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
bogdanghit commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r503877529
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -893,6 +893,16 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val THRIFTSERVER_QUERY_TIMEOUT =
+ buildConf("spark.sql.thriftServer.queryTimeout")
Review comment:
Can you rewrite this as:
```
Set a query duration timeout in seconds in ThriftServer. If the timeout is set to a positive value, a running query will be cancelled automatically when the timeout is exceeded, otherwise the query continues to run till completion. Timeout values that are set for each statement via`java.sql.Statement.setQueryTimeout` take precedence.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707522367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r504360835
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -200,6 +207,12 @@ private[hive] class SparkExecuteStatementOperation(
parentSession.getUsername)
setHasResultSet(true) // avoid no resultset for async run
+ if (queryTimeoutValue > 0) {
+ Executors.newSingleThreadScheduledExecutor.schedule(new Runnable {
+ override def run(): Unit = timeoutCancel()
+ }, queryTimeoutValue, TimeUnit.SECONDS)
+ }
+
Review comment:
Maybe we need to call shutdown for this executor ?
https://github.com/apache/hive/blob/940ee46d3a7a9300a47e5beae7c3ca6eb32fd759/service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java#L170-L184
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703223178
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33995/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703971690
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34035/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708697613
**[Test build #129761 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129761/testReport)** for PR 29933 at commit [`49a27df`](https://github.com/apache/spark/commit/49a27df139d089905a2353cd444c4b8aa5063c3a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707522341
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34334/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702760498
**[Test build #129350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129350/testReport)** for PR 29933 at commit [`c0318c9`](https://github.com/apache/spark/commit/c0318c9b3faff56199e896197c22efb07db5347e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703118723
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712616386
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708846578
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-706879523
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34267/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712618494
**[Test build #130032 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130032/testReport)** for PR 29933 at commit [`5e3c440`](https://github.com/apache/spark/commit/5e3c44060567d2234dd79d222f77bc58983bb805).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712641531
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r502146652
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -329,17 +339,21 @@ private[hive] class SparkExecuteStatementOperation(
}
}
- override def cancel(): Unit = {
+ private def cancel(stateAfterCancel: OperationState): Unit = {
synchronized {
if (!getStatus.getState.isTerminal) {
logInfo(s"Cancel query with $statementId")
- setState(OperationState.CANCELED)
+ setState(stateAfterCancel)
cleanup()
HiveThriftServer2.eventManager.onStatementCanceled(statementId)
Review comment:
One problem, if query timeout, we still call
```
HiveThriftServer2.eventManager.onStatementCanceled(statementId)
```
then for timeout query, in spark thrift server ui, we still show it's cancelled, we can't know this sql is timeout directly.
IMO, We need to separate these two states.
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -329,17 +339,21 @@ private[hive] class SparkExecuteStatementOperation(
}
}
- override def cancel(): Unit = {
+ private def cancel(stateAfterCancel: OperationState): Unit = {
synchronized {
if (!getStatus.getState.isTerminal) {
logInfo(s"Cancel query with $statementId")
- setState(OperationState.CANCELED)
+ setState(stateAfterCancel)
cleanup()
HiveThriftServer2.eventManager.onStatementCanceled(statementId)
Review comment:
cc @juliuszsompolski @wangyum
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -329,17 +339,21 @@ private[hive] class SparkExecuteStatementOperation(
}
}
- override def cancel(): Unit = {
+ private def cancel(stateAfterCancel: OperationState): Unit = {
synchronized {
if (!getStatus.getState.isTerminal) {
logInfo(s"Cancel query with $statementId")
- setState(OperationState.CANCELED)
+ setState(stateAfterCancel)
cleanup()
HiveThriftServer2.eventManager.onStatementCanceled(statementId)
Review comment:
Also support add a server side configuration about query TIMEOUT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703186611
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33994/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712682665
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707123507
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708697935
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707514147
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34334/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708715392
**[Test build #129775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129775/testReport)** for PR 29933 at commit [`5e3c440`](https://github.com/apache/spark/commit/5e3c44060567d2234dd79d222f77bc58983bb805).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-706879549
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r503895106
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -893,6 +893,16 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val THRIFTSERVER_QUERY_TIMEOUT =
+ buildConf("spark.sql.thriftServer.queryTimeout")
Review comment:
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702760498
**[Test build #129350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129350/testReport)** for PR 29933 at commit [`c0318c9`](https://github.com/apache/spark/commit/c0318c9b3faff56199e896197c22efb07db5347e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702764006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [WIP][SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703115388
**[Test build #129377 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129377/testReport)** for PR 29933 at commit [`eddfee9`](https://github.com/apache/spark/commit/eddfee9ac178fcd859012f4044001e95d67f8046).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707580642
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702736898
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r503614378
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -893,6 +893,16 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val THRIFTSERVER_QUERY_TIMEOUT =
+ buildConf("spark.sql.thriftServer.queryTimeout")
+ .doc("Specifies a global timeout value for Thrift Server. A query will be cancelled " +
+ "automatically after the specified time. If a timeout value is set for each statement " +
+ "(e.g., via `java.sql.Statement.setQueryTimeout`), the value takes precedence. " +
+ "If the value is zero or negative, no timeout happens.")
Review comment:
Could we add time unit to doc? e.g., 'Timeout in seconds ...'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [WIP][SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702800026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707462834
**[Test build #129714 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129714/testReport)** for PR 29933 at commit [`b3fc95e`](https://github.com/apache/spark/commit/b3fc95e7c00e3321670963e8542277ccc5bf061c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708715392
**[Test build #129775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129775/testReport)** for PR 29933 at commit [`5e3c440`](https://github.com/apache/spark/commit/5e3c44060567d2234dd79d222f77bc58983bb805).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707501088
**[Test build #129728 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129728/testReport)** for PR 29933 at commit [`27fcb7f`](https://github.com/apache/spark/commit/27fcb7f9f25eb3fd2497809c064c0226a4ea238b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707148681
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34299/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r504356369
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -45,11 +45,18 @@ private[hive] class SparkExecuteStatementOperation(
parentSession: HiveSession,
statement: String,
confOverlay: JMap[String, String],
- runInBackground: Boolean = true)
+ runInBackground: Boolean = true,
+ queryTimeout: Long)
extends ExecuteStatementOperation(parentSession, statement, confOverlay, runInBackground)
with SparkOperation
with Logging {
+ private val queryTimeoutValue = if (queryTimeout <= 0) {
Review comment:
I am https://github.com/apache/hive/commit/b6218275b00b64aed7efaf470784cc0441464f67#diff-b0085fe84239ae927dfe7464a2174a1c80169bbb60a295e78aeb8df3747e4443R149. 0 seems default meaning no timeout that's matched with the current default's and behaviour here.
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -45,11 +45,18 @@ private[hive] class SparkExecuteStatementOperation(
parentSession: HiveSession,
statement: String,
confOverlay: JMap[String, String],
- runInBackground: Boolean = true)
+ runInBackground: Boolean = true,
+ queryTimeout: Long)
extends ExecuteStatementOperation(parentSession, statement, confOverlay, runInBackground)
with SparkOperation
with Logging {
+ private val queryTimeoutValue = if (queryTimeout <= 0) {
Review comment:
I just took a cursory look for https://github.com/apache/hive/commit/b6218275b00b64aed7efaf470784cc0441464f67#diff-b0085fe84239ae927dfe7464a2174a1c80169bbb60a295e78aeb8df3747e4443R149. 0 seems default meaning no timeout that's matched with the current default's and behaviour here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712670295
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34641/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r504391675
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -45,11 +45,18 @@ private[hive] class SparkExecuteStatementOperation(
parentSession: HiveSession,
statement: String,
confOverlay: JMap[String, String],
- runInBackground: Boolean = true)
+ runInBackground: Boolean = true,
+ queryTimeout: Long)
extends ExecuteStatementOperation(parentSession, statement, confOverlay, runInBackground)
with SparkOperation
with Logging {
+ private val queryTimeoutValue = if (queryTimeout <= 0) {
Review comment:
Ah, that's what I was looking for. Thanks! @AngersZhuuuu @HyukjinKwon Updated, could you check the latest fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707258719
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702765822
**[Test build #129350 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129350/testReport)** for PR 29933 at commit [`c0318c9`](https://github.com/apache/spark/commit/c0318c9b3faff56199e896197c22efb07db5347e).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703222317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r504312420
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -45,11 +45,18 @@ private[hive] class SparkExecuteStatementOperation(
parentSession: HiveSession,
statement: String,
confOverlay: JMap[String, String],
- runInBackground: Boolean = true)
+ runInBackground: Boolean = true,
+ queryTimeout: Long)
extends ExecuteStatementOperation(parentSession, statement, confOverlay, runInBackground)
with SparkOperation
with Logging {
+ private val queryTimeoutValue = if (queryTimeout <= 0) {
Review comment:
@wangyum @AngersZhuuuu Is This behaviour the same with the current Hive one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707171799
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34300/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708706782
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34367/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707408474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707386154
**[Test build #129714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129714/testReport)** for PR 29933 at commit [`b3fc95e`](https://github.com/apache/spark/commit/b3fc95e7c00e3321670963e8542277ccc5bf061c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707701367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712641317
**[Test build #130032 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130032/testReport)** for PR 29933 at commit [`5e3c440`](https://github.com/apache/spark/commit/5e3c44060567d2234dd79d222f77bc58983bb805).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703976076
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703966970
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34035/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707118842
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129693/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [WIP][SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-702800004
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33961/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707198783
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129690/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707111897
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707140320
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129688/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707159436
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34300/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-706874052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707537454
**[Test build #129728 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129728/testReport)** for PR 29933 at commit [`27fcb7f`](https://github.com/apache/spark/commit/27fcb7f9f25eb3fd2497809c064c0226a4ea238b).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707701367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707082601
**[Test build #129688 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129688/testReport)** for PR 29933 at commit [`6f174f6`](https://github.com/apache/spark/commit/6f174f61209cc0203280d3feb2f6f79892689fd1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712618494
**[Test build #130032 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130032/testReport)** for PR 29933 at commit [`5e3c440`](https://github.com/apache/spark/commit/5e3c44060567d2234dd79d222f77bc58983bb805).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703976076
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707522367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707171825
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-706855156
**[Test build #129663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129663/testReport)** for PR 29933 at commit [`942ce58`](https://github.com/apache/spark/commit/942ce58331e5c535f7e3f1885f4caf3a93eb176d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707537741
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129728/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708712466
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34367/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707543847
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [WIP][SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703115479
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703184138
**[Test build #129387 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129387/testReport)** for PR 29933 at commit [`42991eb`](https://github.com/apache/spark/commit/42991eba1233f7ccf2508a6832549b1cece61ebd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703970186
**[Test build #129429 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129429/testReport)** for PR 29933 at commit [`b3e9f23`](https://github.com/apache/spark/commit/b3e9f23dad2e4ee6023a6769f2bbad3730f219d4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703224888
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707132759
**[Test build #129694 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129694/testReport)** for PR 29933 at commit [`5ec7531`](https://github.com/apache/spark/commit/5ec75318d7a34ccb90aff125d9ef1f84eabcda05).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707100460
**[Test build #129693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129693/testReport)** for PR 29933 at commit [`676c442`](https://github.com/apache/spark/commit/676c442a4ab6e1bc7dc8ad0af34459d123d167c4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708697941
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129761/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707140311
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707569769
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34337/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712646194
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34638/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707537729
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-706873675
**[Test build #129663 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129663/testReport)** for PR 29933 at commit [`942ce58`](https://github.com/apache/spark/commit/942ce58331e5c535f7e3f1885f4caf3a93eb176d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703222317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708651323
**[Test build #129761 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129761/testReport)** for PR 29933 at commit [`49a27df`](https://github.com/apache/spark/commit/49a27df139d089905a2353cd444c4b8aa5063c3a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-714322784
Thanks, all~, Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707537729
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703218589
**[Test build #129388 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129388/testReport)** for PR 29933 at commit [`3c86e74`](https://github.com/apache/spark/commit/3c86e74fa2fcb8cb58cc51e2da8e020d713f274a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707118838
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712635362
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34638/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712641763
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707198272
**[Test build #129690 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129690/testReport)** for PR 29933 at commit [`8874e3d`](https://github.com/apache/spark/commit/8874e3da88ade259d803ab37578a382b0945b9a2).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707123493
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34296/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707198771
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703185308
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33994/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #29933:
URL: https://github.com/apache/spark/pull/29933#discussion_r499196239
##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -201,6 +202,12 @@ private[hive] class SparkExecuteStatementOperation(
parentSession.getUsername)
setHasResultSet(true) // avoid no resultset for async run
+ if (queryTimeout > 0) {
+ Executors.newSingleThreadScheduledExecutor.schedule(new Runnable {
+ override def run(): Unit = cancel(OperationState.TIMEDOUT)
Review comment:
I'd like to let user know it is canceled because of timeout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712802126
**[Test build #130034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130034/testReport)** for PR 29933 at commit [`5e3c440`](https://github.com/apache/spark/commit/5e3c44060567d2234dd79d222f77bc58983bb805).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703186615
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712616332
Anyone could check this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703115479
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712645549
**[Test build #130034 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130034/testReport)** for PR 29933 at commit [`5e3c440`](https://github.com/apache/spark/commit/5e3c44060567d2234dd79d222f77bc58983bb805).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-712645549
**[Test build #130034 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130034/testReport)** for PR 29933 at commit [`5e3c440`](https://github.com/apache/spark/commit/5e3c44060567d2234dd79d222f77bc58983bb805).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708892981
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707258023
**[Test build #129694 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129694/testReport)** for PR 29933 at commit [`5ec7531`](https://github.com/apache/spark/commit/5ec75318d7a34ccb90aff125d9ef1f84eabcda05).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-706871871
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34267/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29933: [WIP][SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-703110581
**[Test build #129377 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129377/testReport)** for PR 29933 at commit [`eddfee9`](https://github.com/apache/spark/commit/eddfee9ac178fcd859012f4044001e95d67f8046).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708712482
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34367/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708841663
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34381/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-708892981
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707096695
**[Test build #129692 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129692/testReport)** for PR 29933 at commit [`fdf1874`](https://github.com/apache/spark/commit/fdf18742e1f4e6306bfc2eb256aa3a1202d5d2d4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707600968
Another minor issue is that the error message is incorrect, but it seems that it should be fixed on the Hive side:
```
0: jdbc:hive2://localhost:10000/default> set spark.sql.thriftServer.queryTimeout=5;
+--------------------------------------+--------+
| key | value |
+--------------------------------------+--------+
| spark.sql.thriftServer.queryTimeout | 5 |
+--------------------------------------+--------+
1 row selected (0.037 seconds)
0: jdbc:hive2://localhost:10000/default> select java_method('java.lang.Thread', 'sleep', 10000L);
Error: Query timed out after 0 seconds (state=,code=0)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707145823
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34298/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707386154
**[Test build #129714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129714/testReport)** for PR 29933 at commit [`b3fc95e`](https://github.com/apache/spark/commit/b3fc95e7c00e3321670963e8542277ccc5bf061c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29933: [SPARK-26533][SQL] Support query auto timeout cancel on thriftserver
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29933:
URL: https://github.com/apache/spark/pull/29933#issuecomment-707233019
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org