You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/05/11 23:55:37 UTC
[GitHub] [druid] clintropolis opened a new pull request #11236: add estimated byte size limit enforcement for heap based expression agg
clintropolis opened a new pull request #11236:
URL: https://github.com/apache/druid/pull/11236
### Description
Does what the title says, and adds max bytes limit enforcement to the heap based `ExpressionLambdaAggregator` to bring its behavior inline with `ExpressionLambdaBufferAggregator` and `ExpressionLambdaVectorAggregator`.
This PR has:
- [x] been self-reviewed.
- [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #11236: add estimated byte size limit enforcement for heap based expression agg
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11236:
URL: https://github.com/apache/druid/pull/11236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org