[GitHub] [pinot] snleee commented on a change in pull request #7492: Add option to limit thread usage per query

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #7492:
URL: https://github.com/apache/pinot/pull/7492#discussion_r718220702



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java
##########
@@ -55,27 +55,21 @@
   protected final QueryContext _queryContext;
   protected final ExecutorService _executorService;
   protected final long _endTimeMs;
-  protected final int _numThreads;
+  protected final int _numTasks;

Review comment:
       Can you add a comment on what the `task` would mean in this context? (e.g. the unit of parallelism)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org