You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Mark Sandori (JIRA)" <ji...@apache.org> on 2007/10/09 19:52:51 UTC
[jira] Created: (WICKET-1056) CreditCardValidator does not handle
spaces or dashes
CreditCardValidator does not handle spaces or dashes
----------------------------------------------------
Key: WICKET-1056
URL: https://issues.apache.org/jira/browse/WICKET-1056
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3.0-beta3
Reporter: Mark Sandori
Priority: Minor
The CreditCardValidator assumes that the provided input only contains numbers without spaces, dashes, etc.
The validator should be extended to properly handle these common input scenarios, perhaps with an optional attribute around stripping these unwanted characters from the input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1056) CreditCardValidator does not handle
spaces or dashes
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1056:
---------------------------------------
Fix Version/s: (was: 1.3.0-rc1)
1.3.0-rc2
> CreditCardValidator does not handle spaces or dashes
> ----------------------------------------------------
>
> Key: WICKET-1056
> URL: https://issues.apache.org/jira/browse/WICKET-1056
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Mark Sandori
> Priority: Minor
> Fix For: 1.3.0-rc2
>
>
> The CreditCardValidator assumes that the provided input only contains numbers without spaces, dashes, etc.
> The validator should be extended to properly handle these common input scenarios, perhaps with an optional attribute around stripping these unwanted characters from the input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1056) CreditCardValidator does not handle
spaces or dashes
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-1056:
-------------------------------------
Assignee: Johan Compagner
johan, its your baby...
> CreditCardValidator does not handle spaces or dashes
> ----------------------------------------------------
>
> Key: WICKET-1056
> URL: https://issues.apache.org/jira/browse/WICKET-1056
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Mark Sandori
> Assignee: Johan Compagner
> Priority: Minor
> Fix For: 1.3.0-rc3
>
> Attachments: CreditCardValidator.patch.gz
>
>
> The CreditCardValidator assumes that the provided input only contains numbers without spaces, dashes, etc.
> The validator should be extended to properly handle these common input scenarios, perhaps with an optional attribute around stripping these unwanted characters from the input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-1056) CreditCardValidator does not handle
spaces or dashes
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner closed WICKET-1056.
-----------------------------------
Resolution: Fixed
applied it. I think its fine by default.
> CreditCardValidator does not handle spaces or dashes
> ----------------------------------------------------
>
> Key: WICKET-1056
> URL: https://issues.apache.org/jira/browse/WICKET-1056
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Mark Sandori
> Assignee: Johan Compagner
> Priority: Minor
> Fix For: 1.3.0-rc3
>
> Attachments: CreditCardValidator.patch.gz
>
>
> The CreditCardValidator assumes that the provided input only contains numbers without spaces, dashes, etc.
> The validator should be extended to properly handle these common input scenarios, perhaps with an optional attribute around stripping these unwanted characters from the input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1056) CreditCardValidator does not handle
spaces or dashes
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1056:
---------------------------------------
Fix Version/s: (was: 1.3.0-rc3)
1.3.0-final
> CreditCardValidator does not handle spaces or dashes
> ----------------------------------------------------
>
> Key: WICKET-1056
> URL: https://issues.apache.org/jira/browse/WICKET-1056
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Mark Sandori
> Assignee: Johan Compagner
> Priority: Minor
> Fix For: 1.3.0-final
>
> Attachments: CreditCardValidator.patch.gz
>
>
> The CreditCardValidator assumes that the provided input only contains numbers without spaces, dashes, etc.
> The validator should be extended to properly handle these common input scenarios, perhaps with an optional attribute around stripping these unwanted characters from the input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1056) CreditCardValidator does not handle
spaces or dashes
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1056:
---------------------------------------
Fix Version/s: (was: 1.3.0-rc2)
1.3.0-rc3
> CreditCardValidator does not handle spaces or dashes
> ----------------------------------------------------
>
> Key: WICKET-1056
> URL: https://issues.apache.org/jira/browse/WICKET-1056
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Mark Sandori
> Priority: Minor
> Fix For: 1.3.0-rc3
>
> Attachments: CreditCardValidator.patch.gz
>
>
> The CreditCardValidator assumes that the provided input only contains numbers without spaces, dashes, etc.
> The validator should be extended to properly handle these common input scenarios, perhaps with an optional attribute around stripping these unwanted characters from the input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1056) CreditCardValidator does not handle
spaces or dashes
Posted by "Johan Karlberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Karlberg updated WICKET-1056:
-----------------------------------
Attachment: CreditCardValidator.patch.gz
This trivial patch strips spaces and dashes explicitly. It's trivial to change the pattern to strip something else, even \\D, but the more we strip the less validation this validator actually provides. I'm not entirely sure we should even apply this patch, but rather prefer that people subclass the validator if they have less strict validation requirements. At the very least, normalize your input before storing it in the database, because "00---00000 0 0 0--0" just became a valid credit card number ;)
> CreditCardValidator does not handle spaces or dashes
> ----------------------------------------------------
>
> Key: WICKET-1056
> URL: https://issues.apache.org/jira/browse/WICKET-1056
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Mark Sandori
> Priority: Minor
> Fix For: 1.3.0-rc2
>
> Attachments: CreditCardValidator.patch.gz
>
>
> The CreditCardValidator assumes that the provided input only contains numbers without spaces, dashes, etc.
> The validator should be extended to properly handle these common input scenarios, perhaps with an optional attribute around stripping these unwanted characters from the input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1056) CreditCardValidator does not handle
spaces or dashes
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538395 ]
Igor Vaynberg commented on WICKET-1056:
---------------------------------------
patch would be nice...
> CreditCardValidator does not handle spaces or dashes
> ----------------------------------------------------
>
> Key: WICKET-1056
> URL: https://issues.apache.org/jira/browse/WICKET-1056
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta3
> Reporter: Mark Sandori
> Priority: Minor
> Fix For: 1.3.0-beta5
>
>
> The CreditCardValidator assumes that the provided input only contains numbers without spaces, dashes, etc.
> The validator should be extended to properly handle these common input scenarios, perhaps with an optional attribute around stripping these unwanted characters from the input.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.