You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Maurizio Cucchiara <ma...@gmail.com> on 2011/02/01 05:29:38 UTC

Re: svn commit: r1065355 - /struts/struts2/trunk/xwork-core/pom.xml

Have you tried to launch the struts blank application after this change?
FileUtils depends on a lot of other io classes,  when you shade it
xwork starts to looking for other resources along the
org/apache/commons/io/xwork/
path.

On 30 January 2011 20:13,  <ja...@apache.org> wrote:
> Author: jafl
> Date: Sun Jan 30 19:13:44 2011
> New Revision: 1065355
>
> URL: http://svn.apache.org/viewvc?rev=1065355&view=rev
> Log:
> XW-388 fix pattern to match relocation
>
> Modified:
>    struts/struts2/trunk/xwork-core/pom.xml
>
> Modified: struts/struts2/trunk/xwork-core/pom.xml
> URL: http://svn.apache.org/viewvc/struts/struts2/trunk/xwork-core/pom.xml?rev=1065355&r1=1065354&r2=1065355&view=diff
> ==============================================================================
> --- struts/struts2/trunk/xwork-core/pom.xml (original)
> +++ struts/struts2/trunk/xwork-core/pom.xml Sun Jan 30 19:13:44 2011
> @@ -219,7 +219,7 @@
>                                     <shadedPattern>org.apache.commons.lang.xwork</shadedPattern>
>                                 </relocation>
>                                 <relocation>
> -                                    <pattern>org.apache.commons.lang</pattern>
> +                                    <pattern>org.apache.commons.io</pattern>
>                                     <shadedPattern>org.apache.commons.io.xwork</shadedPattern>
>                                 </relocation>
>                             </relocations>
>
>
>



-- 
Maurizio Cucchiara

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: svn commit: r1065355 - /struts/struts2/trunk/xwork-core/pom.xml

Posted by John Lindal <li...@yahoo-inc.com>.
I get the same results that you get.  So it seems the correct solution is to remove org.apache.commons.io.xwork completely.  When I do this, it also works just fine.  In fact, it appears that we can remove both org.apache.commons.io.xwork and the objectweb shading - which is what I was planning to do with the ticket in the first place.

Any objections?

John


On 2/14/11 7:27 AM, "Maurizio Cucchiara" <ma...@gmail.com> wrote:

On 14 February 2011 16:11, John Lindal <li...@yahoo-inc.com> wrote:
> Try locally reverting the change to xwork-core/pom.xml in ticket XW-388 and see if it helps.
Sure that it helps, if I rollback to the previous version (the one
with the commons.lang typo) everything works like a charm.
As far as I can understand since you have corrected the shade
configuration, maven starts to copy FileUtils.class along the path
org.apache.commons.io.xwork.  I think that the NoClassDefFoundError is
a side effect of the current path of FileUtils class (the class loader
was trying to find the error class out in the current path).


> I'll investigate on my end, too.  The strange thing is that the maven-shade-plugin configuration doesn't mention FileExistsException, and I can't find any references to "org.apache.commons.io.xwork" in trunk.

Please, let me know.
--
Maurizio Cucchiara

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: svn commit: r1065355 - /struts/struts2/trunk/xwork-core/pom.xml

Posted by Maurizio Cucchiara <ma...@gmail.com>.
On 14 February 2011 16:11, John Lindal <li...@yahoo-inc.com> wrote:
> Try locally reverting the change to xwork-core/pom.xml in ticket XW-388 and see if it helps.
Sure that it helps, if I rollback to the previous version (the one
with the commons.lang typo) everything works like a charm.
As far as I can understand since you have corrected the shade
configuration, maven starts to copy FileUtils.class along the path
org.apache.commons.io.xwork.  I think that the NoClassDefFoundError is
a side effect of the current path of FileUtils class (the class loader
was trying to find the error class out in the current path).


> I'll investigate on my end, too.  The strange thing is that the maven-shade-plugin configuration doesn't mention FileExistsException, and I can't find any references to "org.apache.commons.io.xwork" in trunk.

Please, let me know.
-- 
Maurizio Cucchiara

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: svn commit: r1065355 - /struts/struts2/trunk/xwork-core/pom.xml

Posted by John Lindal <li...@yahoo-inc.com>.
Try locally reverting the change to xwork-core/pom.xml in ticket XW-388 and see if it helps.

I'll investigate on my end, too.  The strange thing is that the maven-shade-plugin configuration doesn't mention FileExistsException, and I can't find any references to "org.apache.commons.io.xwork" in trunk.

John


On 2/13/11 9:45 AM, "Maurizio Cucchiara" <ma...@gmail.com> wrote:

Probably it's the mess in my maven repository but every time I launch
the blank application with mvn jetty:run, I always get the following
error (could you check on your local repository, please?):

WARNING: Could not create JarEntryRevision for
[jar:file:/home/maurizio/.m2/repository/org/apache/struts/struts2-core/2.2.2-SNAPSHOT/struts2-core-2.2.2-SNAPSHOT.jar]!
java.lang.NoClassDefFoundError: org/apache/commons/io/xwork/FileExistsException
        at com.opensymphony.xwork2.util.FileManager$JarEntryRevision.build(FileManager.java:307)
        at com.opensymphony.xwork2.util.FileManager.loadFile(FileManager.java:145)
        at com.opensymphony.xwork2.util.FileManager.loadFile(FileManager.java:105)
        at com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.loadConfigurationFiles(XmlConfigurationProvider.java:898)
        at com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.loadDocuments(XmlConfigurationProvider.java:154)
        at com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.init(XmlConfigurationProvider.java:121)
        at com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(DefaultConfiguration.java:179)
        at com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:66)
        at org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.java:380)
        at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:424)
        at org.apache.struts2.dispatcher.ng.InitOperations.initDispatcher(InitOperations.java:69)
        at org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrepareAndExecuteFilter.java:51)
        at org.mortbay.jetty.servlet.FilterHolder.doStart(FilterHolder.java:95)
        at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
        at org.mortbay.jetty.servlet.ServletHandler.initialize(ServletHandler.java:545)
        at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1133)
        at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:420)
        at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:457)
        at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
        at org.mortbay.jetty.handler.HandlerCollection.doStart(HandlerCollection.java:156)
        at org.mortbay.jetty.handler.ContextHandlerCollection.doStart(ContextHandlerCollection.java:120)
        at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
        at org.mortbay.jetty.handler.HandlerCollection.doStart(HandlerCollection.java:156)
        at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
        at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:119)
        at org.mortbay.jetty.Server.doStart(Server.java:210)
        at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
        at org.mortbay.jetty.plugin.Jetty6PluginServer.start(Jetty6PluginServer.java:134)
        at org.mortbay.jetty.plugin.AbstractJettyMojo.startJetty(AbstractJettyMojo.java:327)
        at org.mortbay.jetty.plugin.AbstractJettyMojo.execute(AbstractJettyMojo.java:272)
        at org.mortbay.jetty.plugin.AbstractJettyRunMojo.execute(AbstractJettyRunMojo.java:177)
        at org.mortbay.jetty.plugin.Jetty6RunMojo.execute(Jetty6RunMojo.java:183)
        at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:107)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:195)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:140)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
        at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
        at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:316)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:153)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:451)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:188)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:134)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
        at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
        at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: java.lang.ClassNotFoundException:
org.apache.commons.io.xwork.FileExistsException
        at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
        at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:244)
        at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:230)
        at org.mortbay.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:358)
        at org.mortbay.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:320)
        ... 53 more


On 1 February 2011 05:29, Maurizio Cucchiara
<ma...@gmail.com> wrote:
> Have you tried to launch the struts blank application after this change?
> FileUtils depends on a lot of other io classes,  when you shade it
> xwork starts to looking for other resources along the
> org/apache/commons/io/xwork/
> path.
>
> On 30 January 2011 20:13,  <ja...@apache.org> wrote:
>> Author: jafl
>> Date: Sun Jan 30 19:13:44 2011
>> New Revision: 1065355
>>
>> URL: http://svn.apache.org/viewvc?rev=1065355&view=rev
>> Log:
>> XW-388 fix pattern to match relocation
>>
>> Modified:
>>    struts/struts2/trunk/xwork-core/pom.xml
>>
>> Modified: struts/struts2/trunk/xwork-core/pom.xml
>> URL: http://svn.apache.org/viewvc/struts/struts2/trunk/xwork-core/pom.xml?rev=1065355&r1=1065354&r2=1065355&view=diff
>> ==============================================================================
>> --- struts/struts2/trunk/xwork-core/pom.xml (original)
>> +++ struts/struts2/trunk/xwork-core/pom.xml Sun Jan 30 19:13:44 2011
>> @@ -219,7 +219,7 @@
>>                                     <shadedPattern>org.apache.commons.lang.xwork</shadedPattern>
>>                                 </relocation>
>>                                 <relocation>
>> -                                    <pattern>org.apache.commons.lang</pattern>
>> +                                    <pattern>org.apache.commons.io</pattern>
>>                                     <shadedPattern>org.apache.commons.io.xwork</shadedPattern>
>>                                 </relocation>
>>                             </relocations>
>>
>>
>>
>
>
>
> --
> Maurizio Cucchiara
>



--
Maurizio Cucchiara

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: svn commit: r1065355 - /struts/struts2/trunk/xwork-core/pom.xml

Posted by Maurizio Cucchiara <ma...@gmail.com>.
Probably it's the mess in my maven repository but every time I launch
the blank application with mvn jetty:run, I always get the following
error (could you check on your local repository, please?):

WARNING: Could not create JarEntryRevision for
[jar:file:/home/maurizio/.m2/repository/org/apache/struts/struts2-core/2.2.2-SNAPSHOT/struts2-core-2.2.2-SNAPSHOT.jar]!
java.lang.NoClassDefFoundError: org/apache/commons/io/xwork/FileExistsException
	at com.opensymphony.xwork2.util.FileManager$JarEntryRevision.build(FileManager.java:307)
	at com.opensymphony.xwork2.util.FileManager.loadFile(FileManager.java:145)
	at com.opensymphony.xwork2.util.FileManager.loadFile(FileManager.java:105)
	at com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.loadConfigurationFiles(XmlConfigurationProvider.java:898)
	at com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.loadDocuments(XmlConfigurationProvider.java:154)
	at com.opensymphony.xwork2.config.providers.XmlConfigurationProvider.init(XmlConfigurationProvider.java:121)
	at com.opensymphony.xwork2.config.impl.DefaultConfiguration.reloadContainer(DefaultConfiguration.java:179)
	at com.opensymphony.xwork2.config.ConfigurationManager.getConfiguration(ConfigurationManager.java:66)
	at org.apache.struts2.dispatcher.Dispatcher.init_PreloadConfiguration(Dispatcher.java:380)
	at org.apache.struts2.dispatcher.Dispatcher.init(Dispatcher.java:424)
	at org.apache.struts2.dispatcher.ng.InitOperations.initDispatcher(InitOperations.java:69)
	at org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter.init(StrutsPrepareAndExecuteFilter.java:51)
	at org.mortbay.jetty.servlet.FilterHolder.doStart(FilterHolder.java:95)
	at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
	at org.mortbay.jetty.servlet.ServletHandler.initialize(ServletHandler.java:545)
	at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1133)
	at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:420)
	at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:457)
	at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
	at org.mortbay.jetty.handler.HandlerCollection.doStart(HandlerCollection.java:156)
	at org.mortbay.jetty.handler.ContextHandlerCollection.doStart(ContextHandlerCollection.java:120)
	at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
	at org.mortbay.jetty.handler.HandlerCollection.doStart(HandlerCollection.java:156)
	at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
	at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:119)
	at org.mortbay.jetty.Server.doStart(Server.java:210)
	at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:38)
	at org.mortbay.jetty.plugin.Jetty6PluginServer.start(Jetty6PluginServer.java:134)
	at org.mortbay.jetty.plugin.AbstractJettyMojo.startJetty(AbstractJettyMojo.java:327)
	at org.mortbay.jetty.plugin.AbstractJettyMojo.execute(AbstractJettyMojo.java:272)
	at org.mortbay.jetty.plugin.AbstractJettyRunMojo.execute(AbstractJettyRunMojo.java:177)
	at org.mortbay.jetty.plugin.Jetty6RunMojo.execute(Jetty6RunMojo.java:183)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:107)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:195)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:140)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:316)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:153)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:451)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:188)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:134)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: java.lang.ClassNotFoundException:
org.apache.commons.io.xwork.FileExistsException
	at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
	at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:244)
	at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:230)
	at org.mortbay.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:358)
	at org.mortbay.jetty.webapp.WebAppClassLoader.loadClass(WebAppClassLoader.java:320)
	... 53 more


On 1 February 2011 05:29, Maurizio Cucchiara
<ma...@gmail.com> wrote:
> Have you tried to launch the struts blank application after this change?
> FileUtils depends on a lot of other io classes,  when you shade it
> xwork starts to looking for other resources along the
> org/apache/commons/io/xwork/
> path.
>
> On 30 January 2011 20:13,  <ja...@apache.org> wrote:
>> Author: jafl
>> Date: Sun Jan 30 19:13:44 2011
>> New Revision: 1065355
>>
>> URL: http://svn.apache.org/viewvc?rev=1065355&view=rev
>> Log:
>> XW-388 fix pattern to match relocation
>>
>> Modified:
>>    struts/struts2/trunk/xwork-core/pom.xml
>>
>> Modified: struts/struts2/trunk/xwork-core/pom.xml
>> URL: http://svn.apache.org/viewvc/struts/struts2/trunk/xwork-core/pom.xml?rev=1065355&r1=1065354&r2=1065355&view=diff
>> ==============================================================================
>> --- struts/struts2/trunk/xwork-core/pom.xml (original)
>> +++ struts/struts2/trunk/xwork-core/pom.xml Sun Jan 30 19:13:44 2011
>> @@ -219,7 +219,7 @@
>>                                     <shadedPattern>org.apache.commons.lang.xwork</shadedPattern>
>>                                 </relocation>
>>                                 <relocation>
>> -                                    <pattern>org.apache.commons.lang</pattern>
>> +                                    <pattern>org.apache.commons.io</pattern>
>>                                     <shadedPattern>org.apache.commons.io.xwork</shadedPattern>
>>                                 </relocation>
>>                             </relocations>
>>
>>
>>
>
>
>
> --
> Maurizio Cucchiara
>



-- 
Maurizio Cucchiara

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org