You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2021/03/24 23:33:59 UTC

[Impala-ASF-CR] IMPALA-10606: Simplify impala-python virtualenv bootstrapping

Joe McDonnell has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17226 )

Change subject: IMPALA-10606: Simplify impala-python virtualenv bootstrapping
......................................................................

IMPALA-10606: Simplify impala-python virtualenv bootstrapping

Bootstrapping the impala-python virtualenv requires multiple
rounds of pip installs with different sets of requirements.
This consolidates the requirements.txt, stage2-requirements.txt,
and compiled-requirements.txt into a single requirements.txt.
This will make it easier to upgrade python packages.

This also splits out setuptools into its own
setuptools-requirements.txt. Setuptools is used during the
pip install for several of the dependencies. Recent versions
of setuptools do not support Python 2, but some of the install
tools (like easy_install) don't know how to pick a version
of setuptools that works with Python 2. Splitting it out to its
own requirements file lets us pin the version.

To make review easier, this does not change any of the versions
of the dependencies. It also leaves the stage2-requirements.txt
and compiled-requirements.txt split out in separate sections
of requirements.txt. These will later be turned into a single
alphabetical list.

Testing:
 - Tested impala-python locally
 - Ran GVO

Change-Id: I8e920e5a257f1e0613065685078624a50d59bf2e
---
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/pip_download.py
M infra/python/deps/requirements.txt
R infra/python/deps/setuptools-requirements.txt
D infra/python/deps/stage2-requirements.txt
5 files changed, 82 insertions(+), 119 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/17226/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e920e5a257f1e0613065685078624a50d59bf2e
Gerrit-Change-Number: 17226
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>