You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/26 19:44:09 UTC

[GitHub] [druid] egor-ryashin opened a new pull request #10086: ui: fixes missing columns during Transform step

egor-ryashin opened a new pull request #10086:
URL: https://github.com/apache/druid/pull/10086


   
   
   
   
   ### Description
   
   Fixes missing columns with float type data during the Transform step in Druid UI.
   
   
   
   
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] been tested in a test Druid cluster.
   
   
   <hr>
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] clintropolis commented on pull request #10086: ui: fixes missing columns during Transform step

Posted by GitBox <gi...@apache.org>.
clintropolis commented on pull request #10086:
URL: https://github.com/apache/druid/pull/10086#issuecomment-655165133


   >Or right! Thanks for the clarity @clintropolis ! @egor-ryashin could you please add a ...
   
   Since this PR fixes a bug I'm going to go ahead and merge it, this change can be done in a follow-up.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] clintropolis merged pull request #10086: ui: fixes missing columns during Transform step

Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #10086:
URL: https://github.com/apache/druid/pull/10086


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] clintropolis commented on pull request #10086: ui: fixes missing columns during Transform step

Posted by GitBox <gi...@apache.org>.
clintropolis commented on pull request #10086:
URL: https://github.com/apache/druid/pull/10086#issuecomment-651532592


   >The changes you are suggesting looks good: use double instead of float and fix a typo in a function name but how does that address "fixes missing columns during Transform step"? what missing columns?
   
   I think the change is to match the case statement here: https://github.com/apache/druid/blob/02c1beb6ab43896744c02ff38bae124c6551f404/web-console/src/utils/druid-type.ts#L71
   
   which calls the changed method, but 'float' matches nothing so would be lost. Technically there are both float and a double sum aggs, but I'm not sure how you would distinguish between which to use so using 'double' is probably better.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] vogievetsky commented on pull request #10086: ui: fixes missing columns during Transform step

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #10086:
URL: https://github.com/apache/druid/pull/10086#issuecomment-651519660


   The changes you are suggesting looks good: use `double` instead of `float` and fix a typo in a function name but how does that address "fixes missing columns during Transform step"? what missing columns?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org