You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2020/05/06 12:36:03 UTC

[Impala-ASF-CR] IMPALA-9570: [DOCS] add memory management

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15836 )

Change subject: IMPALA-9570: [DOCS] add memory management
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15836/1/docs/topics/impala_udf.xml
File docs/topics/impala_udf.xml:

http://gerrit.cloudera.org:8080/#/c/15836/1/docs/topics/impala_udf.xml@926
PS1, Line 926: serialize, finalize or getValue
Let's use the same words as the code comments: "Serialize(), Finalize() or GetValue()", because there are no "getValue" function mentioned above.


http://gerrit.cloudera.org:8080/#/c/15836/1/docs/topics/impala_udf.xml@927
PS1, Line 927: ctor
Let's use the full word, "constructor", instead.



-- 
To view, visit http://gerrit.cloudera.org:8080/15836
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8b6d0c3fe2e1746831665b3d3ae98a0beaa1e7
Gerrit-Change-Number: 15836
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 06 May 2020 12:36:03 +0000
Gerrit-HasComments: Yes