You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/27 00:39:42 UTC
[GitHub] [pulsar] lhotari opened a new pull request #9746: [Broker/Proxy] Prevent invalid broker or proxy configuration for authorization
lhotari opened a new pull request #9746:
URL: https://github.com/apache/pulsar/pull/9746
Fixes #9709
### Motivation
Enabling authorization without enabling authentication leads to inconsistent behavior.
In some parts of the code, authorization is enforced only when both authorization is enabled and authentication is enabled. In a few places, it's enforced if authorization is enabled without checking for authentication.
To prevent misleading behavior, it's better to check at startup time that authentication is enabled when authorization is enabled.
### Modifications
- check the configuration before starting the Pulsar broker or Pulsar proxy
- fix AuthorizationTest where authentication configuration was missing
- add the necessary authentication configuration for the test
### About the fix to flaky test AuthorizationTest.simple
This change fixes the flaky test #9709, but it remains unclear why the test was passing in some cases.
It seems that the test is picking up state from some other test run. There are interesting observations in PR #9740 about the reasons why it passes in some cases.
Some effort was put into checking if the usage of [Jersey / JAX RS `@Context` annotation](https://eclipse-ee4j.github.io/jersey.github.io/documentation/latest/jaxrs-resources.html#d0e2871) on the PulsarWebResource's httpRequest field could be causing some concurrency issue, but that verification didn't reveal issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #9746: [Broker/Proxy] Prevent invalid broker or proxy configuration for authorization
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #9746:
URL: https://github.com/apache/pulsar/pull/9746#issuecomment-788137093
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #9746: [Broker/Proxy] Prevent invalid broker or proxy configuration for authorization
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #9746:
URL: https://github.com/apache/pulsar/pull/9746#issuecomment-790930719
I'll check the test failures tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #9746: [Broker/Proxy] Prevent invalid broker or proxy configuration for authorization
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #9746:
URL: https://github.com/apache/pulsar/pull/9746#issuecomment-791389213
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #9746: [Broker/Proxy] Prevent invalid broker or proxy configuration for authorization
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #9746:
URL: https://github.com/apache/pulsar/pull/9746#issuecomment-789682057
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #9746: [Broker/Proxy] Prevent invalid broker or proxy configuration for authorization
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #9746:
URL: https://github.com/apache/pulsar/pull/9746#issuecomment-791538159
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on pull request #9746: [Broker/Proxy] Prevent invalid broker or proxy configuration for authorization
Posted by GitBox <gi...@apache.org>.
315157973 commented on pull request #9746:
URL: https://github.com/apache/pulsar/pull/9746#issuecomment-787616861
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #9746: [Broker/Proxy] Prevent invalid broker or proxy configuration for authorization
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #9746:
URL: https://github.com/apache/pulsar/pull/9746
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org