You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2024/01/16 07:22:18 UTC
[PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
yiguolei opened a new pull request, #30021:
URL: https://github.com/apache/doris/pull/30021
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1895364404
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1894766145
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1893199908
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1895960729
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1894846815
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1895456851
TeamCity be ut coverage result:
Function Coverage: 36.69% (8646/23568)
Line Coverage: 28.73% (70618/245799)
Region Coverage: 27.62% (36431/131889)
Branch Coverage: 24.34% (18638/76570)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b57317ab108e0a2c505929a8af04fc6dc9f380b8_b57317ab108e0a2c505929a8af04fc6dc9f380b8/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1893947437
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1894883875
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1893287045
TeamCity be ut coverage result:
Function Coverage: 36.67% (8645/23573)
Line Coverage: 28.69% (70454/245529)
Region Coverage: 27.62% (36420/131864)
Branch Coverage: 24.33% (18629/76566)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a41cce137fbfb605c65ef3824f6838595b41ec63_a41cce137fbfb605c65ef3824f6838595b41ec63/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1895576778
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1896286013
TeamCity be ut coverage result:
Function Coverage: 36.67% (8646/23581)
Line Coverage: 28.73% (70619/245785)
Region Coverage: 27.63% (36436/131878)
Branch Coverage: 24.34% (18642/76580)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2a43553f71759a6a126cb1b1788c5b9845a20466_2a43553f71759a6a126cb1b1788c5b9845a20466/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1894901611
<details>
<summary>TPC-H: <b>Total hot run time: 38928 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3cf146ef114038b5297743f0ccfa3488c358614b, data reload: false
------ Round 1 ----------------------------------
q1 17707 5602 5232 5232
q2 2037 144 130 130
q3 10772 1154 1160 1154
q4 10351 767 806 767
q5 7723 3171 3184 3171
q6 199 120 121 120
q7 864 498 480 480
q8 9229 1924 1954 1924
q9 7237 6361 6336 6336
q10 8192 3021 3009 3009
q11 407 219 213 213
q12 363 190 193 190
q13 17988 3390 3353 3353
q14 244 217 207 207
q15 547 513 515 513
q16 431 387 374 374
q17 941 569 517 517
q18 7398 6924 6831 6831
q19 1570 1381 1386 1381
q20 606 316 287 287
q21 2780 2428 2465 2428
q22 372 313 311 311
Total cold run time: 107958 ms
Total hot run time: 38928 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5270 5239 5384 5239
q2 325 221 208 208
q3 3334 3246 3224 3224
q4 2077 2057 2019 2019
q5 6091 5917 5928 5917
q6 195 113 119 113
q7 2262 1920 1894 1894
q8 3246 3399 3396 3396
q9 8945 8795 8978 8795
q10 5105 3801 3850 3801
q11 708 463 454 454
q12 799 599 639 599
q13 17542 3237 3198 3198
q14 286 267 266 266
q15 572 517 505 505
q16 514 490 500 490
q17 1866 1896 1865 1865
q18 9727 11094 9684 9684
q19 24009 1638 1568 1568
q20 5276 2045 2004 2004
q21 16457 5633 5655 5633
q22 3038 677 626 626
Total cold run time: 117644 ms
Total hot run time: 61498 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #30021:
URL: https://github.com/apache/doris/pull/30021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1895652037
TeamCity be ut coverage result:
Function Coverage: 36.67% (8643/23568)
Line Coverage: 28.72% (70592/245813)
Region Coverage: 27.61% (36410/131891)
Branch Coverage: 24.33% (18630/76572)
Coverage Report: http://coverage.selectdb-in.cc/coverage/034b7fcd95b282db8e87ea48710cd93387c61b2d_034b7fcd95b282db8e87ea48710cd93387c61b2d/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1895676289
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 034b7fcd95b282db8e87ea48710cd93387c61b2d with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 14.8 seconds inserted 10000000 Rows, about 675K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1896201424
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1893461559
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1894027182
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1894913154
<details>
<summary>ClickBench: <b>Total hot run time: 31.09 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3cf146ef114038b5297743f0ccfa3488c358614b, data reload: false
query1 0.03 0.03 0.03
query2 0.06 0.02 0.02
query3 0.22 0.05 0.05
query4 1.70 0.06 0.06
query5 0.53 0.51 0.52
query6 1.26 0.63 0.63
query7 0.02 0.01 0.01
query8 0.04 0.02 0.03
query9 0.54 0.50 0.49
query10 0.56 0.57 0.54
query11 0.12 0.08 0.09
query12 0.12 0.10 0.09
query13 0.61 0.60 0.61
query14 0.78 0.77 0.79
query15 0.78 0.78 0.76
query16 0.39 0.38 0.36
query17 1.02 0.99 1.02
query18 0.25 0.26 0.23
query19 1.86 1.78 1.79
query20 0.01 0.02 0.02
query21 15.40 0.58 0.58
query22 2.30 2.17 2.28
query23 17.22 0.90 0.75
query24 2.54 1.38 0.92
query25 0.38 0.26 0.15
query26 0.48 0.14 0.13
query27 0.05 0.05 0.05
query28 11.47 0.77 0.76
query29 12.52 3.24 3.18
query30 0.55 0.53 0.51
query31 2.78 0.33 0.34
query32 3.38 0.48 0.48
query33 3.21 3.28 3.26
query34 15.82 4.27 4.22
query35 4.26 4.24 4.24
query36 1.13 1.06 1.08
query37 0.06 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.01 0.02
query40 0.16 0.13 0.13
query41 0.07 0.01 0.02
query42 0.02 0.02 0.02
query43 0.02 0.02 0.01
Total cold run time: 104.78 s
Total hot run time: 31.09 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1896302161
<details>
<summary>TPC-DS: <b>Total hot run time: 176759 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2a43553f71759a6a126cb1b1788c5b9845a20466, data reload: false
query1 937 334 334 334
query2 6549 2045 1862 1862
query3 6716 205 201 201
query4 32816 22249 22268 22249
query5 6925 600 597 597
query6 262 169 169 169
query7 4602 260 271 260
query8 221 166 175 166
query9 8373 2569 2558 2558
query10 422 231 235 231
query11 16670 15494 15591 15494
query12 118 68 68 68
query13 1709 387 383 383
query14 10453 6855 6959 6855
query15 206 181 184 181
query16 4611 247 230 230
query17 998 486 487 486
query18 1782 263 248 248
query19 168 134 132 132
query20 70 74 66 66
query21 184 129 132 129
query22 4829 4774 4836 4774
query23 31564 30944 30798 30798
query24 12526 2790 2817 2790
query25 553 313 294 294
query26 1816 136 134 134
query27 3239 269 272 269
query28 7329 1842 1836 1836
query29 2114 644 630 630
query30 288 139 137 137
query31 960 751 742 742
query32 87 51 49 49
query33 709 208 208 208
query34 1176 463 464 463
query35 874 754 765 754
query36 1324 1164 1215 1164
query37 179 57 60 57
query38 3357 3245 3184 3184
query39 1304 1251 1280 1251
query40 349 90 83 83
query41 36 36 36 36
query42 104 79 85 79
query43 523 502 500 500
query44 1062 693 711 693
query45 194 177 178 177
query46 1066 655 653 653
query47 1636 1615 1519 1519
query48 396 322 304 304
query49 1225 285 280 280
query50 693 312 317 312
query51 5325 5220 5218 5218
query52 95 75 84 75
query53 320 273 250 250
query54 885 439 446 439
query55 81 73 76 73
query56 170 157 163 157
query57 978 937 928 928
query58 191 157 161 157
query59 3007 2742 2595 2595
query60 213 188 187 187
query61 87 83 81 81
query62 608 362 354 354
query63 298 255 252 252
query64 6164 1766 1748 1748
query65 3355 3264 3254 3254
query66 1436 331 311 311
query67 15353 15484 14853 14853
query68 11577 545 509 509
query69 618 296 301 296
query70 1651 1519 1526 1519
query71 574 204 204 204
query72 4952 2813 2830 2813
query73 2250 317 311 311
query74 7007 6391 6421 6391
query75 5108 2264 2302 2264
query76 6252 1042 956 956
query77 870 235 238 235
query78 9005 8698 8681 8681
query79 1013 501 503 501
query80 618 315 307 307
query81 451 221 211 211
query82 203 80 80 80
query83 135 118 118 118
query84 281 71 68 68
query85 1049 331 321 321
query86 385 416 403 403
query87 3602 3375 3393 3375
query88 3066 2145 2158 2145
query89 417 347 364 347
query90 2097 184 186 184
query91 154 133 133 133
query92 52 42 43 42
query93 1396 428 423 423
query94 1253 155 154 154
query95 503 457 450 450
query96 611 310 321 310
query97 4231 4150 4163 4150
query98 215 196 179 179
query99 1086 726 678 678
Total cold run time: 297552 ms
Total hot run time: 176759 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1893416718
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1895662610
<details>
<summary>TPC-DS: <b>Total hot run time: 177499 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 034b7fcd95b282db8e87ea48710cd93387c61b2d, data reload: false
query1 925 332 329 329
query2 6563 1918 1852 1852
query3 6698 201 201 201
query4 35833 22287 22320 22287
query5 6872 525 515 515
query6 254 165 167 165
query7 4595 269 259 259
query8 227 174 180 174
query9 8374 2547 2532 2532
query10 411 235 241 235
query11 16741 15591 15484 15484
query12 119 71 68 68
query13 1690 385 384 384
query14 10460 6907 6957 6907
query15 204 180 180 180
query16 4606 238 225 225
query17 994 488 481 481
query18 1793 269 255 255
query19 171 142 134 134
query20 70 67 66 66
query21 194 136 136 136
query22 4893 4770 4715 4715
query23 31727 30791 30776 30776
query24 12568 2883 2801 2801
query25 567 301 301 301
query26 1832 140 143 140
query27 3218 273 266 266
query28 7224 1834 1816 1816
query29 2172 617 643 617
query30 278 142 138 138
query31 936 758 759 758
query32 77 51 47 47
query33 705 217 215 215
query34 1154 468 464 464
query35 877 778 788 778
query36 1401 1276 1307 1276
query37 176 56 58 56
query38 3304 3213 3237 3213
query39 1317 1270 1258 1258
query40 341 89 85 85
query41 36 37 35 35
query42 96 79 84 79
query43 549 444 490 444
query44 1083 697 696 696
query45 199 189 178 178
query46 1067 658 641 641
query47 1692 1555 1634 1555
query48 410 318 323 318
query49 1215 285 278 278
query50 674 312 303 303
query51 5379 5223 5191 5191
query52 84 75 78 75
query53 324 252 253 252
query54 896 454 449 449
query55 85 72 76 72
query56 177 172 167 167
query57 1044 960 962 960
query58 204 165 160 160
query59 2916 2766 2697 2697
query60 212 186 185 185
query61 85 82 88 82
query62 660 388 392 388
query63 273 253 259 253
query64 6128 1773 1742 1742
query65 3341 3244 3266 3244
query66 1433 321 315 315
query67 15558 15295 15386 15295
query68 9883 548 531 531
query69 603 310 309 309
query70 1797 1568 1538 1538
query71 539 214 210 210
query72 4368 2809 2863 2809
query73 1988 310 311 310
query74 7090 6368 6438 6368
query75 4745 2344 2270 2270
query76 6016 1044 1000 1000
query77 851 241 235 235
query78 9267 8851 8770 8770
query79 1013 494 510 494
query80 741 319 318 318
query81 462 210 209 209
query82 222 82 82 82
query83 166 117 120 117
query84 281 72 67 67
query85 1118 317 323 317
query86 400 375 392 375
query87 3566 3333 3367 3333
query88 3316 2156 2142 2142
query89 438 349 347 347
query90 2135 186 181 181
query91 166 121 123 121
query92 52 43 43 43
query93 2550 423 450 423
query94 1258 158 156 156
query95 512 459 453 453
query96 625 316 317 316
query97 4288 4141 4176 4141
query98 222 185 179 179
query99 1081 692 720 692
Total cold run time: 300140 ms
Total hot run time: 177499 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1895671143
<details>
<summary>ClickBench: <b>Total hot run time: 31.17 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 034b7fcd95b282db8e87ea48710cd93387c61b2d, data reload: false
query1 0.03 0.02 0.02
query2 0.06 0.02 0.02
query3 0.23 0.05 0.05
query4 1.72 0.06 0.06
query5 0.53 0.52 0.52
query6 1.29 0.63 0.65
query7 0.02 0.01 0.01
query8 0.04 0.02 0.03
query9 0.53 0.50 0.49
query10 0.56 0.57 0.55
query11 0.12 0.09 0.09
query12 0.11 0.09 0.09
query13 0.59 0.60 0.60
query14 0.74 0.80 0.80
query15 0.81 0.78 0.78
query16 0.37 0.36 0.38
query17 1.00 1.04 1.05
query18 0.24 0.24 0.25
query19 1.79 1.75 1.81
query20 0.02 0.01 0.01
query21 15.45 0.59 0.58
query22 2.64 2.29 2.16
query23 17.15 0.79 0.91
query24 3.05 1.03 1.29
query25 0.46 0.18 0.15
query26 0.55 0.13 0.14
query27 0.05 0.06 0.06
query28 11.11 0.77 0.77
query29 12.51 3.16 3.26
query30 0.56 0.50 0.47
query31 2.77 0.35 0.34
query32 3.37 0.48 0.48
query33 3.24 3.18 3.26
query34 15.90 4.25 4.22
query35 4.21 4.17 4.25
query36 1.10 1.08 1.09
query37 0.07 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.02 0.02
query40 0.16 0.13 0.13
query41 0.07 0.02 0.01
query42 0.02 0.01 0.02
query43 0.03 0.02 0.02
Total cold run time: 105.33 s
Total hot run time: 31.17 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1893243597
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1895645019
<details>
<summary>TPC-H: <b>Total hot run time: 39156 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 034b7fcd95b282db8e87ea48710cd93387c61b2d, data reload: false
------ Round 1 ----------------------------------
q1 17712 5393 5339 5339
q2 2730 158 144 144
q3 11237 1199 1198 1198
q4 10861 824 830 824
q5 7791 3240 3190 3190
q6 196 120 124 120
q7 868 507 492 492
q8 9213 1965 1968 1965
q9 7300 6457 6380 6380
q10 8182 3097 3011 3011
q11 424 203 211 203
q12 355 191 191 191
q13 17991 3372 3343 3343
q14 250 204 217 204
q15 531 546 503 503
q16 437 375 389 375
q17 949 546 487 487
q18 7607 7146 6799 6799
q19 1556 1375 1400 1375
q20 583 297 326 297
q21 2740 2416 2435 2416
q22 375 310 300 300
Total cold run time: 109888 ms
Total hot run time: 39156 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5430 5448 5256 5256
q2 330 222 216 216
q3 3374 3208 3212 3208
q4 2069 2059 2047 2047
q5 5997 5952 5985 5952
q6 201 117 121 117
q7 2349 1928 1871 1871
q8 3243 3389 3392 3389
q9 8940 8902 8999 8902
q10 3966 3899 3847 3847
q11 545 472 443 443
q12 806 669 615 615
q13 16935 3132 3144 3132
q14 292 256 277 256
q15 558 503 505 503
q16 513 468 494 468
q17 3804 1822 1830 1822
q18 9612 18223 9604 9604
q19 22823 1569 1502 1502
q20 4600 1926 1937 1926
q21 14420 5310 5284 5284
q22 968 510 569 510
Total cold run time: 111775 ms
Total hot run time: 60870 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1894034039
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1894046818
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1895945412
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1896311530
<details>
<summary>ClickBench: <b>Total hot run time: 30.6 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2a43553f71759a6a126cb1b1788c5b9845a20466, data reload: false
query1 0.03 0.03 0.02
query2 0.06 0.03 0.02
query3 0.22 0.05 0.05
query4 1.66 0.07 0.07
query5 0.55 0.53 0.52
query6 1.29 0.62 0.65
query7 0.02 0.01 0.01
query8 0.04 0.02 0.02
query9 0.52 0.49 0.51
query10 0.56 0.56 0.57
query11 0.11 0.09 0.08
query12 0.11 0.10 0.09
query13 0.61 0.60 0.59
query14 0.76 0.78 0.80
query15 0.79 0.78 0.77
query16 0.39 0.37 0.38
query17 0.98 1.03 1.04
query18 0.23 0.25 0.26
query19 1.85 1.76 1.77
query20 0.01 0.00 0.01
query21 15.41 0.59 0.57
query22 2.55 3.18 1.93
query23 17.21 0.87 0.81
query24 2.71 0.58 0.99
query25 0.36 0.24 0.17
query26 0.43 0.14 0.14
query27 0.07 0.06 0.06
query28 11.34 0.77 0.77
query29 12.52 3.27 3.23
query30 0.53 0.52 0.47
query31 2.79 0.34 0.35
query32 3.38 0.49 0.49
query33 3.21 3.23 3.23
query34 16.02 4.28 4.18
query35 4.27 4.29 4.20
query36 1.10 1.08 1.07
query37 0.07 0.04 0.04
query38 0.04 0.03 0.03
query39 0.02 0.02 0.02
query40 0.16 0.13 0.12
query41 0.08 0.02 0.02
query42 0.03 0.02 0.01
query43 0.02 0.02 0.02
Total cold run time: 105.11 s
Total hot run time: 30.6 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1898756066
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1894039532
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1896039503
<details>
<summary>TPC-DS: <b>Total hot run time: 176261 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3cf146ef114038b5297743f0ccfa3488c358614b, data reload: false
query1 934 325 329 325
query2 6584 1902 1794 1794
query3 6725 201 192 192
query4 33743 22102 22012 22012
query5 6915 604 529 529
query6 260 164 167 164
query7 4665 267 260 260
query8 217 177 178 177
query9 8408 2589 2563 2563
query10 418 227 217 217
query11 16959 15487 15417 15417
query12 117 71 68 68
query13 1683 382 381 381
query14 10612 6932 6868 6868
query15 214 178 180 178
query16 4592 233 225 225
query17 998 482 467 467
query18 1789 254 255 254
query19 170 131 135 131
query20 74 75 67 67
query21 190 121 129 121
query22 4875 4842 4758 4758
query23 31571 30817 30784 30784
query24 12662 2865 2774 2774
query25 564 308 303 303
query26 1814 142 141 141
query27 3238 270 280 270
query28 7236 1845 1820 1820
query29 2196 636 639 636
query30 279 132 143 132
query31 938 737 749 737
query32 74 50 50 50
query33 713 220 211 211
query34 1152 460 451 451
query35 908 805 759 759
query36 1350 1222 1179 1179
query37 175 60 59 59
query38 3383 3199 3195 3195
query39 1319 1264 1278 1264
query40 344 90 84 84
query41 39 36 35 35
query42 94 84 82 82
query43 539 500 470 470
query44 1047 682 704 682
query45 191 180 177 177
query46 1048 645 654 645
query47 1677 1542 1529 1529
query48 394 331 319 319
query49 1222 290 280 280
query50 686 302 304 302
query51 5390 5200 5185 5185
query52 87 83 76 76
query53 336 253 262 253
query54 888 431 440 431
query55 80 79 77 77
query56 179 163 161 161
query57 1022 939 903 903
query58 190 162 161 161
query59 2793 2677 2637 2637
query60 211 181 185 181
query61 86 88 84 84
query62 614 360 367 360
query63 279 264 250 250
query64 6111 1734 1743 1734
query65 3352 3234 3241 3234
query66 1429 324 307 307
query67 15399 15017 15066 15017
query68 12978 537 510 510
query69 621 303 296 296
query70 1858 1470 1433 1433
query71 544 208 217 208
query72 4877 2799 2845 2799
query73 3443 322 317 317
query74 7075 6350 6503 6350
query75 5215 2346 2305 2305
query76 6178 1057 1023 1023
query77 681 230 243 230
query78 9065 8762 8880 8762
query79 1103 493 508 493
query80 519 319 318 318
query81 444 205 202 202
query82 201 83 83 83
query83 140 118 121 118
query84 278 68 70 68
query85 1063 317 319 317
query86 393 378 409 378
query87 3585 3394 3316 3316
query88 2832 2171 2153 2153
query89 422 335 339 335
query90 1990 190 180 180
query91 155 119 129 119
query92 51 45 45 45
query93 1354 460 454 454
query94 1136 154 157 154
query95 499 444 438 438
query96 610 317 316 316
query97 4256 4116 4128 4116
query98 214 195 181 181
query99 1019 689 655 655
Total cold run time: 301240 ms
Total hot run time: 176261 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #30021:
URL: https://github.com/apache/doris/pull/30021#discussion_r1454859322
##########
be/src/pipeline/task_scheduler.cpp:
##########
@@ -343,39 +349,20 @@ void TaskScheduler::_do_work(size_t index) {
}
}
-void TaskScheduler::_try_close_task(PipelineTask* task, PipelineTaskState state,
- Status exec_status) {
+void TaskScheduler::_close_task(PipelineTask* task, PipelineTaskState state, Status exec_status) {
Review Comment:
warning: method '_close_task' can be made static [readability-convert-member-functions-to-static]
be/src/pipeline/task_scheduler.h:106:
```diff
- void _close_task(PipelineTask* task, PipelineTaskState state,
+ static void _close_task(PipelineTask* task, PipelineTaskState state,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1896057637
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 3cf146ef114038b5297743f0ccfa3488c358614b with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 14.3 seconds inserted 10000000 Rows, about 699K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1896316158
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 2a43553f71759a6a126cb1b1788c5b9845a20466 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 14.1 seconds inserted 10000000 Rows, about 709K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1896051016
<details>
<summary>ClickBench: <b>Total hot run time: 30.3 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3cf146ef114038b5297743f0ccfa3488c358614b, data reload: false
query1 0.04 0.03 0.02
query2 0.06 0.02 0.02
query3 0.23 0.05 0.05
query4 1.70 0.06 0.06
query5 0.54 0.52 0.52
query6 1.26 0.64 0.65
query7 0.02 0.01 0.01
query8 0.05 0.03 0.02
query9 0.55 0.50 0.49
query10 0.55 0.54 0.56
query11 0.12 0.08 0.08
query12 0.11 0.10 0.09
query13 0.60 0.60 0.60
query14 0.74 0.78 0.77
query15 0.80 0.77 0.76
query16 0.38 0.38 0.35
query17 1.00 1.00 0.97
query18 0.22 0.25 0.24
query19 1.84 1.77 1.76
query20 0.02 0.01 0.01
query21 15.43 0.56 0.55
query22 2.60 2.89 1.82
query23 17.18 0.88 0.83
query24 2.41 0.89 0.64
query25 0.37 0.28 0.12
query26 0.52 0.14 0.13
query27 0.06 0.06 0.05
query28 12.16 0.77 0.76
query29 12.60 3.18 3.28
query30 0.59 0.47 0.47
query31 2.77 0.34 0.35
query32 3.38 0.48 0.47
query33 3.20 3.17 3.21
query34 16.41 4.28 4.26
query35 4.30 4.19 4.24
query36 1.10 1.06 1.06
query37 0.07 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.02 0.01
query40 0.16 0.13 0.14
query41 0.07 0.02 0.01
query42 0.03 0.01 0.02
query43 0.02 0.02 0.02
Total cold run time: 106.32 s
Total hot run time: 30.3 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "JackDrogon (via GitHub)" <gi...@apache.org>.
JackDrogon commented on code in PR #30021:
URL: https://github.com/apache/doris/pull/30021#discussion_r1453191932
##########
be/src/vec/sink/writer/vtablet_writer.h:
##########
@@ -562,6 +558,8 @@ class VTabletWriter final : public AsyncResultWriter {
Status _incremental_open_node_channel(const std::vector<TOlapTablePartition>& partitions);
+ void _do_try_close(RuntimeState* state, Status exec_status);
Review Comment:
exec_status don't need to be passed by value
##########
be/src/vec/sink/async_writer_sink.h:
##########
@@ -113,7 +113,7 @@ class AsyncWriterSink : public DataSink {
return Status::OK();
}
- bool is_close_done() override { return !_writer->is_pending_finish(); }
+ bool is_pending_finish() override { return _writer->is_pending_finish(); }
Review Comment:
mark as const & nodiscard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1896016025
<details>
<summary>TPC-H: <b>Total hot run time: 39070 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3cf146ef114038b5297743f0ccfa3488c358614b, data reload: false
------ Round 1 ----------------------------------
q1 17746 5400 5365 5365
q2 2861 147 133 133
q3 11168 1185 1182 1182
q4 10714 841 795 795
q5 7870 3243 3169 3169
q6 201 119 121 119
q7 865 500 476 476
q8 9241 1931 1971 1931
q9 7315 6408 6390 6390
q10 8207 3059 3058 3058
q11 409 214 196 196
q12 359 198 195 195
q13 17989 3344 3336 3336
q14 249 224 210 210
q15 541 505 507 505
q16 429 388 364 364
q17 940 557 481 481
q18 7546 6822 6763 6763
q19 1573 1401 1443 1401
q20 583 296 310 296
q21 2738 2398 2426 2398
q22 372 328 307 307
Total cold run time: 109916 ms
Total hot run time: 39070 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5493 5274 5295 5274
q2 327 219 208 208
q3 3361 3215 3224 3215
q4 2082 2108 2112 2108
q5 6055 5834 5947 5834
q6 193 120 115 115
q7 2358 1834 1934 1834
q8 3221 3373 3390 3373
q9 9025 8972 8764 8764
q10 3903 3766 3864 3766
q11 568 469 441 441
q12 827 612 617 612
q13 16940 3131 3096 3096
q14 283 259 265 259
q15 564 504 505 504
q16 519 487 483 483
q17 1885 1812 1849 1812
q18 9428 9502 8963 8963
q19 23722 1561 1552 1552
q20 4575 1963 1920 1920
q21 14177 5387 5337 5337
q22 965 554 547 547
Total cold run time: 110471 ms
Total hot run time: 60017 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1896017444
TeamCity be ut coverage result:
Function Coverage: 36.65% (8643/23582)
Line Coverage: 28.72% (70597/245807)
Region Coverage: 27.61% (36416/131894)
Branch Coverage: 24.33% (18633/76586)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3cf146ef114038b5297743f0ccfa3488c358614b_3cf146ef114038b5297743f0ccfa3488c358614b/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1896284835
<details>
<summary>TPC-H: <b>Total hot run time: 39371 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2a43553f71759a6a126cb1b1788c5b9845a20466, data reload: false
------ Round 1 ----------------------------------
q1 17772 5344 5340 5340
q2 2337 149 141 141
q3 11253 1200 1162 1162
q4 11977 777 869 777
q5 8210 3276 3274 3274
q6 205 123 125 123
q7 892 510 495 495
q8 9356 1961 1987 1961
q9 7279 6397 6387 6387
q10 8229 3109 3067 3067
q11 416 202 206 202
q12 353 192 191 191
q13 17990 3376 3371 3371
q14 246 219 224 219
q15 549 498 509 498
q16 445 409 389 389
q17 933 556 507 507
q18 7541 6901 6919 6901
q19 1561 1383 1411 1383
q20 604 312 309 309
q21 2806 2375 2448 2375
q22 358 316 299 299
Total cold run time: 111312 ms
Total hot run time: 39371 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5493 5215 5288 5215
q2 333 219 213 213
q3 3363 3268 3265 3265
q4 2121 2032 2062 2032
q5 6014 5914 5936 5914
q6 195 113 114 113
q7 2337 1932 1870 1870
q8 3239 3378 3405 3378
q9 9083 9270 8942 8942
q10 3944 3794 3806 3794
q11 553 459 453 453
q12 783 637 614 614
q13 16977 3178 3141 3141
q14 298 265 268 265
q15 570 511 503 503
q16 543 481 468 468
q17 1911 1872 1874 1872
q18 9542 17233 9464 9464
q19 22811 1613 1529 1529
q20 4629 1933 1948 1933
q21 14476 5331 5385 5331
q22 1008 558 579 558
Total cold run time: 110223 ms
Total hot run time: 60867 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1895951041
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](close) refactor ispendingfinish logic and close logic to do close more quickly [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1896218189
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1894879044
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1894903386
TeamCity be ut coverage result:
Function Coverage: 36.67% (8646/23577)
Line Coverage: 28.73% (70616/245794)
Region Coverage: 27.62% (36433/131914)
Branch Coverage: 24.34% (18643/76580)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3cf146ef114038b5297743f0ccfa3488c358614b_3cf146ef114038b5297743f0ccfa3488c358614b/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1894909492
<details>
<summary>TPC-DS: <b>Total hot run time: 177065 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3cf146ef114038b5297743f0ccfa3488c358614b, data reload: false
query1 926 336 327 327
query2 6560 1905 1865 1865
query3 6766 210 207 207
query4 30599 22079 22365 22079
query5 6875 544 604 544
query6 270 182 170 170
query7 4600 262 259 259
query8 230 176 181 176
query9 8418 2526 2511 2511
query10 429 253 232 232
query11 16596 15596 15471 15471
query12 114 71 64 64
query13 1693 375 378 375
query14 10514 6945 7067 6945
query15 216 185 181 181
query16 4600 248 228 228
query17 980 481 466 466
query18 1784 265 253 253
query19 173 136 138 136
query20 71 74 68 68
query21 186 140 132 132
query22 5018 4755 4777 4755
query23 31702 31027 30860 30860
query24 11812 2849 2798 2798
query25 567 314 315 314
query26 1415 140 139 139
query27 3095 272 274 272
query28 7136 1822 1808 1808
query29 1241 620 631 620
query30 276 135 137 135
query31 930 766 784 766
query32 86 53 49 49
query33 690 212 207 207
query34 1139 455 457 455
query35 912 797 772 772
query36 1296 1252 1335 1252
query37 97 61 61 61
query38 3351 3198 3226 3198
query39 1311 1275 1281 1275
query40 209 86 84 84
query41 37 35 35 35
query42 94 84 81 81
query43 551 493 522 493
query44 1083 683 681 681
query45 194 182 177 177
query46 1059 655 641 641
query47 1716 1597 1561 1561
query48 393 314 325 314
query49 1130 282 281 281
query50 686 316 316 316
query51 5381 5117 5169 5117
query52 85 87 77 77
query53 332 254 259 254
query54 885 432 443 432
query55 80 78 75 75
query56 175 163 167 163
query57 1004 956 948 948
query58 186 155 166 155
query59 2912 2873 2593 2593
query60 224 186 190 186
query61 84 80 88 80
query62 640 403 395 395
query63 275 263 257 257
query64 5010 1841 1793 1793
query65 3363 3266 3264 3264
query66 1230 325 313 313
query67 15571 14972 15008 14972
query68 12455 496 504 496
query69 619 303 300 300
query70 1700 1497 1489 1489
query71 556 217 212 212
query72 5672 2823 2815 2815
query73 2748 322 319 319
query74 7957 6448 6425 6425
query75 5208 2325 2346 2325
query76 6203 1023 996 996
query77 656 235 237 235
query78 9115 8685 8612 8612
query79 1148 512 515 512
query80 554 317 313 313
query81 471 203 210 203
query82 201 79 86 79
query83 145 121 121 121
query84 276 69 70 69
query85 1071 323 316 316
query86 382 379 363 363
query87 3554 3311 3324 3311
query88 3060 2262 2261 2261
query89 466 365 363 363
query90 1970 190 188 188
query91 151 121 118 118
query92 52 42 49 42
query93 1339 415 410 410
query94 1219 165 158 158
query95 502 459 455 455
query96 629 328 330 328
query97 4242 4149 4152 4149
query98 203 196 192 192
query99 1086 727 732 727
Total cold run time: 294873 ms
Total hot run time: 177065 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](asyncwriter) rename is close done to is pending finish [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30021:
URL: https://github.com/apache/doris/pull/30021#issuecomment-1894915301
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 3cf146ef114038b5297743f0ccfa3488c358614b with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 14.3 seconds inserted 10000000 Rows, about 699K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org