You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "arturobernalg (via GitHub)" <gi...@apache.org> on 2025/07/15 09:02:03 UTC
[PR] Deprecate setContentDecoderRegistry to populate contentDecoder [httpcomponents-client]
arturobernalg opened a new pull request, #675:
URL: https://github.com/apache/httpcomponents-client/pull/675
Adapt `InputStreamFactory` map into `contentDecoder` via `DecompressingEntity` adapters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] Deprecate setContentDecoderRegistry to populate contentDecoder [httpcomponents-client]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #675:
URL: https://github.com/apache/httpcomponents-client/pull/675#issuecomment-3078274722
@arturobernalg I would like to propose an alternative approach. Could you live with #678?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] Deprecate setContentDecoderRegistry to populate contentDecoder [httpcomponents-client]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #675:
URL: https://github.com/apache/httpcomponents-client/pull/675#issuecomment-3077967310
@arturobernalg I spotted another problem. The `LinkedHashMap<ContentCoding, UnaryOperator<HttpEntity>>` map used by `HttpClientBuilder` basically means one cannot plug-in 3rd party coders if they are not in present in `ContentCoding`. This is not good. The map should be `LinkedHashMap<String, UnaryOperator<HttpEntity>>`. This needs to be corrected first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] Deprecate setContentDecoderRegistry to populate contentDecoder [httpcomponents-client]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c closed pull request #675: Deprecate setContentDecoderRegistry to populate contentDecoder
URL: https://github.com/apache/httpcomponents-client/pull/675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] Deprecate setContentDecoderRegistry to populate contentDecoder [httpcomponents-client]
Posted by "arturobernalg (via GitHub)" <gi...@apache.org>.
arturobernalg commented on PR #675:
URL: https://github.com/apache/httpcomponents-client/pull/675#issuecomment-3078121854
> @arturobernalg I spotted another problem. The `LinkedHashMap<ContentCoding, UnaryOperator<HttpEntity>>` map used by `HttpClientBuilder` basically means one cannot plug-in 3rd party coders if they are not in present in `ContentCoding`. This is not good. The map should be `LinkedHashMap<String, UnaryOperator<HttpEntity>>`. This needs to be corrected first.
@ok2c I just made the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] Deprecate setContentDecoderRegistry to populate contentDecoder [httpcomponents-client]
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #675:
URL: https://github.com/apache/httpcomponents-client/pull/675#issuecomment-3078382706
Superseded by #678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org