You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/31 15:26:34 UTC

[GitHub] [maven-integration-testing] MartinKanters commented on pull request #87: [MNG-7051] Test activation of non-existing profiles

MartinKanters commented on pull request #87:
URL: https://github.com/apache/maven-integration-testing/pull/87#issuecomment-770399525


   > I wen't through all tests. While the actual test if fine, I am absolutely not convinced in the test copies because they are 95% identical. There are now two ways to solve it:
   > 
   > * Modify the existing ones like I proposed (did already in other commits)
   > * If you still think they need to be separate, move/copy them in the the new test class along with resources then you have a compled test set.
   
   Alright, I've merged them in the original tests. Still not a fan, but it turned out better than I imagined.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org