You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2021/02/02 23:20:42 UTC

[GitHub] [samza] ZitingShen opened a new pull request #1458: SAMZA-2563: Fix double counting of InMemoryKeyValueStore deletion

ZitingShen opened a new pull request #1458:
URL: https://github.com/apache/samza/pull/1458


   Symptom: Calling InMemoryKeyValueStore.delete will double count the deletes in metrics.
   
   Cause: InMemoryKeyValueStore.delete is implemented by calling InMemoryKeyValueStore.put with a null value. InMemoryKeyValueStore.delete explicitly increments the delete metric. InMemoryKeyValueStore.put also explicitly increments the delete metric when passed a null value.
   
   Changes: Remove incrementing the delete metric in InMemoryKeyValueStore.delete
   
   Test: unit tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] mynameborat merged pull request #1458: SAMZA-2563: Fix double counting of InMemoryKeyValueStore deletion

Posted by GitBox <gi...@apache.org>.

mynameborat merged pull request #1458:
URL: https://github.com/apache/samza/pull/1458


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org