You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by fm...@apache.org on 2026/03/31 09:53:37 UTC

(camel-spring-boot) branch main updated: Fix generator for java.time.Duration default values

This is an automated email from the ASF dual-hosted git repository.

fmariani pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-spring-boot.git


The following commit(s) were added to refs/heads/main by this push:
     new 383d9c4cb46 Fix generator for java.time.Duration default values
383d9c4cb46 is described below

commit 383d9c4cb4692009029e19163958ecb617a554cf
Author: Croway <fe...@gmail.com>
AuthorDate: Tue Mar 31 11:34:08 2026 +0200

    Fix generator for java.time.Duration default values
    
    The auto-configuration generator assumed duration-type properties
    always use long/int Java types. Properties with javaType
    java.time.Duration (e.g. embeddingStoreSchemaRegistrationTimeout
    from CAMEL-23255) got a bare int literal as initializer, causing
    a compilation error in the generated configuration class.
    
    Generate Duration.ofMillis(...) when the javaType is
    java.time.Duration.
---
 .../springboot/maven/SpringBootAutoConfigurationMojo.java      | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/tooling/camel-spring-boot-generator-maven-plugin/src/main/java/org/apache/camel/springboot/maven/SpringBootAutoConfigurationMojo.java b/tooling/camel-spring-boot-generator-maven-plugin/src/main/java/org/apache/camel/springboot/maven/SpringBootAutoConfigurationMojo.java
index 9c59316f33f..8ec7672b8c3 100644
--- a/tooling/camel-spring-boot-generator-maven-plugin/src/main/java/org/apache/camel/springboot/maven/SpringBootAutoConfigurationMojo.java
+++ b/tooling/camel-spring-boot-generator-maven-plugin/src/main/java/org/apache/camel/springboot/maven/SpringBootAutoConfigurationMojo.java
@@ -743,11 +743,15 @@ public class SpringBootAutoConfigurationMojo extends AbstractSpringBootGenerator
                     prop.getField().setStringInitializer(option.getDefaultValue().toString());
                 } else if ("duration".equals(option.getType())) {
                     String value = convertDurationToMills(option.getDefaultValue().toString());
-                    // duration is either long or int java type
-                    if ("long".equals(option.getJavaType()) || "java.lang.Long".equals(option.getJavaType())) {
+                    if ("java.time.Duration".equals(option.getJavaType())) {
+                        prop.getField().setLiteralInitializer("Duration.ofMillis(" + value + ")");
+                        javaClass.addImport("java.time.Duration");
+                    } else if ("long".equals(option.getJavaType()) || "java.lang.Long".equals(option.getJavaType())) {
                         value = value + "L";
+                        prop.getField().setLiteralInitializer(value);
+                    } else {
+                        prop.getField().setLiteralInitializer(value);
                     }
-                    prop.getField().setLiteralInitializer(value);
                 } else if ("long".equals(option.getJavaType()) || "java.lang.Long".equals(option.getJavaType())) {
                     // the value should be a Long number
                     String value = option.getDefaultValue() + "L";