You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/06/03 19:19:43 UTC

Re: Review Request 32365: Remove libprocess internal.hpp.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32365/
-----------------------------------------------------------

(Updated June 3, 2015, 5:19 p.m.)


Review request for mesos, Benjamin Hindman and Bernd Mathiske.


Bugs: MESOS-2805
    https://issues.apache.org/jira/browse/MESOS-2805


Repository: mesos


Description
-------

See Summary.


Diffs (updated)
-----

  3rdparty/libprocess/include/Makefile.am 8aab0593f296c7aae71289f9bd6cf3eb3578a721 
  3rdparty/libprocess/include/process/internal.hpp 78ee95dd66f0831e4d7861fd6f4da48e6a08ce2a 

Diff: https://reviews.apache.org/r/32365/diff/


Testing
-------

make check


Thanks,

Joris Van Remoortere


Re: Review Request 32365: Remove libprocess internal.hpp.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32365/#review86571
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On June 3, 2015, 5:19 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32365/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 5:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
> 
> 
> Bugs: MESOS-2805
>     https://issues.apache.org/jira/browse/MESOS-2805
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See Summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/Makefile.am 8aab0593f296c7aae71289f9bd6cf3eb3578a721 
>   3rdparty/libprocess/include/process/internal.hpp 78ee95dd66f0831e4d7861fd6f4da48e6a08ce2a 
> 
> Diff: https://reviews.apache.org/r/32365/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Re: Review Request 32365: Remove libprocess internal.hpp.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32365/#review86448
-----------------------------------------------------------


Patch looks great!

Reviews applied: [32356, 35012, 35013, 32358, 32360, 32361, 32362, 32363, 32364, 32365]

All tests passed.

- Mesos ReviewBot


On June 3, 2015, 5:19 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32365/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 5:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
> 
> 
> Bugs: MESOS-2805
>     https://issues.apache.org/jira/browse/MESOS-2805
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See Summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/Makefile.am 8aab0593f296c7aae71289f9bd6cf3eb3578a721 
>   3rdparty/libprocess/include/process/internal.hpp 78ee95dd66f0831e4d7861fd6f4da48e6a08ce2a 
> 
> Diff: https://reviews.apache.org/r/32365/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>