You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/09/09 16:20:58 UTC
Review Request 71457: Activated tests for `src/python/lib`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71457/
-----------------------------------------------------------
Review request for mesos, Armand Grillet, Benno Evers, and Kevin Klues.
Repository: mesos
Description
-------
This directory already had a tox config, but this setup was never
excercised automatically. This patch adds a test running `tox` for that
directory. We require `tox` to be present in the system and add
configure-time checks for that.
Diffs
-----
cmake/CompilationConfigure.cmake c8da0895d7e932b51b711be0bf28e01548b94bf6
configure.ac 1814bc67fd7c683285ed44d20273de02e7a6f251
src/CMakeLists.txt 0ec4442245f09afd6a8281f58a4a4d29c2216fe7
src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6
src/python/lib/CMakeLists.txt PRE-CREATION
Diff: https://reviews.apache.org/r/71457/diff/1/
Testing
-------
`make check` in both autotools & cmake build
Thanks,
Benjamin Bannier
Re: Review Request 71457: Activated tests for `src/python/lib`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71457/#review217672
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71457]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 9, 2019, 7:49 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71457/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2019, 7:49 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benno Evers, and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This directory already had a tox config, but this setup was never
> excercised automatically. This patch adds a test running `tox` for that
> directory. We require `tox` to be present in the system and add
> configure-time checks for that.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake c8da0895d7e932b51b711be0bf28e01548b94bf6
> configure.ac 1814bc67fd7c683285ed44d20273de02e7a6f251
> src/CMakeLists.txt 0ec4442245f09afd6a8281f58a4a4d29c2216fe7
> src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6
> src/python/lib/CMakeLists.txt PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71457/diff/5/
>
>
> Testing
> -------
>
> `make check` in both autotools & cmake build
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71457: Activated tests for `src/python/lib`.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71457/
-----------------------------------------------------------
(Updated Sept. 9, 2019, 7:49 p.m.)
Review request for mesos, Armand Grillet, Benno Evers, and Kevin Klues.
Changes
-------
Address more comments from Benno
Repository: mesos
Description
-------
This directory already had a tox config, but this setup was never
excercised automatically. This patch adds a test running `tox` for that
directory. We require `tox` to be present in the system and add
configure-time checks for that.
Diffs (updated)
-----
cmake/CompilationConfigure.cmake c8da0895d7e932b51b711be0bf28e01548b94bf6
configure.ac 1814bc67fd7c683285ed44d20273de02e7a6f251
src/CMakeLists.txt 0ec4442245f09afd6a8281f58a4a4d29c2216fe7
src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6
src/python/lib/CMakeLists.txt PRE-CREATION
Diff: https://reviews.apache.org/r/71457/diff/4/
Changes: https://reviews.apache.org/r/71457/diff/3-4/
Testing
-------
`make check` in both autotools & cmake build
Thanks,
Benjamin Bannier
Re: Review Request 71457: Activated tests for `src/python/lib`.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71457/#review217656
-----------------------------------------------------------
Fix it, then Ship it!
configure.ac
Lines 2505 (patched)
<https://reviews.apache.org/r/71457/#comment304942>
I think you have to quote `"x$tox"` to guard against whitespace inside the variable.
src/Makefile.am
Lines 2942 (patched)
<https://reviews.apache.org/r/71457/#comment304944>
Is it intentional that the autotools version specifies the directory but the cmake version specifices the location of `tox.ini`?
- Benno Evers
On Sept. 9, 2019, 4:34 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71457/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2019, 4:34 p.m.)
>
>
> Review request for mesos, Armand Grillet, Benno Evers, and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This directory already had a tox config, but this setup was never
> excercised automatically. This patch adds a test running `tox` for that
> directory. We require `tox` to be present in the system and add
> configure-time checks for that.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake c8da0895d7e932b51b711be0bf28e01548b94bf6
> configure.ac 1814bc67fd7c683285ed44d20273de02e7a6f251
> src/CMakeLists.txt 0ec4442245f09afd6a8281f58a4a4d29c2216fe7
> src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6
> src/python/lib/CMakeLists.txt PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/71457/diff/3/
>
>
> Testing
> -------
>
> `make check` in both autotools & cmake build
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71457: Activated tests for `src/python/lib`.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71457/
-----------------------------------------------------------
(Updated Sept. 9, 2019, 6:34 p.m.)
Review request for mesos, Armand Grillet, Benno Evers, and Kevin Klues.
Changes
-------
Address offline comments from Benno
Repository: mesos
Description
-------
This directory already had a tox config, but this setup was never
excercised automatically. This patch adds a test running `tox` for that
directory. We require `tox` to be present in the system and add
configure-time checks for that.
Diffs (updated)
-----
cmake/CompilationConfigure.cmake c8da0895d7e932b51b711be0bf28e01548b94bf6
configure.ac 1814bc67fd7c683285ed44d20273de02e7a6f251
src/CMakeLists.txt 0ec4442245f09afd6a8281f58a4a4d29c2216fe7
src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6
src/python/lib/CMakeLists.txt PRE-CREATION
Diff: https://reviews.apache.org/r/71457/diff/3/
Changes: https://reviews.apache.org/r/71457/diff/2-3/
Testing
-------
`make check` in both autotools & cmake build
Thanks,
Benjamin Bannier