You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2012/05/11 21:58:50 UTC
[jira] [Created] (HADOOP-8395) Text shell command unnecessarily
demands that a SequenceFile's key class be WritableComparable
Harsh J created HADOOP-8395:
-------------------------------
Summary: Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable
Key: HADOOP-8395
URL: https://issues.apache.org/jira/browse/HADOOP-8395
Project: Hadoop Common
Issue Type: Bug
Components: util
Affects Versions: 2.0.0
Reporter: Harsh J
Priority: Trivial
Text from Display set of Shell commands (hadoop fs -text), has a strict subclass check for a sequence-file-header loaded key class to be a subclass of WritableComparable.
The sequence file writer itself has no such checks (one can create sequence files with just plain writable keys, comparable is needed for sequence file's sorter alone, which not all of them use always), and hence its not reasonable for Text command to carry it either.
We should relax the check and simply just check for "Writable", not "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8395) Text shell command unnecessarily
demands that a SequenceFile's key class be WritableComparable
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-8395:
----------------------------
Attachment: HADOOP-8395.patch
> Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8395
> URL: https://issues.apache.org/jira/browse/HADOOP-8395
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Labels: shell
> Attachments: HADOOP-8395.patch
>
>
> Text from Display set of Shell commands (hadoop fs -text), has a strict subclass check for a sequence-file-header loaded key class to be a subclass of WritableComparable.
> The sequence file writer itself has no such checks (one can create sequence files with just plain writable keys, comparable is needed for sequence file's sorter alone, which not all of them use always), and hence its not reasonable for Text command to carry it either.
> We should relax the check and simply just check for "Writable", not "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8395) Text shell command unnecessarily
demands that a SequenceFile's key class be WritableComparable
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-8395:
----------------------------
Status: Patch Available (was: Open)
> Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8395
> URL: https://issues.apache.org/jira/browse/HADOOP-8395
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Labels: shell
> Attachments: HADOOP-8395.patch
>
>
> Text from Display set of Shell commands (hadoop fs -text), has a strict subclass check for a sequence-file-header loaded key class to be a subclass of WritableComparable.
> The sequence file writer itself has no such checks (one can create sequence files with just plain writable keys, comparable is needed for sequence file's sorter alone, which not all of them use always), and hence its not reasonable for Text command to carry it either.
> We should relax the check and simply just check for "Writable", not "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8395) Text shell command unnecessarily
demands that a SequenceFile's key class be WritableComparable
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273798#comment-13273798 ]
Todd Lipcon commented on HADOOP-8395:
-------------------------------------
Seems reasonable. +1 assuming you tested this manually.
> Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8395
> URL: https://issues.apache.org/jira/browse/HADOOP-8395
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Labels: shell
> Attachments: HADOOP-8395.patch
>
>
> Text from Display set of Shell commands (hadoop fs -text), has a strict subclass check for a sequence-file-header loaded key class to be a subclass of WritableComparable.
> The sequence file writer itself has no such checks (one can create sequence files with just plain writable keys, comparable is needed for sequence file's sorter alone, which not all of them use always), and hence its not reasonable for Text command to carry it either.
> We should relax the check and simply just check for "Writable", not "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8395) Text shell command unnecessarily
demands that a SequenceFile's key class be WritableComparable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274011#comment-13274011 ]
Hudson commented on HADOOP-8395:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1077 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1077/])
HADOOP-8395. Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable (harsh) (Revision 1337449)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337449
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Display.java
> Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8395
> URL: https://issues.apache.org/jira/browse/HADOOP-8395
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Labels: shell
> Fix For: 3.0.0
>
> Attachments: HADOOP-8395.patch
>
>
> Text from Display set of Shell commands (hadoop fs -text), has a strict subclass check for a sequence-file-header loaded key class to be a subclass of WritableComparable.
> The sequence file writer itself has no such checks (one can create sequence files with just plain writable keys, comparable is needed for sequence file's sorter alone, which not all of them use always), and hence its not reasonable for Text command to carry it either.
> We should relax the check and simply just check for "Writable", not "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-8395) Text shell command unnecessarily
demands that a SequenceFile's key class be WritableComparable
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J reassigned HADOOP-8395:
-------------------------------
Assignee: Harsh J
> Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8395
> URL: https://issues.apache.org/jira/browse/HADOOP-8395
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Labels: shell
>
> Text from Display set of Shell commands (hadoop fs -text), has a strict subclass check for a sequence-file-header loaded key class to be a subclass of WritableComparable.
> The sequence file writer itself has no such checks (one can create sequence files with just plain writable keys, comparable is needed for sequence file's sorter alone, which not all of them use always), and hence its not reasonable for Text command to carry it either.
> We should relax the check and simply just check for "Writable", not "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8395) Text shell command unnecessarily
demands that a SequenceFile's key class be WritableComparable
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273859#comment-13273859 ]
Harsh J commented on HADOOP-8395:
---------------------------------
Committed to trunk.
> Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8395
> URL: https://issues.apache.org/jira/browse/HADOOP-8395
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Labels: shell
> Fix For: 3.0.0
>
> Attachments: HADOOP-8395.patch
>
>
> Text from Display set of Shell commands (hadoop fs -text), has a strict subclass check for a sequence-file-header loaded key class to be a subclass of WritableComparable.
> The sequence file writer itself has no such checks (one can create sequence files with just plain writable keys, comparable is needed for sequence file's sorter alone, which not all of them use always), and hence its not reasonable for Text command to carry it either.
> We should relax the check and simply just check for "Writable", not "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8395) Text shell command unnecessarily
demands that a SequenceFile's key class be WritableComparable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273989#comment-13273989 ]
Hudson commented on HADOOP-8395:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1041 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1041/])
HADOOP-8395. Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable (harsh) (Revision 1337449)
Result = FAILURE
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337449
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Display.java
> Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8395
> URL: https://issues.apache.org/jira/browse/HADOOP-8395
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Labels: shell
> Fix For: 3.0.0
>
> Attachments: HADOOP-8395.patch
>
>
> Text from Display set of Shell commands (hadoop fs -text), has a strict subclass check for a sequence-file-header loaded key class to be a subclass of WritableComparable.
> The sequence file writer itself has no such checks (one can create sequence files with just plain writable keys, comparable is needed for sequence file's sorter alone, which not all of them use always), and hence its not reasonable for Text command to carry it either.
> We should relax the check and simply just check for "Writable", not "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8395) Text shell command unnecessarily
demands that a SequenceFile's key class be WritableComparable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273855#comment-13273855 ]
Hudson commented on HADOOP-8395:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2237 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2237/])
HADOOP-8395. Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable (harsh) (Revision 1337449)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337449
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Display.java
> Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8395
> URL: https://issues.apache.org/jira/browse/HADOOP-8395
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Labels: shell
> Fix For: 3.0.0
>
> Attachments: HADOOP-8395.patch
>
>
> Text from Display set of Shell commands (hadoop fs -text), has a strict subclass check for a sequence-file-header loaded key class to be a subclass of WritableComparable.
> The sequence file writer itself has no such checks (one can create sequence files with just plain writable keys, comparable is needed for sequence file's sorter alone, which not all of them use always), and hence its not reasonable for Text command to carry it either.
> We should relax the check and simply just check for "Writable", not "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8395) Text shell command unnecessarily
demands that a SequenceFile's key class be WritableComparable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273857#comment-13273857 ]
Hudson commented on HADOOP-8395:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2311 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2311/])
HADOOP-8395. Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable (harsh) (Revision 1337449)
Result = SUCCESS
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337449
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Display.java
> Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8395
> URL: https://issues.apache.org/jira/browse/HADOOP-8395
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Labels: shell
> Fix For: 3.0.0
>
> Attachments: HADOOP-8395.patch
>
>
> Text from Display set of Shell commands (hadoop fs -text), has a strict subclass check for a sequence-file-header loaded key class to be a subclass of WritableComparable.
> The sequence file writer itself has no such checks (one can create sequence files with just plain writable keys, comparable is needed for sequence file's sorter alone, which not all of them use always), and hence its not reasonable for Text command to carry it either.
> We should relax the check and simply just check for "Writable", not "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8395) Text shell command unnecessarily
demands that a SequenceFile's key class be WritableComparable
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273834#comment-13273834 ]
Harsh J commented on HADOOP-8395:
---------------------------------
Thanks for checking Todd.
Yes, I manually tested the Text command with these two types of files (one used a WritableComparable set, the other uses Writable sets), just to make sure the subclass checks don't break anything.
As WritableComparable subclasses Writable, this does not break anything, only relaxes the false requirement.
Committing to trunk shortly.
> Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8395
> URL: https://issues.apache.org/jira/browse/HADOOP-8395
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Labels: shell
> Attachments: HADOOP-8395.patch
>
>
> Text from Display set of Shell commands (hadoop fs -text), has a strict subclass check for a sequence-file-header loaded key class to be a subclass of WritableComparable.
> The sequence file writer itself has no such checks (one can create sequence files with just plain writable keys, comparable is needed for sequence file's sorter alone, which not all of them use always), and hence its not reasonable for Text command to carry it either.
> We should relax the check and simply just check for "Writable", not "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8395) Text shell command unnecessarily
demands that a SequenceFile's key class be WritableComparable
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-8395:
----------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Target Version/s: (was: 3.0.0)
Status: Resolved (was: Patch Available)
> Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8395
> URL: https://issues.apache.org/jira/browse/HADOOP-8395
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Labels: shell
> Fix For: 3.0.0
>
> Attachments: HADOOP-8395.patch
>
>
> Text from Display set of Shell commands (hadoop fs -text), has a strict subclass check for a sequence-file-header loaded key class to be a subclass of WritableComparable.
> The sequence file writer itself has no such checks (one can create sequence files with just plain writable keys, comparable is needed for sequence file's sorter alone, which not all of them use always), and hence its not reasonable for Text command to carry it either.
> We should relax the check and simply just check for "Writable", not "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8395) Text shell command unnecessarily
demands that a SequenceFile's key class be WritableComparable
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273579#comment-13273579 ]
Hadoop QA commented on HADOOP-8395:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12526563/HADOOP-8395.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/986//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/986//console
This message is automatically generated.
> Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8395
> URL: https://issues.apache.org/jira/browse/HADOOP-8395
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Labels: shell
> Attachments: HADOOP-8395.patch
>
>
> Text from Display set of Shell commands (hadoop fs -text), has a strict subclass check for a sequence-file-header loaded key class to be a subclass of WritableComparable.
> The sequence file writer itself has no such checks (one can create sequence files with just plain writable keys, comparable is needed for sequence file's sorter alone, which not all of them use always), and hence its not reasonable for Text command to carry it either.
> We should relax the check and simply just check for "Writable", not "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8395) Text shell command unnecessarily
demands that a SequenceFile's key class be WritableComparable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273869#comment-13273869 ]
Hudson commented on HADOOP-8395:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2254 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2254/])
HADOOP-8395. Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable (harsh) (Revision 1337449)
Result = ABORTED
harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1337449
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Display.java
> Text shell command unnecessarily demands that a SequenceFile's key class be WritableComparable
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-8395
> URL: https://issues.apache.org/jira/browse/HADOOP-8395
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Labels: shell
> Fix For: 3.0.0
>
> Attachments: HADOOP-8395.patch
>
>
> Text from Display set of Shell commands (hadoop fs -text), has a strict subclass check for a sequence-file-header loaded key class to be a subclass of WritableComparable.
> The sequence file writer itself has no such checks (one can create sequence files with just plain writable keys, comparable is needed for sequence file's sorter alone, which not all of them use always), and hence its not reasonable for Text command to carry it either.
> We should relax the check and simply just check for "Writable", not "WritableComparable".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira