You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/09/07 05:44:25 UTC
[GitHub] [incubator-echarts] 100pah opened a new pull request #13242: fix:
100pah opened a new pull request #13242:
URL: https://github.com/apache/incubator-echarts/pull/13242
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
fix:
+ Fix some buggy display result in tooltip, like 2 value axis scatter, add add test cases for them.
+ Buggy results in tooltip.renderModel: 'richText' for each cases. And add test cases for them.
+ Add styles to renderMode: 'richText', make them the same as renderMode: 'html'.
+ Make `tooltip.confine` default `true` if `tooltip.renderMode` is `richText`. And fix the positioning of it to avoid to overflow the container, which will be cut.
+ Fix the `tooltip.formatter` callback in `renderMode: 'richText'`, previously the concatenating rich text by `params.marker.content` does not work.
```ts
formatter: function (params) {
return params.map(param => param.marker.content + param.name + param.value);
}
```
+ Refactor the implementation of `Series['formatTooltip']`:
Add a abstract layer named `TooltipMarkup` (see `tooltipMarkup.ts`) to describe the tooltip layout requirements for each series,
instead of lots of messy code to concatenate `html` and `richText` in each series.
`TooltipMarkup` is responsible for generating `html` or `richText` finally.
Add `TooltipMarkup` is also in charge of sort the tooltip by `valueAsc`, `valueDesc`, `seriesAsc`, `seriesDesc`.
With the help of it, a typical tooltip description can be:
```ts
formatTooltip(dataIndex: number) {
......
return createTooltipMarkup('section', {
header: xxx,
sortBlocks: true,
blocks: zrUtil.map(indicatorAxes, axis => {
const val = data.get(data.mapDimension(axis.dim), dataIndex);
return createTooltipMarkup('nameValue', {
markerType: 'subItem',
markerColor: ...,
name: ...,
value: val,
sortParam: val
});
})
});
}
```
## TEST_CASES
test/new-tooltip.html
## PENDING
Do we need to expose API (like `tooltipMarkup.ts#TooltipMarkupStyleCreator`) to `tooltip.formatter` callback, by which users can add richText style themselves. At present users is not able to do that.
But if we expose that kind of API, there is an issue:
should we use ZRender style (use `fill` to describe text color)
or ECharts label style (use `color` to describe text color).
Like
```ts
formatter: function (params) {
if (params.renderMode === 'richText') {
const valueStyle = { align: 'right', fontWeight: 900, fill: '#blue' };
return params.map(param => param.marker.content + param.name + params.wrapRichTextStyle(param.value));
}
...
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah merged pull request #13242: fix:
Posted by GitBox <gi...@apache.org>.
100pah merged pull request #13242:
URL: https://github.com/apache/incubator-echarts/pull/13242
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13242: fix:
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13242:
URL: https://github.com/apache/incubator-echarts/pull/13242#issuecomment-688049551
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13242: fix:
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13242:
URL: https://github.com/apache/incubator-echarts/pull/13242#issuecomment-688060943
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org