[jira] [Resolved] (CALCITE-2838) Simplification: Remove redundant IS TRUE checks

["Zoltan Haindrich (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zoltan Haindrich resolved CALCITE-2838.
---------------------------------------
    Resolution: Fixed

fixed in [c462838f37f02b490088a216773415926688e9f3|https://github.com/apache/calcite/commit/c462838f37f02b490088a216773415926688e9f3]

> Simplification: Remove redundant IS TRUE checks
> -----------------------------------------------
>
>                 Key: CALCITE-2838
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2838
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.19.0
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> In case simplifcation is already processing in unknownAsFalse mode, {{expr IS TRUE}} is redundant - and may just prevent further optimizations from happening:
> {code}
>   @Test public void testRedundantIsTrue() {
>     // in case of unknownAsFalse
>     // x is TRUE <=> x
>     checkSimplify3(isTrue(vBool(1)),
>         "IS TRUE(?0.bool1)",
>         "?0.bool1",
>         "IS TRUE(?0.bool1)");
>   }
> {code}
> there are some further possibilities
> {code}
> (unknownAsTrue) x is NOT FALSE <=> x
> (unknownAsTrue) x is FALSE <=> not x
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)