You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/10/29 21:00:35 UTC

[GitHub] [hadoop-ozone] avijayanhwx opened a new pull request #102: HDDS-2380. OMFileRequest should use the isExist API while checking fo…

avijayanhwx opened a new pull request #102: HDDS-2380. OMFileRequest should use the isExist API while checking fo…
URL: https://github.com/apache/hadoop-ozone/pull/102
 
 
   …r pre-existing files in the directory path.
   
   ## What changes were proposed in this pull request?
   Currently, when OM creates a file/directory, it checks the absence of all prefix paths of the key in its RocksDB. Since we don't care about the deserialization of the actual value from the DB, we should use the isExist API added in org.apache.hadoop.hdds.utils.db.Table which internally uses the more performant keyMayExist API of RocksDB. More documentation on the keyMayExist API can be found [here](https://github.com/facebook/rocksdb/blob/7a8d7358bb40b13a06c2c6adc62e80295d89ed05/java/src/main/java/org/rocksdb/RocksDB.java#L2184) This API was already used in the old OM create file flow. This patch adds it to the new OM code flow that uses Double buffering. 
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-2380
   
   ## How was this patch tested?
   Manually tested.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org