[GitHub] [james-project] vttranlina commented on pull request #1320: JAMES-3461 - Fix Mailbox/changes do not take isSubscribe changes into account

[GitBox <gi...@apache.org>]

vttranlina commented on PR #1320:
URL: https://github.com/apache/james-project/pull/1320#issuecomment-1321780221

   > Still missing tests for WebPush, websockets, SSE ?
   
   it's already
   `org.apache.james.jmap.rfc8621.contract.MailboxSetMethodContract#webSocketShouldPushNewMessageWhenChangeSubscriptionOfMailbox`
   `org.apache.james.jmap.rfc8621.contract.MailboxSetMethodContract#sseShouldHasNewEventWhenChangeSubscribeOfMailbox`
   
   WebPush is same mechanism, so IMO the unittest in `org.apache.james.jmap.change.MailboxChangeListenerTest` is enough.
   
   I pushed it in `MailboxSetMethodContract` because it more near with MailboxSet,
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org