You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2024/09/03 07:41:47 UTC

[PR] [FLINK-36201][Coordination] Don't use StateLocalitySlotAssigner when local recovery is disabled [flink]

1996fanrui opened a new pull request, #25284:
URL: https://github.com/apache/flink/pull/25284

   ## What is the purpose of the change
   
   The local recovery doesn't take effect if flink doesn't backup state on the TM local disk. So StateLocalitySlotAssigner should be only used when local recovery is enabled.
   
   
   ## Brief change log
   
   - [FLINK-36201][Coordination] Don't use StateLocalitySlotAssigner when local recovery is disabled
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as : `SlotSharingSlotAllocatorTest#testStickyAllocation`
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-36201][Coordination] Don't use StateLocalitySlotAssigner when local recovery is disabled [flink]

Posted by "dmvk (via GitHub)" <gi...@apache.org>.
dmvk merged PR #25284:
URL: https://github.com/apache/flink/pull/25284


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-36201][Coordination] Don't use StateLocalitySlotAssigner when local recovery is disabled [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25284:
URL: https://github.com/apache/flink/pull/25284#issuecomment-2325827465

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9c28ce066857ae603ec0517de8c45cfef5fe2a89",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9c28ce066857ae603ec0517de8c45cfef5fe2a89",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9c28ce066857ae603ec0517de8c45cfef5fe2a89 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org