You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by pavan kumar kolamuri <pa...@gmail.com> on 2014/05/26 14:36:10 UTC
Re: Review Request 21857: Falcon 263 - Added option to display wf-params for
a given instance
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21857/
-----------------------------------------------------------
(Updated May 26, 2014, 12:36 p.m.)
Review request for Falcon.
Summary (updated)
-----------------
Falcon 263 - Added option to display wf-params for a given instance
Repository: falcon-git
Description
-------
Adding params option which will display all wf-params for a given instance
Diffs
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c51c3c0
client/src/main/java/org/apache/falcon/client/FalconClient.java beecc0f
client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 62b810c
client/src/main/java/org/apache/falcon/resource/InstancesResult.java da0ccc5
common/src/main/java/org/apache/falcon/entity/EntityUtil.java b4bc07d
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java c28cb03
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 34192c0
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 3b87469
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 42b4aeb
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java bdf5e1b
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 9471e27
Diff: https://reviews.apache.org/r/21857/diff/
Testing
-------
Thanks,
pavan kumar kolamuri
Re: Review Request 21857: Falcon 263 - Added option to display wf-params for
a given instance
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21857/
-----------------------------------------------------------
(Updated June 11, 2014, 10:21 a.m.)
Review request for Falcon.
Changes
-------
Removed rerun only failed actions as there is continue option for it
Repository: falcon-git
Description
-------
Adding params option which will display all wf-params for a given instance
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c51c3c0
client/src/main/java/org/apache/falcon/client/FalconClient.java beecc0f
client/src/main/java/org/apache/falcon/resource/InstancesResult.java da0ccc5
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java c28cb03
docs/src/site/twiki/FalconCLI.twiki dbb6981
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 34192c0
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 3b87469
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 42b4aeb
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java bdf5e1b
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 9471e27
Diff: https://reviews.apache.org/r/21857/diff/
Testing
-------
Thanks,
pavan kumar kolamuri
Re: Review Request 21857: Falcon 263 - Added option to display wf-params for
a given instance
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21857/#review44110
-----------------------------------------------------------
Ship it!
Ship It!
- shwethags
On May 28, 2014, 11:30 a.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21857/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 11:30 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Adding params option which will display all wf-params for a given instance
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c51c3c0
> client/src/main/java/org/apache/falcon/client/FalconClient.java beecc0f
> client/src/main/java/org/apache/falcon/resource/InstancesResult.java da0ccc5
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java c28cb03
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 34192c0
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 3b87469
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 42b4aeb
> webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java bdf5e1b
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 9471e27
>
> Diff: https://reviews.apache.org/r/21857/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 21857: Falcon 263 - Added option to display wf-params for
a given instance
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21857/
-----------------------------------------------------------
(Updated May 28, 2014, 11:30 a.m.)
Review request for Falcon.
Changes
-------
Added rerun only failed actions if not set in props and fixed based on comments
Repository: falcon-git
Description
-------
Adding params option which will display all wf-params for a given instance
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c51c3c0
client/src/main/java/org/apache/falcon/client/FalconClient.java beecc0f
client/src/main/java/org/apache/falcon/resource/InstancesResult.java da0ccc5
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java c28cb03
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 34192c0
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 3b87469
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 42b4aeb
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java bdf5e1b
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 9471e27
Diff: https://reviews.apache.org/r/21857/diff/
Testing
-------
Thanks,
pavan kumar kolamuri
Re: Review Request 21857: Falcon 263 - Added option to display wf-params for
a given instance
Posted by sh...@inmobi.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21857/#review43925
-----------------------------------------------------------
Can you also change the default option of re-running only failed actions
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java
<https://reviews.apache.org/r/21857/#comment78209>
Function should return the params
OozieUtils.toProperties probably iterates through conf and another for loop for iterating through properties. Can avoid one for loop
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java
<https://reviews.apache.org/r/21857/#comment78210>
rename function
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java
<https://reviews.apache.org/r/21857/#comment78211>
not required?
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java
<https://reviews.apache.org/r/21857/#comment78212>
rename
- shwethags
On May 26, 2014, 12:36 p.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21857/
> -----------------------------------------------------------
>
> (Updated May 26, 2014, 12:36 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Adding params option which will display all wf-params for a given instance
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c51c3c0
> client/src/main/java/org/apache/falcon/client/FalconClient.java beecc0f
> client/src/main/java/org/apache/falcon/resource/InstancesResult.java da0ccc5
> common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java c28cb03
> oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 34192c0
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 3b87469
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 42b4aeb
> webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java bdf5e1b
> webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 9471e27
>
> Diff: https://reviews.apache.org/r/21857/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 21857: Falcon 263 - Added option to display wf-params for
a given instance
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21857/
-----------------------------------------------------------
(Updated May 26, 2014, 12:36 p.m.)
Review request for Falcon.
Changes
-------
changes done based on comments , removed duplicate functions
Repository: falcon-git
Description
-------
Adding params option which will display all wf-params for a given instance
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c51c3c0
client/src/main/java/org/apache/falcon/client/FalconClient.java beecc0f
client/src/main/java/org/apache/falcon/resource/InstancesResult.java da0ccc5
common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java c28cb03
oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java 34192c0
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java 3b87469
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 42b4aeb
webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java bdf5e1b
webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java 9471e27
Diff: https://reviews.apache.org/r/21857/diff/
Testing
-------
Thanks,
pavan kumar kolamuri