You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Tyson Norris (Created) (JIRA)" <ji...@apache.org> on 2012/03/28 19:59:28 UTC
[jira] [Created] (SLING-2450) JcrInstaller generates incorrect node
name in /apps/system/config (or else the installer doesn't process the
nodename properly)
JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
-------------------------------------------------------------------------------------------------------------------------------
Key: SLING-2450
URL: https://issues.apache.org/jira/browse/SLING-2450
Project: Sling
Issue Type: Bug
Components: Installer
Affects Versions: JCR Installer 3.1.2
Reporter: Tyson Norris
when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
Note that:
- "com.adobe.granite.auth.oauth.provider" string only occurs once
- there is a dash "-" after "provider"
I'm not sure which problem it is, but it may be one of:
- the JcrInstaller generates the wrong node name
- OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (SLING-2450) JcrInstaller generates incorrect
node name in /apps/system/config (or else the installer doesn't process the
nodename properly)
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler reopened SLING-2450:
-------------------------------------
It seems that there is still a problem, when a factory configuration is created through the web console and later changed in the repository. This ends up with two
factory configurations.
> JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2450
> URL: https://issues.apache.org/jira/browse/SLING-2450
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.3.4, JCR Installer 3.1.2, Installer Configuration Factory 1.0.4
> Reporter: Tyson Norris
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.3.6, JCR Installer 3.1.4, Installer Configuration Factory 1.0.6
>
>
> when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
> com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
> com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> Note that:
> - "com.adobe.granite.auth.oauth.provider" string only occurs once
> - there is a dash "-" after "provider"
> I'm not sure which problem it is, but it may be one of:
> - the JcrInstaller generates the wrong node name
> - OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (SLING-2450) JcrInstaller generates
incorrect node name in /apps/system/config (or else the installer doesn't
process the nodename properly)
Posted by "Tyson Norris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262186#comment-13262186 ]
Tyson Norris edited comment on SLING-2450 at 4/25/12 10:20 PM:
---------------------------------------------------------------
I built snapshot versions:
-rw-r--r-- 1 tnorris admin 130504 Apr 25 13:55 org.apache.sling.installer.core-3.3.5-SNAPSHOT.jar
-rw-r--r-- 1 tnorris admin 24185 Apr 25 13:57 org.apache.sling.installer.factory.configuration-1.0.5-SNAPSHOT.jar
-rw-r--r-- 1 tnorris admin 54277 Apr 25 13:56 org.apache.sling.installer.provider.jcr-3.1.3-SNAPSHOT.jar
Then installed into crx; verified the bundle versions in osgi console.
But don't see any change when I try have the text file resurrect the osgi config on a different instance.
Adding a node at /apps/system/config/com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.514f1954-94c8-48b1-bc65-f96c794a37ce.config should produce a config for provider com.adobe.granite.auth.oauth.provider right?
Thanks
Tyson
was (Author: tysonnorris):
I built snapshot versions:
-rw-r--r-- 1 tnorris admin 130504 Apr 25 13:55 org.apache.sling.installer.core-3.3.5-SNAPSHOT.jar
-rw-r--r-- 1 tnorris admin 24185 Apr 25 13:57 org.apache.sling.installer.factory.configuration-1.0.5-SNAPSHOT.jar
-rw-r--r-- 1 tnorris admin 54277 Apr 25 13:56 org.apache.sling.installer.provider.jcr-3.1.3-SNAPSHOT.jar
But don't see any change.
Adding a node at /apps/system/config/com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.514f1954-94c8-48b1-bc65-f96c794a37ce.config should produce a config for provider com.adobe.granite.auth.oauth.provider right?
Thanks
Tyson
> JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2450
> URL: https://issues.apache.org/jira/browse/SLING-2450
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.3.4, JCR Installer 3.1.2, Installer Configuration Factory 1.0.4
> Reporter: Tyson Norris
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.3.6, JCR Installer 3.1.4, Installer Configuration Factory 1.0.6
>
>
> when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
> com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
> com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> Note that:
> - "com.adobe.granite.auth.oauth.provider" string only occurs once
> - there is a dash "-" after "provider"
> I'm not sure which problem it is, but it may be one of:
> - the JcrInstaller generates the wrong node name
> - OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2450) JcrInstaller generates incorrect
node name in /apps/system/config (or else the installer doesn't process the
nodename properly)
Posted by "Tyson Norris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262186#comment-13262186 ]
Tyson Norris commented on SLING-2450:
-------------------------------------
I built snapshot versions:
-rw-r--r-- 1 tnorris admin 130504 Apr 25 13:55 org.apache.sling.installer.core-3.3.5-SNAPSHOT.jar
-rw-r--r-- 1 tnorris admin 24185 Apr 25 13:57 org.apache.sling.installer.factory.configuration-1.0.5-SNAPSHOT.jar
-rw-r--r-- 1 tnorris admin 54277 Apr 25 13:56 org.apache.sling.installer.provider.jcr-3.1.3-SNAPSHOT.jar
But don't see any change.
Adding a node at /apps/system/config/com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.514f1954-94c8-48b1-bc65-f96c794a37ce.config should produce a config for provider com.adobe.granite.auth.oauth.provider right?
Thanks
Tyson
> JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2450
> URL: https://issues.apache.org/jira/browse/SLING-2450
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.3.4, JCR Installer 3.1.2, Installer Configuration Factory 1.0.4
> Reporter: Tyson Norris
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.3.6, JCR Installer 3.1.4, Installer Configuration Factory 1.0.6
>
>
> when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
> com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
> com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> Note that:
> - "com.adobe.granite.auth.oauth.provider" string only occurs once
> - there is a dash "-" after "provider"
> I'm not sure which problem it is, but it may be one of:
> - the JcrInstaller generates the wrong node name
> - OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2450) JcrInstaller generates incorrect
node name in /apps/system/config (or else the installer doesn't process the
nodename properly)
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved SLING-2450.
-------------------------------------
Resolution: Fixed
Finally fixed with 1338272. This last change affects only the configuration factory
> JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2450
> URL: https://issues.apache.org/jira/browse/SLING-2450
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.3.4, JCR Installer 3.1.2, Installer Configuration Factory 1.0.4
> Reporter: Tyson Norris
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.3.6, JCR Installer 3.1.4, Installer Configuration Factory 1.0.8
>
>
> when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
> com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
> com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> Note that:
> - "com.adobe.granite.auth.oauth.provider" string only occurs once
> - there is a dash "-" after "provider"
> I'm not sure which problem it is, but it may be one of:
> - the JcrInstaller generates the wrong node name
> - OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2450) JcrInstaller generates incorrect
node name in /apps/system/config (or else the installer doesn't process the
nodename properly)
Posted by "Carsten Ziegeler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240709#comment-13240709 ]
Carsten Ziegeler commented on SLING-2450:
-----------------------------------------
This seems to be a bug/problem in the osgi installer core which does not translate factory pids correctly back.
The jcr installer part ignoring those nodes is correct
I'll have to investigate a little bit here
> JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2450
> URL: https://issues.apache.org/jira/browse/SLING-2450
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: JCR Installer 3.1.2
> Reporter: Tyson Norris
>
> when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
> com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
> com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> Note that:
> - "com.adobe.granite.auth.oauth.provider" string only occurs once
> - there is a dash "-" after "provider"
> I'm not sure which problem it is, but it may be one of:
> - the JcrInstaller generates the wrong node name
> - OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (SLING-2450) JcrInstaller generates incorrect
node name in /apps/system/config (or else the installer doesn't process the
nodename properly)
Posted by "Tyson Norris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tyson Norris reopened SLING-2450:
---------------------------------
reopening because I still have the problem;
Wondering if I am misunderstanding the change from sling:OsgiConfig to nt:file - adding a sling:OsgiConfig should cause the config to register via ConfigurationManager, does the same not work for adding an nt:file into a config folder?
> JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2450
> URL: https://issues.apache.org/jira/browse/SLING-2450
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.3.4, JCR Installer 3.1.2, Installer Configuration Factory 1.0.4
> Reporter: Tyson Norris
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.3.6, JCR Installer 3.1.4, Installer Configuration Factory 1.0.6
>
>
> when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
> com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
> com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> Note that:
> - "com.adobe.granite.auth.oauth.provider" string only occurs once
> - there is a dash "-" after "provider"
> I'm not sure which problem it is, but it may be one of:
> - the JcrInstaller generates the wrong node name
> - OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SLING-2450) JcrInstaller generates incorrect node
name in /apps/system/config (or else the installer doesn't process the
nodename properly)
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed SLING-2450.
-----------------------------------
> JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2450
> URL: https://issues.apache.org/jira/browse/SLING-2450
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.3.4, JCR Installer 3.1.2, Installer Configuration Factory 1.0.4
> Reporter: Tyson Norris
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.3.6, JCR Installer 3.1.4, Installer Configuration Factory 1.0.8
>
>
> when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
> com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
> com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> Note that:
> - "com.adobe.granite.auth.oauth.provider" string only occurs once
> - there is a dash "-" after "provider"
> I'm not sure which problem it is, but it may be one of:
> - the JcrInstaller generates the wrong node name
> - OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2450) JcrInstaller generates incorrect
node name in /apps/system/config (or else the installer doesn't process the
nodename properly)
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved SLING-2450.
-------------------------------------
Resolution: Fixed
Hi Tyson,
I'm closing this bug for two reasons:
- the problem you describe is not the same than this issue; it's about reading configurations not writing them back
- I did a quick test and adding config files to the repo, editing them etc. works for me
If you think there still is an issue, please create a new issue with a description how to reproduce the problem. Thanks
> JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2450
> URL: https://issues.apache.org/jira/browse/SLING-2450
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.3.4, JCR Installer 3.1.2, Installer Configuration Factory 1.0.4
> Reporter: Tyson Norris
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.3.6, JCR Installer 3.1.4, Installer Configuration Factory 1.0.6
>
>
> when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
> com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
> com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> Note that:
> - "com.adobe.granite.auth.oauth.provider" string only occurs once
> - there is a dash "-" after "provider"
> I'm not sure which problem it is, but it may be one of:
> - the JcrInstaller generates the wrong node name
> - OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2450) JcrInstaller generates incorrect
node name in /apps/system/config (or else the installer doesn't process the
nodename properly)
Posted by "Carsten Ziegeler (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved SLING-2450.
-------------------------------------
Resolution: Fixed
Actually this was a serious of smaller bugs in all three components. I've fixed the factory configuration handling in revision 1307172. In addition it now uses the alias name when writing back an overwritten configuration
> JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2450
> URL: https://issues.apache.org/jira/browse/SLING-2450
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.3.4, JCR Installer 3.1.2, Installer Configuration Factory 1.0.4
> Reporter: Tyson Norris
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.3.6, JCR Installer 3.1.4, Installer Configuration Factory 1.0.6
>
>
> when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
> com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
> com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> Note that:
> - "com.adobe.granite.auth.oauth.provider" string only occurs once
> - there is a dash "-" after "provider"
> I'm not sure which problem it is, but it may be one of:
> - the JcrInstaller generates the wrong node name
> - OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2450) JcrInstaller generates incorrect
node name in /apps/system/config (or else the installer doesn't process the
nodename properly)
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262418#comment-13262418 ]
Bertrand Delacretaz commented on SLING-2450:
--------------------------------------------
Aren't there any automated tests that demonstrate that this functionality works?
> JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2450
> URL: https://issues.apache.org/jira/browse/SLING-2450
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.3.4, JCR Installer 3.1.2, Installer Configuration Factory 1.0.4
> Reporter: Tyson Norris
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.3.6, JCR Installer 3.1.4, Installer Configuration Factory 1.0.6
>
>
> when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
> com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
> com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> Note that:
> - "com.adobe.granite.auth.oauth.provider" string only occurs once
> - there is a dash "-" after "provider"
> I'm not sure which problem it is, but it may be one of:
> - the JcrInstaller generates the wrong node name
> - OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2450) JcrInstaller generates incorrect
node name in /apps/system/config (or else the installer doesn't process the
nodename properly)
Posted by "Tyson Norris (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262730#comment-13262730 ]
Tyson Norris commented on SLING-2450:
-------------------------------------
@Bertrand : The tests exercise sling:OsgiConfig triggering osgi config, which works; I'm looking for how to rely on the new nt:file (which replaces sling:OsgiConfig after installation) can cause the osgi config.
@Carsten : "The jcr installer part ignoring those nodes is correct" - current behavior is the sling:OsgiConfig nodes disappear after installation, which is fine I guess, as long as the nt:file node that appears in its place is used. In the case where to separate instances are supposed to reflect changes by copying content from one to the other, this means that copying the nt:file should cause changes to appear in the second instance, but that is not the case. How else should a config generated on one instance get copied to another instance?
The only possibility I see with current system is to monitor configuration changes myself, and generate sling:OsgiConfig myself manually, and copy that to the second instance for installation. ack.
Thanks
Tyson
> JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2450
> URL: https://issues.apache.org/jira/browse/SLING-2450
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.3.4, JCR Installer 3.1.2, Installer Configuration Factory 1.0.4
> Reporter: Tyson Norris
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.3.6, JCR Installer 3.1.4, Installer Configuration Factory 1.0.6
>
>
> when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
> com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
> com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> Note that:
> - "com.adobe.granite.auth.oauth.provider" string only occurs once
> - there is a dash "-" after "provider"
> I'm not sure which problem it is, but it may be one of:
> - the JcrInstaller generates the wrong node name
> - OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2450) JcrInstaller generates incorrect
node name in /apps/system/config (or else the installer doesn't process the
nodename properly)
Posted by "Tyson Norris (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240588#comment-13240588 ]
Tyson Norris commented on SLING-2450:
-------------------------------------
In my test, adding a node to /apps/system/config named in the same way as the generated node (e.g. com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.955d9a39.10ad9a1b-d610-4c18-a816-4a774dfcb2cf.config) results in this log message, with an incorrect service.factoryPid:
28.03.2012 10:26:24.422 *INFO* [OsgiInstallerImpl] org.apache.sling.audit.osgi.installer Installed configuration com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.955d9a39.10ad9a1b-d610-4c18-a816-4a774dfcb2cf from resource TaskResource(url=jcrinstall:/apps/system/config/com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.955d9a39-9231-43e8-9d67-11111111.config, entity=config:com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.955d9a39.9231-43e8-9d67-11111111, state=INSTALL, attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:50:, service.factoryPid=com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.955d9a39, service.pid=9231-43e8-9d67-11111111], digest=5abc3a8c9c399d8d9d510641ab388577)
If instead I name a node com.adobe.granite.auth.oauth.provider-955d9a39-9231-43e8-9d67-11111111.config, the correct factoryPid is used and config appears as expected:
28.03.2012 10:44:17.349 *INFO* [OsgiInstallerImpl] org.apache.sling.audit.osgi.installer Installed configuration com.adobe.granite.auth.oauth.provider.618f4315-4a0d-4ede-9657-0e32e0215d83 from resource TaskResource(url=jcrinstall:/apps/system/config/com.adobe.granite.auth.oauth.provider-955d9a39-9231-43e8-9d67-11111111.config, entity=config:com.adobe.granite.auth.oauth.provider.955d9a39-9231-43e8-9d67-11111111, state=INSTALL, attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:50:, service.factoryPid=com.adobe.granite.auth.oauth.provider, service.pid=955d9a39-9231-43e8-9d67-11111111], digest=65741728327d3b692b0272c53691a04a)
> JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2450
> URL: https://issues.apache.org/jira/browse/SLING-2450
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: JCR Installer 3.1.2
> Reporter: Tyson Norris
>
> when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
> com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
> com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> Note that:
> - "com.adobe.granite.auth.oauth.provider" string only occurs once
> - there is a dash "-" after "provider"
> I'm not sure which problem it is, but it may be one of:
> - the JcrInstaller generates the wrong node name
> - OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2450) JcrInstaller generates incorrect node
name in /apps/system/config (or else the installer doesn't process the
nodename properly)
Posted by "Carsten Ziegeler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler updated SLING-2450:
------------------------------------
Affects Version/s: Installer Core 3.3.4
Installer Configuration Factory 1.0.4
Fix Version/s: Installer Configuration Factory 1.0.6
JCR Installer 3.1.4
Installer Core 3.3.6
> JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2450
> URL: https://issues.apache.org/jira/browse/SLING-2450
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: Installer Core 3.3.4, JCR Installer 3.1.2, Installer Configuration Factory 1.0.4
> Reporter: Tyson Norris
> Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.3.6, JCR Installer 3.1.4, Installer Configuration Factory 1.0.6
>
>
> when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
> com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
> com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> Note that:
> - "com.adobe.granite.auth.oauth.provider" string only occurs once
> - there is a dash "-" after "provider"
> I'm not sure which problem it is, but it may be one of:
> - the JcrInstaller generates the wrong node name
> - OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2450) JcrInstaller generates incorrect
node name in /apps/system/config (or else the installer doesn't process the
nodename properly)
Posted by "Carsten Ziegeler (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler reassigned SLING-2450:
---------------------------------------
Assignee: Carsten Ziegeler
> JcrInstaller generates incorrect node name in /apps/system/config (or else the installer doesn't process the nodename properly)
> -------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-2450
> URL: https://issues.apache.org/jira/browse/SLING-2450
> Project: Sling
> Issue Type: Bug
> Components: Installer
> Affects Versions: JCR Installer 3.1.2
> Reporter: Tyson Norris
> Assignee: Carsten Ziegeler
>
> when using ConfigurationAdmin or osgi web console to create a config for a ManagedServiceFactory, a nt:file node is created in /apps/system/config with a node name like:
> com.adobe.granite.auth.oauth.provider.com.adobe.granite.auth.oauth.provider.99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> The installer, however will not process the node (and create the managed service propertly) unless the node name is formatted like:
> com.adobe.granite.auth.oauth.provider-99bd39e3-4367-47b0-a5a2-b4e1a0f8a5b9.config
> Note that:
> - "com.adobe.granite.auth.oauth.provider" string only occurs once
> - there is a dash "-" after "provider"
> I'm not sure which problem it is, but it may be one of:
> - the JcrInstaller generates the wrong node name
> - OR the JcrInstaller does not process the node name properly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira