You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/23 09:48:36 UTC
[GitHub] [flink] kl0u opened a new pull request #11487: [FLINK-16656]
Introduce the DispatcherBootstrap.
kl0u opened a new pull request #11487: [FLINK-16656] Introduce the DispatcherBootstrap.
URL: https://github.com/apache/flink/pull/11487
## What is the purpose of the change
This PR introduces the `DispatcherBootstrap` which will contain the "initial" state of the dispatcher. This means that upon dispatcher initialisation `Dispatcher#onStart()`, the `DispatcherBoootstrap#initialize()` method will be called to initialise it.
As an example, in the case of the dispatcher of a session cluster, the bootstrap will re-launch the recovered job graphs.
## Brief change log
Introduces the `DispatcherBootstrap` interface with a default implementation for the current `StandaloneDispatcher` and `MiniDispatcher` which relaunched the recovered (or submitted) `JobGraph`s.
## Verifying this change
Already covered by tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u closed pull request #11487: [FLINK-16656] Introduce
the DispatcherBootstrap.
Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #11487: [FLINK-16656] Introduce the DispatcherBootstrap.
URL: https://github.com/apache/flink/pull/11487
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on issue #11487: [FLINK-16656] Introduce the
DispatcherBootstrap.
Posted by GitBox <gi...@apache.org>.
kl0u commented on issue #11487: [FLINK-16656] Introduce the DispatcherBootstrap.
URL: https://github.com/apache/flink/pull/11487#issuecomment-613908516
Subsumed by https://github.com/apache/flink/pull/11696
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11487: [FLINK-16656]
Introduce the DispatcherBootstrap.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11487: [FLINK-16656] Introduce the DispatcherBootstrap.
URL: https://github.com/apache/flink/pull/11487#issuecomment-602504532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d31a75920164c244f4cc94cbcb8eaa284ff1b9d",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154566637",
"triggerID" : "8d31a75920164c244f4cc94cbcb8eaa284ff1b9d",
"triggerType" : "PUSH"
}, {
"hash" : "8d31a75920164c244f4cc94cbcb8eaa284ff1b9d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6520",
"triggerID" : "8d31a75920164c244f4cc94cbcb8eaa284ff1b9d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d31a75920164c244f4cc94cbcb8eaa284ff1b9d Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154566637) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6520)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11487: [FLINK-16656] Introduce
the DispatcherBootstrap.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11487: [FLINK-16656] Introduce the DispatcherBootstrap.
URL: https://github.com/apache/flink/pull/11487#issuecomment-602490738
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8d31a75920164c244f4cc94cbcb8eaa284ff1b9d (Mon Mar 23 09:51:04 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11487: [FLINK-16656]
Introduce the DispatcherBootstrap.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11487: [FLINK-16656] Introduce the DispatcherBootstrap.
URL: https://github.com/apache/flink/pull/11487#issuecomment-602504532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d31a75920164c244f4cc94cbcb8eaa284ff1b9d",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154566637",
"triggerID" : "8d31a75920164c244f4cc94cbcb8eaa284ff1b9d",
"triggerType" : "PUSH"
}, {
"hash" : "8d31a75920164c244f4cc94cbcb8eaa284ff1b9d",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6520",
"triggerID" : "8d31a75920164c244f4cc94cbcb8eaa284ff1b9d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d31a75920164c244f4cc94cbcb8eaa284ff1b9d Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/154566637) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6520)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11487: [FLINK-16656]
Introduce the DispatcherBootstrap.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11487: [FLINK-16656] Introduce the DispatcherBootstrap.
URL: https://github.com/apache/flink/pull/11487#issuecomment-602504532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d31a75920164c244f4cc94cbcb8eaa284ff1b9d",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/154566637",
"triggerID" : "8d31a75920164c244f4cc94cbcb8eaa284ff1b9d",
"triggerType" : "PUSH"
}, {
"hash" : "8d31a75920164c244f4cc94cbcb8eaa284ff1b9d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6520",
"triggerID" : "8d31a75920164c244f4cc94cbcb8eaa284ff1b9d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d31a75920164c244f4cc94cbcb8eaa284ff1b9d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/154566637) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6520)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11487: [FLINK-16656] Introduce
the DispatcherBootstrap.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11487: [FLINK-16656] Introduce the DispatcherBootstrap.
URL: https://github.com/apache/flink/pull/11487#issuecomment-602504532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d31a75920164c244f4cc94cbcb8eaa284ff1b9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8d31a75920164c244f4cc94cbcb8eaa284ff1b9d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d31a75920164c244f4cc94cbcb8eaa284ff1b9d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services