You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/10/06 02:05:31 UTC
[jira] Created: (ZOOKEEPER-541) zkpython limited to 256 handles
zkpython limited to 256 handles
-------------------------------
Key: ZOOKEEPER-541
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-541
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Henry Robinson
Fix For: 3.3.0
zkpython is currently limited to a max of 256 total handles - not 256 open handles, but rather 256 total handles created
over the lifetime of the python application.
In general this isn't a real issue, however in the case of a long lived application which polls the cluster periodically (closing
the session btw calls) this is an issue.
it would be great if the slots could be reused? or perhaps a more complex structure, such as a linked list, which would allow
dynamic growth/shrinkage of the handle list.
Also see ZOOKEEPER-540
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-541) zkpython limited to 256 handles
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765510#action_12765510 ]
Hudson commented on ZOOKEEPER-541:
----------------------------------
Integrated in ZooKeeper-trunk #497 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/497/])
. zkpython limited to 256 handles
> zkpython limited to 256 handles
> -------------------------------
>
> Key: ZOOKEEPER-541
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-541
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-541.patch
>
>
> zkpython is currently limited to a max of 256 total handles - not 256 open handles, but rather 256 total handles created
> over the lifetime of the python application.
> In general this isn't a real issue, however in the case of a long lived application which polls the cluster periodically (closing
> the session btw calls) this is an issue.
> it would be great if the slots could be reused? or perhaps a more complex structure, such as a linked list, which would allow
> dynamic growth/shrinkage of the handle list.
> Also see ZOOKEEPER-540
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-541) zkpython limited to 256 handles
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson updated ZOOKEEPER-541:
-------------------------------------
Status: Patch Available (was: Open)
> zkpython limited to 256 handles
> -------------------------------
>
> Key: ZOOKEEPER-541
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-541
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-541.patch
>
>
> zkpython is currently limited to a max of 256 total handles - not 256 open handles, but rather 256 total handles created
> over the lifetime of the python application.
> In general this isn't a real issue, however in the case of a long lived application which polls the cluster periodically (closing
> the session btw calls) this is an issue.
> it would be great if the slots could be reused? or perhaps a more complex structure, such as a linked list, which would allow
> dynamic growth/shrinkage of the handle list.
> Also see ZOOKEEPER-540
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-541) zkpython limited to 256 handles
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763838#action_12763838 ]
Patrick Hunt commented on ZOOKEEPER-541:
----------------------------------------
Henry, you want to make this "patch available", not "in progress". I seem to be locked out of doing that otw I would fix it.
> zkpython limited to 256 handles
> -------------------------------
>
> Key: ZOOKEEPER-541
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-541
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-541.patch
>
>
> zkpython is currently limited to a max of 256 total handles - not 256 open handles, but rather 256 total handles created
> over the lifetime of the python application.
> In general this isn't a real issue, however in the case of a long lived application which polls the cluster periodically (closing
> the session btw calls) this is an issue.
> it would be great if the slots could be reused? or perhaps a more complex structure, such as a linked list, which would allow
> dynamic growth/shrinkage of the handle list.
> Also see ZOOKEEPER-540
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-541) zkpython limited to 256 handles
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-541:
-----------------------------------
Fix Version/s: 3.2.2
> zkpython limited to 256 handles
> -------------------------------
>
> Key: ZOOKEEPER-541
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-541
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Fix For: 3.2.2, 3.3.0
>
> Attachments: ZOOKEEPER-541.patch
>
>
> zkpython is currently limited to a max of 256 total handles - not 256 open handles, but rather 256 total handles created
> over the lifetime of the python application.
> In general this isn't a real issue, however in the case of a long lived application which polls the cluster periodically (closing
> the session btw calls) this is an issue.
> it would be great if the slots could be reused? or perhaps a more complex structure, such as a linked list, which would allow
> dynamic growth/shrinkage of the handle list.
> Also see ZOOKEEPER-540
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-541) zkpython limited to 256 handles
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson updated ZOOKEEPER-541:
-------------------------------------
Status: Patch Available (was: In Progress)
> zkpython limited to 256 handles
> -------------------------------
>
> Key: ZOOKEEPER-541
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-541
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-541.patch
>
>
> zkpython is currently limited to a max of 256 total handles - not 256 open handles, but rather 256 total handles created
> over the lifetime of the python application.
> In general this isn't a real issue, however in the case of a long lived application which polls the cluster periodically (closing
> the session btw calls) this is an issue.
> it would be great if the slots could be reused? or perhaps a more complex structure, such as a linked list, which would allow
> dynamic growth/shrinkage of the handle list.
> Also see ZOOKEEPER-540
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-541) zkpython limited to 256 handles
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762834#action_12762834 ]
Hadoop QA commented on ZOOKEEPER-541:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12421470/ZOOKEEPER-541.patch
against trunk revision 822065.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/1/console
This message is automatically generated.
> zkpython limited to 256 handles
> -------------------------------
>
> Key: ZOOKEEPER-541
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-541
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-541.patch
>
>
> zkpython is currently limited to a max of 256 total handles - not 256 open handles, but rather 256 total handles created
> over the lifetime of the python application.
> In general this isn't a real issue, however in the case of a long lived application which polls the cluster periodically (closing
> the session btw calls) this is an issue.
> it would be great if the slots could be reused? or perhaps a more complex structure, such as a linked list, which would allow
> dynamic growth/shrinkage of the handle list.
> Also see ZOOKEEPER-540
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-541) zkpython limited to 256 handles
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson updated ZOOKEEPER-541:
-------------------------------------
Attachment: ZOOKEEPER-541.patch
This patch ups the limit of concurrently active connections to 32768, and allocates these handles dynamically in increasing powers of two.
Handles are re-used when they are correctly closed. This involves an O(n) scan of the handle array, but I think this is preferable to the overhead of managing linked lists with O(1) lookup.
Tests are included.
> zkpython limited to 256 handles
> -------------------------------
>
> Key: ZOOKEEPER-541
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-541
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-541.patch
>
>
> zkpython is currently limited to a max of 256 total handles - not 256 open handles, but rather 256 total handles created
> over the lifetime of the python application.
> In general this isn't a real issue, however in the case of a long lived application which polls the cluster periodically (closing
> the session btw calls) this is an issue.
> it would be great if the slots could be reused? or perhaps a more complex structure, such as a linked list, which would allow
> dynamic growth/shrinkage of the handle list.
> Also see ZOOKEEPER-540
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-541) zkpython limited to 256 handles
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762839#action_12762839 ]
Henry Robinson commented on ZOOKEEPER-541:
------------------------------------------
This patch requires ZOOKEEPER-510 to be committed.
> zkpython limited to 256 handles
> -------------------------------
>
> Key: ZOOKEEPER-541
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-541
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-541.patch
>
>
> zkpython is currently limited to a max of 256 total handles - not 256 open handles, but rather 256 total handles created
> over the lifetime of the python application.
> In general this isn't a real issue, however in the case of a long lived application which polls the cluster periodically (closing
> the session btw calls) this is an issue.
> it would be great if the slots could be reused? or perhaps a more complex structure, such as a linked list, which would allow
> dynamic growth/shrinkage of the handle list.
> Also see ZOOKEEPER-540
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-541) zkpython limited to 256 handles
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-541:
-----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1 Looks good. Tests look good to me as well.
> zkpython limited to 256 handles
> -------------------------------
>
> Key: ZOOKEEPER-541
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-541
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-541.patch
>
>
> zkpython is currently limited to a max of 256 total handles - not 256 open handles, but rather 256 total handles created
> over the lifetime of the python application.
> In general this isn't a real issue, however in the case of a long lived application which polls the cluster periodically (closing
> the session btw calls) this is an issue.
> it would be great if the slots could be reused? or perhaps a more complex structure, such as a linked list, which would allow
> dynamic growth/shrinkage of the handle list.
> Also see ZOOKEEPER-540
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-541) zkpython limited to 256 handles
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765001#action_12765001 ]
Hadoop QA commented on ZOOKEEPER-541:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12421470/ZOOKEEPER-541.patch
against trunk revision 823371.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/2/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/2/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/2/console
This message is automatically generated.
> zkpython limited to 256 handles
> -------------------------------
>
> Key: ZOOKEEPER-541
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-541
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-541.patch
>
>
> zkpython is currently limited to a max of 256 total handles - not 256 open handles, but rather 256 total handles created
> over the lifetime of the python application.
> In general this isn't a real issue, however in the case of a long lived application which polls the cluster periodically (closing
> the session btw calls) this is an issue.
> it would be great if the slots could be reused? or perhaps a more complex structure, such as a linked list, which would allow
> dynamic growth/shrinkage of the handle list.
> Also see ZOOKEEPER-540
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-541) zkpython limited to 256 handles
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson updated ZOOKEEPER-541:
-------------------------------------
Status: In Progress (was: Patch Available)
Restarting Hudson now that ZOOKEEPER-510 has gone in.
> zkpython limited to 256 handles
> -------------------------------
>
> Key: ZOOKEEPER-541
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-541
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-541.patch
>
>
> zkpython is currently limited to a max of 256 total handles - not 256 open handles, but rather 256 total handles created
> over the lifetime of the python application.
> In general this isn't a real issue, however in the case of a long lived application which polls the cluster periodically (closing
> the session btw calls) this is an issue.
> it would be great if the slots could be reused? or perhaps a more complex structure, such as a linked list, which would allow
> dynamic growth/shrinkage of the handle list.
> Also see ZOOKEEPER-540
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.